Vojtech Szocs has posted comments on this change. Change subject: core,webadmin: GetConfigurationValuesQuery for UI cache ......................................................................
Patch Set 3: Looks good to me, but someone else must approve +1 for the frontend part. @Roy: we can't cache values becuase they can be reloaded/refreshed and we don't have notification mechanism about invalidation Indeed, we currently don't have any notification mechanism about config value invalidation. However, javadoc in AsyncDataProvider.GetConfigFromCache method says: "config is not supposed to change during a session" The user can simply refresh (F5) the application in order to retrieve latest config values, until we have some notification mechanism available. -- To view, visit http://gerrit.ovirt.org/8563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id51a9f86bceef07de728335643b16c0554b6876c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
