Allon Mureinik has posted comments on this change. Change subject: <core>: WipeAfterDelete defaults to true in GUI, but false in REST API. ......................................................................
Patch Set 3: I would prefer that you didn't submit this (2 inline comments) The code looks fine, please fix the problems with the commit message. .................................................... Commit Message Line 3: AuthorDate: 2012-10-15 17:41:37 +0200 Line 4: Commit: Ravi Nori <rn...@redhat.com> Line 5: CommitDate: 2012-10-17 14:47:11 +0200 Line 6: Line 7: <core>: WipeAfterDelete defaults to true in GUI, but false in REST API. s/<core>/core/ Line 8: Line 9: WipeAfterDelete in gui default to false for File Storage Domains and for Block storage domains the value is defined by SANWipeAfterDelete configuration value. The backend logic has been changed to mimic this behaviour. Line 10: Line 11: Change-Id: I8cb77b017282733d72ff66af499b576674674e01 Line 5: CommitDate: 2012-10-17 14:47:11 +0200 Line 6: Line 7: <core>: WipeAfterDelete defaults to true in GUI, but false in REST API. Line 8: Line 9: WipeAfterDelete in gui default to false for File Storage Domains and for Block storage domains the value is defined by SANWipeAfterDelete configuration value. The backend logic has been changed to mimic this behaviour. please break up this line with newlines - lines in the commit message should be under 72 chars. Line 10: Line 11: Change-Id: I8cb77b017282733d72ff66af499b576674674e01 Line 12: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=845466 -- To view, visit http://gerrit.ovirt.org/8628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cb77b017282733d72ff66af499b576674674e01 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
