Liron Aravot has posted comments on this change.
Change subject: core: WIP:AddStoragePoolWithStorages-prevent domains from stay
LOCKED
......................................................................
Patch Set 7: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java
Line 116: throw new
VdcBLLException(VdcBllErrors.ENGINE_ERROR_CREATING_STORAGE_POOL);
Line 117: }
Line 118: }
Line 119: }
Line 120:
StorageDomain status was set to LOCKED in UpdateStorageDomainsInDb();
and before calling ActivateStorageDomain the compensation was cleared.
ActivateStorageDomain used compensation on the status, so in case of error the
status always returned to LOCKED instead of to INACTIVE.
Line 121: for (Guid storageDomainId : getParameters().getStorages()) {
Line 122: getStoragePoolIsoMapDAO()
Line 123: .updateStatus(
Line 124: new StoragePoolIsoMapId(storageDomainId,
getStoragePool().getId()),
Line 220: .getstorage_pool_type(),
getStoragePool().getId(), getStoragePool().getname(),
Line 221: masterStorageDomain.getId(),
getParameters().getStorages(), getStoragePool()
Line 222: .getmaster_domain_version()));
Line 223: }
Line 224:
will change
Line 225: private void ActivateStorageDomains() {
Line 226: for (final Guid storageDomainId :
getParameters().getStorages()) {
Line 227: StorageDomainPoolParametersBase activateParameters = new
StorageDomainPoolParametersBase(storageDomainId,
Line 228: getStoragePool().getId());
--
To view, visit http://gerrit.ovirt.org/8536
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8b9fc0d324eac2146d4f7d60d48e4dd5eb5d9e0
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
