Allon Mureinik has uploaded a new change for review.
Change subject: core,webadmin: [WIP] Unifying Move and LiveMigrate
..
core,webadmin: [WIP] Unifying Move and LiveMigrate
Provide a simpler API for moving disks.
Created a sing
Muli Salem has posted comments on this change.
Change subject: core: Query GetVdsGroupsByNetworkId (WIP)
..
Patch Set 1: (3 inline comments)
File backend/manager/dbscripts/vd
Shireesh Anjal has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
..
Patch Set 20:
Here we go - removed the test-time dependency on dal. Testing the functionality
now with loads of da
Allon Mureinik has posted comments on this change.
Change subject: core: [WIP]: Live Storage Migration commands
..
Patch Set 17: (2 inline comments)
Commit Message
Line 14: 2
Allon Mureinik has posted comments on this change.
Change subject: core: [WIP]: Live Storage Migration commands
..
Patch Set 17:
Changes since last patchset:
1. Updated to newer VDSM API - removed the replicateExtend concept
2.
Allon Mureinik has posted comments on this change.
Change subject: core: [WIP] Adding VDSM API for LiveStorageMigration
..
Patch Set 12:
Updated to newer VDSM API - removed the replicateExtend concept
--
To view, visit http://
Allon Mureinik has posted comments on this change.
Change subject: core: Introducing SyncImageGroupVDSCommand
..
Patch Set 13:
Updated to newer VDSM API - removed the replicateExtend concept
--
To view, visit http://gerrit.ovi
Allon Mureinik has posted comments on this change.
Change subject: core: [WIP] introducing SPMAsyncTaskHandler
..
Patch Set 13:
Liron/Yair - will address, don't worry.
Also, need to encapsulate the API between commands and han
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: user cannnot take a vm from pool via restapi #864438
..
restapi: user cannnot take a vm from pool via restapi #864438
This patch implements
Michael Pasternak has posted comments on this change.
Change subject: restapi: user cannnot take a vm from pool via restapi #864438
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: Allow copying template disks to another storage domain
#851099
..
restapi: Allow copying template disks to another storage domain #851099
Michael Pasternak has posted comments on this change.
Change subject: restapi: Allow copying template disks to another storage domain
#851099
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit
Ori Liel has posted comments on this change.
Change subject: restapi: Allow copying template disks to another storage domain
#851099
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerr
Michael Pasternak has uploaded a new change for review.
Change subject: restapi: add disk.name property for disk.add() to ease < 3.1
clients migration
..
restapi: add disk.name property for disk.add() to ease < 3.1 clients migra
Ayal Baron has posted comments on this change.
Change subject: engine: Removing unneeded read query from SetVdsStatusVDSCommand
..
Patch Set 1: (3 inline comments)
File
back
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Removing all unneeded staff from VdsIdVDSCommandBase
..
Patch Set 1: Looks good to me, approved
I'm quite surprised that such a code even existed.
--
T
Allon Mureinik has posted comments on this change.
Change subject: engine:cannot start stateless VM
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll/src/m
Ori Liel has posted comments on this change.
Change subject: restapi: Allow copying template disks to another storage domain
#851099
..
Patch Set 1: (1 inline comment)
File
Shahar Havivi has posted comments on this change.
Change subject: Engine: Rhev-H upgrade list show downgraded versions (#842767)
..
Patch Set 7: Verified
Please note the commit message, we added a new file for the compatibility
Michael Pasternak has posted comments on this change.
Change subject: restapi: Allow copying template disks to another storage domain
#851099
..
Patch Set 1: (1 inline comment)
.
Roy Golan has posted comments on this change.
Change subject: engine:cannot start stateless VM
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll/src/main/j
Michael Pasternak has posted comments on this change.
Change subject: restapi: Allow copying template disks to another storage domain
#851099
..
Patch Set 2: (1 inline comment)
.
Muli Salem has uploaded a new change for review.
Change subject: core: Query GetVdsByNetworkId (WIP)
..
core: Query GetVdsByNetworkId (WIP)
This patch adds the query above as part of the
Network Main Tab feature.
Change-Id: If5
Ori Liel has posted comments on this change.
Change subject: restapi: Allow copying template disks to another storage domain
#851099
..
Patch Set 1: (3 inline comments)
File
Gal Hammer has posted comments on this change.
Change subject: replaced agent license to apache software license (asl) 2.0.
..
Patch Set 1: (1 inline comment)
File ovirt-gues
Liron Aravot has posted comments on this change.
Change subject: core: avoid having SD active on vdsm and not in engine
..
Patch Set 2: (2 inline comments)
File
backend/mana
Ori Liel has posted comments on this change.
Change subject: restapi: user cannnot take a vm from pool via restapi #864438
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Michael Pasternak has posted comments on this change.
Change subject: restapi: user cannnot take a vm from pool via restapi #864438
..
Patch Set 2: (1 inline comment)
File
b
Shahar Havivi has posted comments on this change.
Change subject: webadmin: remove domain column from template main grid (#837025)
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/8229
To unsubscribe, visit ht
Shahar Havivi has posted comments on this change.
Change subject: webadmin: rename Allocation to Space Allocation in new VM
dialog (#837025)
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/8228
To unsubscrib
Ori Liel has posted comments on this change.
Change subject: restapi: user cannnot take a vm from pool via restapi #864438
..
Patch Set 2: (1 inline comment)
File
backend/ma
Michael Pasternak has posted comments on this change.
Change subject: restapi: user cannnot take a vm from pool via restapi #864438
..
Patch Set 2: (2 inline comments)
File
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Moved generic methods from GlusterCoreUtil
..
engine: Moved generic methods from GlusterCoreUtil
Generic methods like objectsEqual, listsEquel
Michael Kublin has posted comments on this change.
Change subject: engine: Moved generic methods from GlusterCoreUtil
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8434
To unsubs
Michael Kublin has posted comments on this change.
Change subject: engine: Removing all unneeded staff from VdsIdVDSCommandBase
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8496
To unsubscribe, visit http:
Michael Kublin has uploaded a new change for review.
Change subject: engine: Removing all unneeded staff from VdsIdVDSCommandBase
..
engine: Removing all unneeded staff from VdsIdVDSCommandBase
1. Removed garbage comments
2. Rem
Ori Liel has posted comments on this change.
Change subject: restapi: user cannnot take a vm from pool via restapi #864438
..
Patch Set 2: (2 inline comments)
File
backend/m
Barak Azulay has posted comments on this change.
Change subject: replaced agent license to apache software license (asl) 2.0.
..
Patch Set 1: (1 inline comment)
File ovirt-gu
Ori Liel has posted comments on this change.
Change subject: restapi: Allow copying template disks to another storage domain
#851099
..
Patch Set 2: (1 inline comment)
File
Michael Kublin has posted comments on this change.
Change subject: engine: Clean up of VDS class
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8494
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Michael Kublin has uploaded a new change for review.
Change subject: engine: Clean up of VDS class
..
engine: Clean up of VDS class
Removed unneeded staff
Change-Id: I9613bbd2e5000cb507839fd313bfdfb6087835ec
Signed-off-by: Mich
Alon Bar-Lev has posted comments on this change.
Change subject: engine: Passwordless ssh status query
..
Patch Set 1:
No I don't know any.
But I don't understand when you throw SshConnectionFailed for example... I see
you de
Selvasundaram has posted comments on this change.
Change subject: engine: Passwordless ssh status query
..
Patch Set 1:
Following use case requires the passwordless ssh setup status,
Gluster volume 'Geo-replication' requires p
Michael Pasternak has posted comments on this change.
Change subject: restapi: Allow copying template disks to another storage domain
#851099
..
Patch Set 1: (4 inline comments)
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Get Volume Advanced Details Query
..
Patch Set 15: Verified
--
To view, visit http://gerrit.ovirt.org/7807
To unsubscribe, visit http://gerrit.ovirt.o
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Get Volume Advanced Details Query
..
Patch Set 14: (2 inline comments)
Incorporated review comments.
Alon Bar-Lev has posted comments on this change.
Change subject: engine: Passwordless ssh status query
..
Patch Set 1:
Not that I have something to contribute... I don't see the actual ssh usage, so
I guess this is code reuse.
Allon Mureinik has posted comments on this change.
Change subject: engine:cannot start stateless VM
..
Patch Set 2: (1 inline comment)
see inline
File
backend/manager/modul
Ori Liel has posted comments on this change.
Change subject: restapi: Allow copying template disks to another storage domain
#851099
..
Patch Set 1: (4 inline comments)
File
Michael Kublin has posted comments on this change.
Change subject: core: Add support for iLO2 and iLO4 as...(#837907)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8492
To unsubscribe, vis
Mike Kolesnik has submitted this change and it was merged.
Change subject: restapi: Don't raise 404 if slave not found
..
restapi: Don't raise 404 if slave not found
If slave wasn't found, then just map without template, otherw
Mike Kolesnik has posted comments on this change.
Change subject: restapi: Don't raise 404 if slave not found
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8490
To unsubscribe, visit http://gerrit.ovirt.org
Mike Kolesnik has submitted this change and it was merged.
Change subject: restapi: If slave id is not set, lookup by name
..
restapi: If slave id is not set, lookup by name
If slave ID for bonding is not set, then need to look
Mike Kolesnik has posted comments on this change.
Change subject: restapi: If slave id is not set, lookup by name
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8489
To unsubscribe, visit http://gerrit.ovirt
Michael Kublin has posted comments on this change.
Change subject: core: fix module name in fencing logs(#652581)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8491
To unsubscribe, visit h
Michael Pasternak has posted comments on this change.
Change subject: restapi: Don't raise 404 if slave not found
..
Patch Set 1: Looks good to me, approved
agreed with mkolesni, that BE will validate slaves existence.
--
To v
Michael Kublin has posted comments on this change.
Change subject: engine: Removing unneeded read query from SetVdsStatusVDSCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8493
To unsubscribe, visit h
Michael Kublin has uploaded a new change for review.
Change subject: engine: Removing unneeded read query from SetVdsStatusVDSCommand
..
engine: Removing unneeded read query from SetVdsStatusVDSCommand
The following query was us
Shahar Havivi has posted comments on this change.
Change subject: webadmin: remove domain column from template main grid (#837025)
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/8229
To unsubscribe, visit ht
Shahar Havivi has posted comments on this change.
Change subject: webadmin: rename Allocation to Space Allocation in new VM
dialog (#837025)
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/8228
To unsubscrib
Shahar Havivi has posted comments on this change.
Change subject: webadmin: rename Allocation to Space Allocation in new VM
dialog (#837025)
..
Patch Set 2: (2 inline comments)
.
Eli Mesika has uploaded a new change for review.
Change subject: core: Add support for iLO2 and iLO4 as...(#837907)
..
core: Add support for iLO2 and iLO4 as...(#837907)
Add support for iLO2 and iLO4 as a fencing options(#837907
Roy Golan has posted comments on this change.
Change subject: [RFE] Integrate smartcard support
..
Patch Set 3: (1 inline comment)
what about import / export flows?
File
ba
Michael Pasternak has posted comments on this change.
Change subject: restapi: If slave id is not set, lookup by name
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
minor comment
...
Roy Golan has posted comments on this change.
Change subject: engine:cannot start stateless VM
..
Patch Set 2:
Allon - please have a look here and see this sits with your last refactoring
Frank - can you please verify by runni
Michael Pasternak has posted comments on this change.
Change subject: restapi: Don't raise 404 if slave not found
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
..
Yair Zaslavsky has posted comments on this change.
Change subject: core: fix module name in fencing logs(#652581)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8491
To unsubscribe, visit h
Eli Mesika has uploaded a new change for review.
Change subject: core: fix module name in fencing logs(#652581)
..
core: fix module name in fencing logs(#652581)
This patch changes the term "Fencing" to "Fence" in all log keys &
Roy Golan has posted comments on this change.
Change subject: core: Removing reschedule of monitoring of vdsm by another vdsm
..
Patch Set 1:
good catch. but we may still want to preserve that behaviour in case the
interval of
Eli Mesika has posted comments on this change.
Change subject: engine: Execution messages for Gluster Volume Actions (#856102)
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7967
To unsubsc
Eli Mesika has posted comments on this change.
Change subject: Don't add the cdrom device if iso_path is empty
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8092
To unsubscribe, visit http
Eli Mesika has posted comments on this change.
Change subject: core: Removing reschedule of monitoring of vdsm by another vdsm
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Mike Kolesnik has uploaded a new change for review.
Change subject: restapi: Don't raise 404 if slave not found
..
restapi: Don't raise 404 if slave not found
If slave wasn't found, then just map without template, otherwise the
Mike Kolesnik has uploaded a new change for review.
Change subject: restapi: If slave id is not set, lookup by name
..
restapi: If slave id is not set, lookup by name
If slave ID for bonding is not set, then need to look for the
Michael Pasternak has uploaded a new change for review.
Change subject: restapi: user cannnot take a vm from pool via restapi #864438
..
restapi: user cannnot take a vm from pool via restapi #864438
This patch implements new act
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine: PM configuration during host installation sometime
fails due to a race
..
engine: PM configuration during host installation sometime fails due
Yair Zaslavsky has posted comments on this change.
Change subject: engine: PM configuration during host installation sometime
fails due to a race
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt
Yair Zaslavsky has posted comments on this change.
Change subject: core: [WIP] introducing SPMAsyncTaskHandler
..
Patch Set 12: (1 inline comment)
File
backend/manager/modul
Daniel Erez has posted comments on this change.
Change subject: webadmin: remove domain column from template main grid (#837025)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8229
To unsub
Michael Kublin has posted comments on this change.
Change subject: engine: PM configuration during host installation sometime
fails due to a race
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8485
To unsub
Michael Kublin has uploaded a new change for review.
Change subject: engine: PM configuration during host installation sometime
fails due to a race
..
engine: PM configuration during host installation sometime fails due to a rac
Daniel Erez has posted comments on this change.
Change subject: webadmin: rename Allocation to Space Allocation in new VM
dialog (#837025)
..
Patch Set 2: (2 inline comments)
...
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Get Volume Advanced Details Query
..
Patch Set 14: (2 inline comments)
File
backend/manager/module
Tomas Jelinek has uploaded a new change for review.
Change subject: [RFE] Integrate smartcard support
..
[RFE] Integrate smartcard support
This patch integrates the smartcard support into the
frontend and engine.
The behavior o
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine:Cannot remove iscsi master storage right after removing
the storage pool
..
engine:Cannot remove iscsi master storage right after removing the s
Yair Zaslavsky has posted comments on this change.
Change subject: engine:Cannot remove iscsi master storage right after removing
the storage pool
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovir
Yair Zaslavsky has posted comments on this change.
Change subject: core: [WIP] introducing SPMAsyncTaskHandler
..
Patch Set 12: (1 inline comment)
File
backend/manager/modul
Michael Kublin has posted comments on this change.
Change subject: engine:Cannot remove iscsi master storage right after removing
the storage pool
..
Patch Set 2: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/836
Shahar Havivi has posted comments on this change.
Change subject: webadmin: rename Allocation to Space Allocation in new VM
dialog (#837025)
..
Patch Set 1: (1 inline comment)
..
Michael Kublin has posted comments on this change.
Change subject: core: Removing reschedule of monitoring of vdsm by another vdsm
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8483
To unsubscribe, visit ht
Michael Kublin has uploaded a new change for review.
Change subject: core: Removing reschedule of monitoring of vdsm by another vdsm
..
core: Removing reschedule of monitoring of vdsm by another vdsm
The following patch will rem
Liron Aravot has posted comments on this change.
Change subject: core: [WIP] introducing SPMAsyncTaskHandler
..
Patch Set 12: (1 inline comment)
File
backend/manager/modules
Allon Mureinik has posted comments on this change.
Change subject: core: QuotaManager Test - test 5,6
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8465
To unsubscribe
Allon Mureinik has posted comments on this change.
Change subject: core: QuotaManager Test - test 2,3,4
..
Patch Set 2: I would prefer that you didn't submit this
Same issues I had with the previous patch:
1. Find better names
Allon Mureinik has posted comments on this change.
Change subject: core: QuotaManager Test - test 1
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
-1 on the naming, +1 on everything else.
Consid
Allon Mureinik has posted comments on this change.
Change subject: core : QuotaMnager Test - basic structure
..
Patch Set 7: (6 inline comments)
Sorry, missed some issues in the previous patchset - see inline.
Allon Mureinik has posted comments on this change.
Change subject: webadmin, core: Use NFS v3 as default
..
Patch Set 2: Looks good to me, but someone else must approve
(2 inline comments)
Looks OK, see suggestions inline.
..
97 matches
Mail list logo
