Michael Pasternak has posted comments on this change.
Change subject: restapi: If slave id is not set, lookup by name
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
minor comment
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java
Line 352: VdsNetworkInterface iface = map(nic, null);
Line 353: ifaces.add(iface);
Line 354: if (nic.isSetBonding() && nic.getBonding().isSetSlaves())
{
Line 355: for (HostNIC slave :
nic.getBonding().getSlaves().getSlaves()) {
Line 356: VdsNetworkInterface slaveIface = map(slave,
slave.getId() == null
we using slave.isSetId() instead of "slave.getId() == null" (pls change in sake
of consistency)
Line 357: ? lookupInterfaceByName(slave.getName())
: lookupInterface(slave.getId()));
Line 358: slaveIface.setBondName(nic.getName());
Line 359: ifaces.add(slaveIface);
Line 360: }
--
To view, visit http://gerrit.ovirt.org/8489
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea876e039c98665d01314bc73661044e33db6291
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
