Daniel Erez has posted comments on this change.
Change subject: webadmin: rename Allocation to Space Allocation in new VM
dialog (#837025)
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
Line 598: @DefaultStringValue("Type")
Line 599: String typeDisk();
Line 600:
Line 601: @DefaultStringValue("Space Allocation")
Line 602: String allocationDisk();
Some columns probably need to be enlarged..
Line 603:
Line 604: @DefaultStringValue("Interface")
Line 605: String interfaceDisk();
Line 606:
Line 757: @DefaultStringValue("Interface")
Line 758: String interfaceVmDiskPopup();
Line 759:
Line 760: @DefaultStringValue("Format")
Line 761: String formatVmDiskPopup();
'Format' can be removed now (and its usages replaced with 'allocationDisk()')
Line 762:
Line 763: @DefaultStringValue("Storage Type")
Line 764: String storageTypeVmDiskPopup();
Line 765:
--
To view, visit http://gerrit.ovirt.org/8228
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf2e851113e9788ac0f116c7126f0e72255d1c81
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
