Yair Zaslavsky has posted comments on this change. Change subject: engine: Get Volume Advanced Details Query ......................................................................
Patch Set 14: (2 inline comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/BrickProperties.java Line 20: private int pid; Line 21: Line 22: private GlusterStatus status; Line 23: Line 24: private Double totalSize; Sorry for nagging here - but once again - can these Double values be null? if not, change to double. Line 25: Line 26: private Double freeSize; Line 27: Line 28: private String device; .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDao.java Line 22: Line 23: public GlusterVolumeEntity getByName(Guid clusterId, String volName); Line 24: Line 25: public List<GlusterVolumeEntity> getByClusterId(Guid clusterId); Line 26: A question here (sorry I forgot in previous reviews) - if volumes can be not just NFS, don't we want a more "generic" method instead of getNdsEnabledVolumes? Line 27: public List<GlusterVolumeEntity> getNfsEnabledVolumes(Guid clusterId, GlusterStatus status); Line 28: Line 29: @Override Line 30: public List<GlusterVolumeEntity> getAllWithQuery(String query); -- To view, visit http://gerrit.ovirt.org/7807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6b590eaebeb1d06b7278300d5e12b2dab9eb093 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
