Michael Kublin has uploaded a new change for review.

Change subject: engine: PM configuration during host installation sometime 
fails due to a race
......................................................................

engine: PM configuration during host installation sometime fails due to a race

The following bug was caused because of we are not setting serverUniqueId when 
it
retrieved and we are saving a new vdsm object to DB without serverUniqueId.

Change-Id: I03fc1f4a6ad07430b5e583103d2ae1d5878940f5
Bug-Url: https://bugzilla.redhat.com/833382
Signed-off-by: Michael Kublin <mkub...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/85/8485/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
index 42fe613..b05b8c1 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
@@ -359,6 +359,9 @@
                         serverUniqueId = serverUniqueId.trim();
                     }
                     retrunValue = retrunValue && validateHostUniqueId(vds, 
serverUniqueId);
+                    if(retrunValue) {
+                        vds.setUniqueId(serverUniqueId);
+                    }
                 }
             } finally {
                 try {


--
To view, visit http://gerrit.ovirt.org/8485
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I03fc1f4a6ad07430b5e583103d2ae1d5878940f5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to