Ori Liel has posted comments on this change.
Change subject: restapi: Allow copying template disks to another storage domain
#851099
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResource.java
Line 16:
Line 17: protected BackendTemplateDisksResource collection;
Line 18:
Line 19: public BackendTemplateDiskResource(Class<Disk> modelType,
Line 20:
Class<org.ovirt.engine.core.common.businessentities.Disk> entityType,
There is a substantial difference. You make the constructor receive constant
values. A constructor, or any method for that matter, should only receive
variables.
If the constructor *always* calls super() with
org.ovirt.engine.api.model.Disk.class and
org.ovirt.engine.core.common.businessentities.Disk (constant values) why make
them a part of its signature and force client code to always provide them?
Line 21: Guid guid,
Line 22: BackendTemplateDisksResource
collection,
Line 23: String... subCollections) {
Line 24: super(modelType, entityType, guid, collection, subCollections);
--
To view, visit http://gerrit.ovirt.org/8428
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic629b331e4753b24ef02612ff50cb6a4457cfd58
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
