Michael Kublin has uploaded a new change for review.
Change subject: engine: Removing unneeded read query from SetVdsStatusVDSCommand
......................................................................
engine: Removing unneeded read query from SetVdsStatusVDSCommand
The following query was used in order to prevent some kind of race,
obvious that a probability that such approach will help is too small.
Additional query is perfromed all the time
Change-Id: If468915f3bde5c5e2599ee50c38515795a555e79
Signed-off-by: Michael Kublin <mkub...@redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVdsStatusVDSCommand.java
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/93/8493/1
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVdsStatusVDSCommand.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVdsStatusVDSCommand.java
index bf8b246..099975e 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVdsStatusVDSCommand.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVdsStatusVDSCommand.java
@@ -6,7 +6,6 @@
import org.ovirt.engine.core.common.vdscommands.ResetIrsVDSCommandParameters;
import
org.ovirt.engine.core.common.vdscommands.SetVdsStatusVDSCommandParameters;
import org.ovirt.engine.core.common.vdscommands.VDSCommandType;
-import org.ovirt.engine.core.dal.dbbroker.DbFacade;
import org.ovirt.engine.core.utils.log.Log;
import org.ovirt.engine.core.utils.log.LogFactory;
@@ -27,9 +26,6 @@
_vdsManager.UpdateDynamicData(vds.getDynamicData());
_vdsManager.UpdateStatisticsData(vds.getStatisticsData());
- // In case the SPM status has changed during execution in the
StoragePool table we have to fetch the VDS
- // (which is a view) again.
- vds =
DbFacade.getInstance().getVdsDao().get(parameters.getVdsId());
if (vds.getspm_status() != VdsSpmStatus.None &&
parameters.getStatus() != VDSStatus.Up) {
log.infoFormat("SetVdsStatusVDSCommand::VSD {0} is spm and
moved from up calling ResetIrs.",
vds.getvds_name());
--
To view, visit http://gerrit.ovirt.org/8493
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If468915f3bde5c5e2599ee50c38515795a555e79
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
