Selvasundaram has posted comments on this change.
Change subject: engine: Start Gluster Volume Profile command
..
Patch Set 2: (1 inline comment)
File
backend/manager/module
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: updated handling of pgpass file between versions
..
Patch Set 3: (1 inline comment)
File packaging
Tomas Jelinek has posted comments on this change.
Change subject: engine: vm doesn't boot from cd when CD set in "edit" (#856806)
..
Patch Set 3: (1 inline comment)
File
bac
Yair Zaslavsky has posted comments on this change.
Change subject: core: order collections at updateAllInTransaction
..
Patch Set 3:
Allon - I didn't like the code mulitplication myself.
I'll go with your offer of the helper cl
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: remove MAC address from vds unique id
..
Patch Set 7:
Manual rebased.
--
To view, visit http://gerrit.ovirt.org/8125
To unsubscribe, visit http://gerr
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: add a method to work with parsed sql output
..
Patch Set 6: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/8124
To unsubscribe, visit http
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: remove MAC address from vds unique id
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/8125
To unsubscribe, visit http://gerrit.ovirt
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: update order of db backup
..
Patch Set 1:
Why?
Are you sure it is OK? as if there will be an exception in backup you will try
to restore invalid stat
Alex Lourie has posted comments on this change.
Change subject: packaging: update order of db backup
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8281
To unsubscribe, visit http://gerrit.ovirt.org/settings
Allon Mureinik has posted comments on this change.
Change subject: core: order collections at updateAllInTransaction
..
Patch Set 3:
Yair - I get your reasoning, but I really dislike the code multiplication in
implementing com
Allon Mureinik has posted comments on this change.
Change subject: core: change vdsSpmId related command to support numerous vdss
..
Patch Set 6: I would prefer that you didn't submit this
(6 inline comments)
-1 based on a par
Liron Aravot has posted comments on this change.
Change subject: core: prevent simultaneous reconstructs on the same
pool(#845838)
..
Patch Set 12:
mkublin,
Patch Set 12:
there will be an attempt to acquire this lock anyway
Michael Kublin has posted comments on this change.
Change subject: core: Forbid attaching a locked disk to a VM
..
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
Michael Kublin has posted comments on this change.
Change subject: core: prevent simultaneous reconstructs on the same
pool(#845838)
..
Patch Set 12:
I am sorry that I need to write these:
1. These patch came to 12 revision, w
Alex Lourie has uploaded a new change for review.
Change subject: packaging: update order of db backup
..
packaging: update order of db backup
Change-Id: Ide1d9635ec51d30b6a508b5319fc6c4f399cb44f
Signed-off-by: Alex Lourie
---
Vered Volansky has posted comments on this change.
Change subject: core: Forbid attaching a locked disk to a VM
..
Patch Set 5:
No change from patch set 4?
--
To view, visit http://gerrit.ovirt.org/8167
To unsubscribe, visit h
Michael Kublin has posted comments on this change.
Change subject: core: [WIP] introducing SPMAsyncTaskHandler
..
Patch Set 9: I would prefer that you didn't submit this
"Yair, refactoring the entire task system is a whole diff
Michael Kublin has posted comments on this change.
Change subject: core: [WIP]: Live Storage Migration commands
..
Patch Set 10: I would prefer that you didn't submit this
(1 inline comment)
...
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: disable Ctrl-C during setup/upgrade
..
Patch Set 3: (1 inline comment)
File packaging/fedora/setup
Vered Volansky has posted comments on this change.
Change subject: core: Changed illegal error msg to locked(#840304)
..
Patch Set 4: (1 inline comment)
File
backend/manager
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: rollback database if only pki upgrade took place
..
Patch Set 1:
Because there are some changes in the database, see the CA.prepare() function.
--
To
Alex Lourie has posted comments on this change.
Change subject: packaging: cleanup: sync log file global variable in setup and
upgrade
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://ge
Alex Lourie has posted comments on this change.
Change subject: packaging: disable Ctrl-C during setup/upgrade
..
Patch Set 3: (1 inline comment)
File packaging/fedora/setup/
Alex Lourie has posted comments on this change.
Change subject: packaging: rollback database if only pki upgrade took place
..
Patch Set 1:
Sorry, I don't really get it. If pki change failed, DB should be rolled back?
Why?
--
Daniel Erez has submitted this change and it was merged.
Change subject: core: fix to AddVdsSpmIdCommand
..
core: fix to AddVdsSpmIdCommand
related to https://bugzilla.redhat.com/show_bug.cgi?id=771699
Currently AddVdsSpmIdCom
Daniel Erez has posted comments on this change.
Change subject: core: fix to AddVdsSpmIdCommand
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8278
To unsubscribe, visit http://ge
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: Snapshots sub-tab - Disks tab modifications
..
webadmin: Snapshots sub-tab - Disks tab modifications
* Renamed 'Name' column to 'Alias'.
* Added 'Descri
Allon Mureinik has posted comments on this change.
Change subject: core: fix to AddVdsSpmIdCommand
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8278
To unsubscribe, v
Allon Mureinik has posted comments on this change.
Change subject: webadmin: Display the single status of domains in main tab.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Liron Aravot has posted comments on this change.
Change subject: core: fix to AddVdsSpmIdCommand
..
Patch Set 1: No score
--
To view, visit http://gerrit.ovirt.org/8278
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Liron Aravot has posted comments on this change.
Change subject: core: fix to AddVdsSpmIdCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8278
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Tal Nisan has posted comments on this change.
Change subject: core: fix to AddVdsSpmIdCommand
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8278
To unsubscribe, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: core: fix to AddVdsSpmIdCommand
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8278
To unsubscribe, v
Federico Simoncelli has posted comments on this change.
Change subject: core: trust the SpmStart task result during election
..
Patch Set 4: Verified
Worksforme.
--
To view, visit http://gerrit.ovirt.org/8072
To unsubscribe, v
Liron Aravot has uploaded a new change for review.
Change subject: core: fix to AddVdsSpmIdCommand
..
core: fix to AddVdsSpmIdCommand
related to https://bugzilla.redhat.com/show_bug.cgi?id=771699
Currently AddVdsSpmIdCommand re
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: edit disk - hide attach checkbox (#854543)
..
webadmin: edit disk - hide attach checkbox (#854543)
Edit disk dialog:
hide 'Attach Disk' check-bo
Daniel Erez has posted comments on this change.
Change subject: webadmin: edit disk - hide attach checkbox (#854543)
..
Patch Set 2: Verified; Looks good to me, approved
rebased.
approved by Tal Nisan.
--
To view, visit http:/
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: select last snapshot by default (#851094)
..
webadmin: select last snapshot by default (#851094)
VMs main-tab -> Snapshots sub-tab:
select the l
Daniel Erez has posted comments on this change.
Change subject: webadmin: select last snapshot by default (#851094)
..
Patch Set 4: Verified; Looks good to me, approved
rebased.
approved by Tal Nisan.
--
To view, visit http://
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: cleanup: sync log file global variable in setup and
upgrade
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/8266
To unsubscribe, vi
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: disable Ctrl-C during setup/upgrade
..
Patch Set 3: Verified
Manual rebase.
--
To view, visit http://gerrit.ovirt.org/8267
To unsubscribe, visit http:
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: cleanup: sync log file global variable in setup and
upgrade
..
Patch Set 4:
Rebase
--
To view, visit http://gerrit.ovirt.org/8266
To unsubscribe, vis
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: use yum API
..
Patch Set 6: Verified
Rebase + lower conflicts with[1].
[1] http://gerrit.ovirt.org/#/c/8276/
--
To view, visit http://gerrit.ovirt.or
Liron Aravot has uploaded a new change for review.
Change subject: core: change vdsSpmId related command to support numerous vdss
..
core: change vdsSpmId related command to support numerous vdss
related to bug https://bugzilla.
Liron Aravot has posted comments on this change.
Change subject: core: prevent simultaneous reconstructs on the same
pool(#845838)
..
Patch Set 12: (4 inline comments)
File
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix actual size column in disk view (#847800)
..
webadmin: Fix actual size column in disk view (#847800)
https://bugzilla.redhat.com/847800
Fixed
Tal Nisan has posted comments on this change.
Change subject: webadmin: Fix actual size column in disk view (#847800)
..
Patch Set 2: Verified; Looks good to me, approved
Rebase
--
To view, visit http://gerrit.ovirt.org/8257
T
Tal Nisan has posted comments on this change.
Change subject: webadmin: select last snapshot by default (#851094)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8260
To unsubscribe, visit h
Daniel Erez has posted comments on this change.
Change subject: webadmin: select last snapshot by default (#851094)
..
Patch Set 2: (1 inline comment)
File
frontend/webadmin
Tal Nisan has posted comments on this change.
Change subject: webadmin: select last snapshot by default (#851094)
..
Patch Set 2: (1 inline comment)
File
frontend/webadmin/m
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: rollback database if only pki upgrade took place
..
Patch Set 1: Verified
Sorry guys, missed one flow. Good I am doing the miniyum thing... :)
--
To v
Tal Nisan has posted comments on this change.
Change subject: webadmin: edit disk - hide attach checkbox (#854543)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8259
To unsubscribe, visit
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: rollback database if only pki upgrade took place
..
packaging: rollback database if only pki upgrade took place
Currently if database packages is not
Allon Mureinik has posted comments on this change.
Change subject: engine: upgrade.sh for upgrading multiple DBs
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8146
To
Allon Mureinik has posted comments on this change.
Change subject: core: Extracted VmValidator
..
Patch Set 6: (1 inline comment)
File
backend/manager/modules/bll/src/main/j
Ayal Baron has posted comments on this change.
Change subject: core: Extracted VmValidator
..
Patch Set 6: (2 inline comments)
File
backend/manager/modules/bll/src/main/java
Allon Mureinik has posted comments on this change.
Change subject: webadmin: Display the single status of domains in main tab.
..
Patch Set 1: (1 inline comment)
agreed on the cross-dc-status issue, please fix the other two min
Ayal Baron has posted comments on this change.
Change subject: core: [WIP] introducing SPMAsyncTaskHandler
..
Patch Set 9:
Yair, refactoring the entire task system is a whole different ball game and
should be done separately.
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: Display the single status of domains in main tab.
..
Patch Set 1: (1 inline comment)
File
fronte
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup VMCommand
..
Patch Set 1: Looks good to me, but someone else must approve
(2 inline comments)
...
Roy Golan has posted comments on this change.
Change subject: core: Cleanup VMCommand
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/src/main/java/org/o
Yair Zaslavsky has posted comments on this change.
Change subject: core: [WIP] introducing SPMAsyncTaskHandler
..
Patch Set 9:
Reply to patchset 8 -
Indeed I hoped we can extract out task creation from commands "on the way" if
Daniel Erez has submitted this change and it was merged.
Change subject: core: check for duplicate upgrade scripts on unix
..
core: check for duplicate upgrade scripts on unix
The check for duplicate upgrade scripts is implemen
Daniel Erez has posted comments on this change.
Change subject: core: check for duplicate upgrade scripts on unix
..
Patch Set 5: Verified; Looks good to me, approved
rebased.
approved by Eli Mesika.
--
To view, visit http://g
Yair Zaslavsky has posted comments on this change.
Change subject: core: order collections at updateAllInTransaction
..
Patch Set 3:
Allon Mureinik - we have some Entities implement BusinessEntity and extend
IVdcQueryable (see
Moti Asayag has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
..
Patch Set 14: (4 inline comments)
File backend/manager/dbscripts/
Daniel Erez has posted comments on this change.
Change subject: webadmin: fix possible null exception in BooleanRenderer
..
Patch Set 2: Looks good to me, approved
(1 inline comment)
...
Daniel Erez has posted comments on this change.
Change subject: webadmin: Fix actual size column in disk view (#847800)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8257
To unsubscribe, v
Kiril Nesenko has posted comments on this change.
Change subject: packaging: cleanup: sync log file global variable in setup and
upgrade
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://
Kiril Nesenko has posted comments on this change.
Change subject: packaging: disable Ctrl-C during setup/upgrade
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8267
To
Ayal Baron has posted comments on this change.
Change subject: core: prevent simultaneous reconstructs on the same
pool(#845838)
..
Patch Set 12: I would prefer that you didn't submit this
(4 inline comments)
Yair Zaslavsky has posted comments on this change.
Change subject: core: ordering getAllFromVms
..
Patch Set 3:
Reply to Allon mureinik:
This patch is about solving a specific bug.
I can add ordering to the relevant SPs of the
Yair Zaslavsky has posted comments on this change.
Change subject: core: order collections at updateAllInTransaction
..
Patch Set 3:
Reply to Allon mureinik:
This is an option. I'll do it.
--
To view, visit http://gerrit.ovi
Ayal Baron has posted comments on this change.
Change subject: core: Changed illegal error msg to locked(#840304)
..
Patch Set 4: (1 inline comment)
File
backend/manager/mod
74 matches
Mail list logo
