Michael Kublin has posted comments on this change.
Change subject: core: [WIP]: Live Storage Migration commands
......................................................................
Patch Set 10: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java
Line 65: }
Line 66:
Line 67: /* Overridden CommandBase Methods */
Line 68:
Line 69: @Override
These has name , circular reference, now you created LiveMigrateDiskCommand
which is points on CreateImagePlaceholderTaskHandler,
VmMigrationDiskStartTaskHandler, VmMigrationDiskCompleteTaskHandler
and each of them is points on LiveMigrateDiskCommand.
If it is not circular reference what it is? Please give me a name of that
design patter.
Line 70: protected List<SPMAsyncTaskHandler> initTaskHandlers() {
Line 71: return Arrays.<SPMAsyncTaskHandler> asList(
Line 72: new CreateImagePlaceholderTaskHandler(this),
Line 73: new VmMigrationDiskStartTaskHandler(this),
--
To view, visit http://gerrit.ovirt.org/8105
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I253891a0a18863086e36a9b17d008cebbc77adc1
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
