Liron Aravot has uploaded a new change for review. Change subject: core: fix to AddVdsSpmIdCommand ......................................................................
core: fix to AddVdsSpmIdCommand related to https://bugzilla.redhat.com/show_bug.cgi?id=771699 Currently AddVdsSpmIdCommand relies on that the vds was previously removed from it's previous DC (if present), the fix to this bug rearranged the order of the commands so that the vds is added to the new DC at first and then removed from it's previous DC, so this check caused that hosts couldn't be moved between DC. Change-Id: Id311f2ae71eda95d122ce186f0da1d87768eab0d Signed-off-by: Liron Aravot <lara...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/78/8278/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java index 0c36238..c110804 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java @@ -37,8 +37,7 @@ @Override protected boolean canDoAction() { // check if vds already has vds spm id and storage pool exists - if (Guid.Empty.equals(getVds().getstorage_pool_id()) - || DbFacade.getInstance().getVdsSpmIdMapDao().get(getVdsId()) != null) { + if (Guid.Empty.equals(getVds().getstorage_pool_id())) { return false; } vds_spm_id_mapList = DbFacade.getInstance().getVdsSpmIdMapDao().getAll( -- To view, visit http://gerrit.ovirt.org/8278 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id311f2ae71eda95d122ce186f0da1d87768eab0d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
