Michael Kublin has posted comments on this change. Change subject: core: prevent simultaneous reconstructs on the same pool(#845838) ......................................................................
Patch Set 12: I am sorry that I need to write these: 1. These patch came to 12 revision, when it has -2 from 4-5 2. Each revision is worse than previous one. 3. The comment is wrong, the cause of bug is different and instead of solving a problem described in bug you are chasing unicorn 4. Now, I am explaining (even I has explained it already): take a look where lockIrsProxyLockObject() it is used inside UpdateVdsDomainsData, which is called from monitoring of vdsm, which is occurring every 2 seconds. How many triggered reconstructs will not run at all because we took a lock and we failed at canDoAction of reconstruct? Buy the way, IrsProxyData timer is not only place which can cause a reconstruct My advice, change a description of patch and provide a good solution or abandon a patch. -- To view, visit http://gerrit.ovirt.org/7982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0dfb227b014af602e5bd1ab952d7c543992aa0f Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Paikov <pai...@gmail.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
