Michael Kublin has posted comments on this change. Change subject: core: [WIP] introducing SPMAsyncTaskHandler ......................................................................
Patch Set 9: I would prefer that you didn't submit this "Yair, refactoring the entire task system is a whole different ball game and should be done separately. It is not in the scope of live storage migration." - Introduce a circular reference, reduce readability of code, to cause a performance problem, these is in scope? Allon, when you add inside constructor taskHandlers = initTaskHandlers(); and inside AbstractSPMAsyncTaskHandle you introduced private C cmd, I understand that you inside command base initTaskHandler will usually return null, but really after that asking me where I see a circular reference, so I added you additional -1 in another patch. By the way, it is very easy to fix these. -- To view, visit http://gerrit.ovirt.org/7956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f2d113ced0276a9d849b7f00c7757e003d35f4c Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
