Ayal Baron has posted comments on this change.
Change subject: core: Changed illegal error msg to locked(#840304)
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 475: messages.add(String.format("$%1$s %2$s",
"diskAliases", StringUtils.join(lockedDisksAliases, ", ")));
Line 476: }
Line 477: }
Line 478:
Line 479: if (returnValue && vm.getstatus() ==
VMStatus.ImageLocked) {
Doesn't ImageLocked mean that you cannot perform operations on the VM because
one or more of its disks are locked?
i.e. I don't understand the difference between this state and the above state
with the new message.
Line 480: ListUtils.nullSafeAdd(messages,
VdcBllMessages.ACTION_TYPE_FAILED_VM_IMAGE_IS_LOCKED.toString());
Line 481: returnValue = false;
Line 482: }
Line 483: }
--
To view, visit http://gerrit.ovirt.org/8078
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2edb7b8c946589f3bbad251d533704fe856bc175
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
