Liron Aravot has posted comments on this change. Change subject: core: prevent simultaneous reconstructs on the same pool(#845838) ......................................................................
Patch Set 12: mkublin, Patch Set 12: there will be an attempt to acquire this lock anyway in MarkPoolInReconstruct command, regardless from where the reconstruct is initiated. so we will wait anyway - now instead of wait for the lock inside executeCommand method, we will wait for it in the canDoAction phase to check that another reconstruct is not running. if wait is required for user triggered reconstruct as well (recovery), it will be done for that use case instead as well of tryLock. regarding the bug, one reconstruct runs just fine. the problem occurs when we have race condition on the update vm ovf because of wrong data caused by two simultaneous reconstruct. if you think that the bug is in the reconstruct/recovery commands - please let me know why as when running not simultaneously there is no issue. thanks. -- To view, visit http://gerrit.ovirt.org/7982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0dfb227b014af602e5bd1ab952d7c543992aa0f Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Paikov <pai...@gmail.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
