Asaf Shakarchi has posted comments on this change.

Change subject: webadmin: Display the single status of domains in main tab.
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java
Line 81:         TextColumnWithTooltip<storage_domains> 
crossDataCenterStatusColumn =
Line 82:                 new TextColumnWithTooltip<storage_domains>() {
Line 83:                     @Override
Line 84:                     public String getValue(storage_domains object) {
Line 85:                         if 
(object.getstorage_domain_type().equals(StorageDomainType.ISO)) {
This is what we agreed on in the bug description,
We might get ride of the cross-dc status calculation, but for now, since it was 
meant for ISO domains only, we'll keep using it.
Line 86:                             return 
EnumTranslator.createAndTranslate(object.getstorage_domain_shared_status());
Line 87:                         } else {
Line 88:                             return 
EnumTranslator.createAndTranslate(object.getstatus());
Line 89:                         }


--
To view, visit http://gerrit.ovirt.org/8258
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If18c028dfcb985fd96f302b53401c1082a349416
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to