Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Changing mangage-domains permissions msg (#856581)
..
core: Changing mangage-domains permissions msg (#856581)
https://bugzilla.redhat.com/856581
Yair Zaslavsky has posted comments on this change.
Change subject: core: Changing mangage-domains permissions msg (#856581)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8062
To
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Refactor manage-domains permission handling (#856581)
..
core: Refactor manage-domains permission handling (#856581)
https://bugzilla.redhat.com/
Yair Zaslavsky has posted comments on this change.
Change subject: core: Refactor manage-domains permission handling (#856581)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8061
To unsubscribe, visit http:/
Yair Zaslavsky has posted comments on this change.
Change subject: core: [WIP] introducing SPMAsyncTaskHandler
..
Patch Set 2: (3 inline comments)
File
backend/manager/modul
Michael Pasternak has uploaded a new change for review.
Change subject: sdk: rebase to latest api
..
sdk: rebase to latest api
- To host added max_scheduling_memory property
Change-Id: Ibdbd5d4fd196f6084d8bc36505837c3058c53d0d
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: do not log /connect command in history
..
cli: do not log /connect command in history
Change-Id: Ieb983ecec4ae30fbae2411f0bf2eaef194e96f21
Sign
Michael Pasternak has posted comments on this change.
Change subject: cli: do not log /connect command in history
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8054
To unsubscrib
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: disable /history while not connected
..
cli: disable /history while not connected
Change-Id: I1bb7e7e2d631587bebc8dd27fef577a48dbe43d1
Signed
Michael Pasternak has posted comments on this change.
Change subject: cli: disable /history while not connected
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8053
To unsubscribe
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: enable --port option
..
cli: enable --port option
Change-Id: I19cd224deb7d1d080a7422d4193531eda79804eb
Signed-off-by: Michael Pasternak
---
M
Michael Pasternak has posted comments on this change.
Change subject: cli: enable --port option
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8052
To unsubscribe, visit http://ge
Oved Ourfali has posted comments on this change.
Change subject: cli: enable --port option
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8052
To unsubscribe, visit htt
Oved Ourfali has posted comments on this change.
Change subject: cli: disable /history while not connected
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8053
To unsub
Oved Ourfali has posted comments on this change.
Change subject: cli: do not log /connect command in history
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8054
To unsu
Michael Pasternak has uploaded a new change for review.
Change subject: release 3.2.0.2-1
..
release 3.2.0.2-1
Change-Id: If3c9d384590170f29a3f437623d5737e13fe0158
Signed-off-by: Michael Pasternak
---
M Makefile
M ovirt-engine-
Oved Ourfali has posted comments on this change.
Change subject: core: Changing mangage-domains permissions msg (#856581)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8062
To unsubscribe,
Yair Zaslavsky has posted comments on this change.
Change subject: core: Changing mangage-domains permissions msg (#856581)
..
Patch Set 2:
Followed Oved's comments.
--
To view, visit http://gerrit.ovirt.org/8062
To unsubscrib
Sharad Mishra has posted comments on this change.
Change subject: core: Cleanup method names II
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8073
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ger
Federico Simoncelli has uploaded a new change for review.
Change subject: Log stacktraces for failed VDSCommandBase calls
..
Log stacktraces for failed VDSCommandBase calls
Signed-off-by: Federico Simoncelli
Change-Id: I8329579
Sharad Mishra has posted comments on this change.
Change subject: core: Cleaup method names
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8071
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-
Ayal Baron has posted comments on this change.
Change subject: core: Change auto-recovery code for storage domains
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
.
Vered Volansky has posted comments on this change.
Change subject: core: [WIP] introducing SPMAsyncTaskHandler
..
Patch Set 2: Looks good to me, but someone else must approve
Looks fine java-wise, don't know enough system-wise.
Daniel Erez has posted comments on this change.
Change subject: webadmin: alert count notation is a prefix instead of a number
(#854166)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7943
Daniel Erez has posted comments on this change.
Change subject: webadmin: Fix actual snapshot disk size in storage tab (#847812)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8063
To unsub
Yair Zaslavsky has posted comments on this change.
Change subject: core: Upgrade status domain
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8014
To unsubscribe, visit http://gerrit.ovirt.
Sharad Mishra has posted comments on this change.
Change subject: core: cleanup method names to start with lower case.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8067
To unsubscribe, visit http://gerrit.
Sharad Mishra has uploaded a new change for review.
Change subject: core: cleanup method names to start with lower case.
..
core: cleanup method names to start with lower case.
Method names in java should start with lower case l
Michael Pasternak has posted comments on this change.
Change subject: cli: add username/password prompt/command-line functionality
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: add username/password prompt/command-line functionality
..
cli: add username/password prompt/command-line functionality
- removed --password op
Tal Nisan has uploaded a new change for review.
Change subject: webadmin: Fix actual snapshot disk size in storage tab (#847812)
..
webadmin: Fix actual snapshot disk size in storage tab (#847812)
The actual size column in stora
Doron Fediuck has posted comments on this change.
Change subject: engine: Allow empty quota in audit mode (#855633)
..
Patch Set 1:
Since this will enable working with missing quota definitions,
please verify (with Ofri) releva
Michael Kublin has posted comments on this change.
Change subject: core: Change auto-recovery code for storage domains
..
Patch Set 2: Verified
was decided to left auto-recovery for domains, but replace it to
connectCommand, t
Oved Ourfali has posted comments on this change.
Change subject: core: Changing mangage-domains permissions msg (#856581)
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
.
Oved Ourfali has posted comments on this change.
Change subject: core: Refactor manage-domains permission handling (#856581)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8061
To unsubscri
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Changing mangage-domains permissions msg (#856581)
..
core: Changing mangage-domains permissions msg (#856581)
https://bugzilla.redhat.com/856581
Changi
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Refactor manage-domains permission handling (#856581)
..
core: Refactor manage-domains permission handling (#856581)
https://bugzilla.redhat.com/856581
Gilad Chaplik has uploaded a new change for review.
Change subject: engine: Allow empty quota in audit mode (#855633)
..
engine: Allow empty quota in audit mode (#855633)
https://bugzilla.redhat.com/855633
this is a known issue
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: import: validate quota in enforce mode (#855635)
..
webadmin: import: validate quota in enforce mode (#855635)
https://bugzilla.redhat.com/855635
Imp
Keith Robertson has posted comments on this change.
Change subject: cli: add username/password prompt/command-line functionality
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ov
Doron Fediuck has posted comments on this change.
Change subject: core: OvfVmWriterTest
..
Patch Set 3: Looks good to me, approved
Please verify & submit.
--
To view, visit http://gerrit.ovirt.org/4817
To unsubscribe, visit ht
Daniel Paikov has posted comments on this change.
Change subject: core: ReconstructMasterDomain - refresh storage pool before
connect(#841525)
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/7137
To unsubscr
Eli Mesika has uploaded a new change for review.
Change subject: core: Template stuck in Locked status ...(#846324)
..
core: Template stuck in Locked status ...(#846324)
core: Template stuck in Locked status after restart of VDS
Allon Mureinik has posted comments on this change.
Change subject: Fix setParentParameters name typos
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8024
To unsubscribe
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Increase Apache AJP timeout (#845832)
..
packaging: Increase Apache AJP timeout (#845832)
https://bugzilla.redhat.com/845832
The default ti
Juan Hernandez has posted comments on this change.
Change subject: packaging: Increase Apache AJP timeout (#845832)
..
Patch Set 5: Verified; Looks good to me, approved
Merging based on previous acks and verification.
--
To vi
Liron Aravot has posted comments on this change.
Change subject: core: add locks to VmTemplate commands (#761515)
..
Patch Set 5: (1 inline comment)
all comments were answered on patch set 3
...
Michael Kublin has posted comments on this change.
Change subject: core: add locks to VmTemplate commands (#761515)
..
Patch Set 5: (1 inline comment)
Additional comment at patch set 5
.
Michael Pasternak has posted comments on this change.
Change subject: packaging: Increase Apache AJP timeout (#845832)
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7933
To unsubscribe, vi
Allon Mureinik has posted comments on this change.
Change subject: core: Removing auto-recovery code for storage domains
..
Patch Set 1: Looks good to me, but someone else must approve
(2 inline comments)
.
Michael Kublin has posted comments on this change.
Change subject: core: Removind uses deactivate from error flows at engine side
..
Patch Set 5: (4 inline comments)
File
ba
Allon Mureinik has posted comments on this change.
Change subject: core: Upgrade status domain
..
Patch Set 1: Looks good to me, but someone else must approve
(4 inline comments)
see suggestions for the commit message inline.
Allon Mureinik has posted comments on this change.
Change subject: core: Removind uses deactivate from error flows at engine side
..
Patch Set 5: (4 inline comments)
basically +1, see minor issues inline.
Also, I'd separate al
Michael Pasternak has uploaded a new change for review.
Change subject: cli: do not log /connect command in history
..
cli: do not log /connect command in history
Change-Id: Ieb983ecec4ae30fbae2411f0bf2eaef194e96f21
Signed-off-b
Alon Bar-Lev has posted comments on this change.
Change subject: engine: Unifying (parts of) engine and vdsm commit templates
..
Patch Set 1:
Well, taking this.
Does anyone *REJECTS* Bug-Url?
Answers will accepted gladly for
Michael Kublin has posted comments on this change.
Change subject: core: add locks to VmTemplate commands (#761515)
..
Patch Set 5: I would prefer that you didn't submit this
Patch set 3, because of no changes at latest patch s
Michael Kublin has posted comments on this change.
Change subject: core: add locks to VmTemplate commands (#761515)
..
Patch Set 3: (6 inline comments)
File
backend/manager/
Daniel Erez has submitted this change and it was merged.
Change subject: core: AddStoragePool - enable forceCompensation (#817339)
..
core: AddStoragePool - enable forceCompensation (#817339)
https://bugzilla.redhat.com/817339
Daniel Erez has posted comments on this change.
Change subject: core: AddStoragePool - enable forceCompensation (#817339)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8042
To un
Michael Kublin has posted comments on this change.
Change subject: core: Upgrade status domain
..
Patch Set 1: (1 inline comment)
Commit Message
Line 9: Because of change in
Michael Pasternak has uploaded a new change for review.
Change subject: cli: enable --port option
..
cli: enable --port option
Change-Id: I19cd224deb7d1d080a7422d4193531eda79804eb
Signed-off-by: Michael Pasternak
---
M src/ovir
Michael Pasternak has uploaded a new change for review.
Change subject: cli: disable /history while not connected
..
cli: disable /history while not connected
Change-Id: I1bb7e7e2d631587bebc8dd27fef577a48dbe43d1
Signed-off-by:
Eli Mesika has submitted this change and it was merged.
Change subject: core: check host time-drift in getVdsStat(#848862)
..
core: check host time-drift in getVdsStat(#848862)
Change-Id: Ie1f38149c0a7fb1d6e1627e86b1a3c231352e1
Eli Mesika has posted comments on this change.
Change subject: core: check host time-drift in getVdsStat(#848862)
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7830
To unsubscrib
Eli Mesika has submitted this change and it was merged.
Change subject: core: adding values to engine-config(#848862)
..
core: adding values to engine-config(#848862)
Adding new configuration values to engine-config
Change-Id:
Eli Mesika has posted comments on this change.
Change subject: core: adding values to engine-config(#848862)
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7829
To unsubscribe, vi
Eli Mesika has submitted this change and it was merged.
Change subject: core: adding host time-drift notification(#848862)
..
core: adding host time-drift notification(#848862)
Adding support for event notification
Change-Id:
Eli Mesika has posted comments on this change.
Change subject: core: adding host time-drift notification(#848862)
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7828
To unsubscrib
Eli Mesika has submitted this change and it was merged.
Change subject: core: adding host time-drift alert(#848862)
..
core: adding host time-drift alert(#848862)
Adding the new VDS_TIME_DRIFT_ALERT event
Change-Id: I3d2f23a7e
Eli Mesika has posted comments on this change.
Change subject: core: adding host time-drift alert(#848862)
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7827
To unsubscribe, visi
Eli Mesika has submitted this change and it was merged.
Change subject: core: Report event on time drift ...(#848862)
..
core: Report event on time drift ...(#848862)
Report event on time drift between engine and vdsm(#848862)
Eli Mesika has posted comments on this change.
Change subject: core: Report event on time drift ...(#848862)
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7826
To unsubscribe, vi
Michael Kublin has posted comments on this change.
Change subject: core: AddStoragePool - enable forceCompensation (#817339)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8042
To unsubscri
Allon Mureinik has posted comments on this change.
Change subject: Fix setParentParameters name typos
..
Patch Set 1: I would prefer that you didn't submit this
Like the idea, but please note the changes in http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: AddStoragePool - enable forceCompensation (#817339)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Yair Zaslavsky has posted comments on this change.
Change subject: core: Report event on time drift ...(#848862)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7826
To unsubscribe, visit ht
Yair Zaslavsky has posted comments on this change.
Change subject: core: adding host time-drift alert(#848862)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7827
To unsubscribe, visit http
Yair Zaslavsky has posted comments on this change.
Change subject: core: adding host time-drift notification(#848862)
..
Patch Set 3: Looks good to me, approved
Followed the comments of Derez
--
To view, visit http://gerrit.ov
Yair Zaslavsky has posted comments on this change.
Change subject: core: adding values to engine-config(#848862)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7829
To unsubscribe, visit ht
Yair Zaslavsky has posted comments on this change.
Change subject: core: check host time-drift in getVdsStat(#848862)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7830
To unsubscribe, vis
Eli Mesika has submitted this change and it was merged.
Change subject: core: audig_log table is not cleaned ...(#856009)
..
core: audig_log table is not cleaned ...(#856009)
core audig_log table is not cleaned properly, causin
Eli Mesika has posted comments on this change.
Change subject: core: audig_log table is not cleaned ...(#856009)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8016
To unsubscribe
Yair Zaslavsky has posted comments on this change.
Change subject: core: AddStoragePool - enable forceCompensation (#817339)
..
Patch Set 1:
Looks good.
Allon/Maor/Ayal - please approve as well.
--
To view, visit http://gerrit
Yair Zaslavsky has posted comments on this change.
Change subject: core: AddStoragePool - enable forceCompensation (#817339)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Eli Mesika has posted comments on this change.
Change subject: core: adding host time-drift notification(#848862)
..
Patch Set 2: (1 inline comment)
File
frontend/webadmin/m
Kanagaraj M has posted comments on this change.
Change subject: webadmin: hiding DC in Host tab - GlusterOnly mode
..
Patch Set 2: Verified
Rebased and Verified.
--
To view, visit http://gerrit.ovirt.org/8001
To unsubscribe, v
Oved Ourfali has submitted this change and it was merged.
Change subject: core: fix power user roles and GetAllVmPoolsAttachedToUser query
..
core: fix power user roles and GetAllVmPoolsAttachedToUser query
Assigning user roles
Oved Ourfali has posted comments on this change.
Change subject: core: fix power user roles and GetAllVmPoolsAttachedToUser query
..
Patch Set 2: Verified; Looks good to me, approved
Rebased.
Submitting based on previous ACK.
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Incorrect syntax for String.format
..
core: Incorrect syntax for String.format
Changed from '%s%s' to '%2$s'
Change-Id: I18a62074802f87957e57bb
Yair Zaslavsky has posted comments on this change.
Change subject: core: Incorrect syntax for String.format
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7852
To unsubscribe, vis
Yair Zaslavsky has posted comments on this change.
Change subject: core: fix power user roles and GetAllVmPoolsAttachedToUser query
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7985
To un
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Using constant instead of literal DB name.
..
Patch Set 1: Looks good to me, but someone else must approve
I guess one more unneeded difference between
Daniel Erez has posted comments on this change.
Change subject: core: AddStoragePool - enable forceCompensation (#817339)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8042
To unsubscribe, visit http://gerr
Daniel Erez has submitted this change and it was merged.
Change subject: core: Fix RemoveVmTemplate regression
..
core: Fix RemoveVmTemplate regression
Refactoring task creation broke removing a VM template, since the
RemoveVmT
Daniel Erez has posted comments on this change.
Change subject: core: Fix RemoveVmTemplate regression
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8049
To unsubscribe, visit http://gerrit
Eli Mesika has posted comments on this change.
Change subject: core: Upgrade status domain
..
Patch Set 1: (1 inline comment)
Commit Message
Line 9: Because of change in beha
Allon Mureinik has posted comments on this change.
Change subject: core: Fix RemoveVmTemplate regression
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8049
To unsubscribe, visit http://gerrit.ovirt.org/sett
Allon Mureinik has uploaded a new change for review.
Change subject: core: Fix RemoveVmTemplate regression
..
core: Fix RemoveVmTemplate regression
Refactoring task creation broke removing a VM template, since the
RemoveVmTempla
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Using constant instead of literal DB name.
..
packaging: Using constant instead of literal DB name.
Change-Id: I922a57ff0d5c99188362a8a0c6a63702ab37b73
Daniel Erez has posted comments on this change.
Change subject: core: adding host time-drift notification(#848862)
..
Patch Set 2: (1 inline comment)
File
frontend/webadmin/
1 - 100 of 110 matches
Mail list logo
