Allon Mureinik has posted comments on this change. Change subject: core: Upgrade status domain ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (4 inline comments) see suggestions for the commit message inline. .................................................... Commit Message Line 5: CommitDate: 2012-09-16 10:47:05 +0300 Line 6: Line 7: core: Upgrade status domain Line 8: Line 9: Because of change in behaviour at error flows, all Suggestion: Perhaps add a reference to the patch that changed these error flows. Line 10: statuses of storage domains which were InActive should Line 11: be moved to Maintaince status. Line 12: The reason for these is because before a change InActive and Line 13: Maintaince status has similar behaviour at the system Line 6: Line 7: core: Upgrade status domain Line 8: Line 9: Because of change in behaviour at error flows, all Line 10: statuses of storage domains which were InActive should s/InActive/Inactive Line 11: be moved to Maintaince status. Line 12: The reason for these is because before a change InActive and Line 13: Maintaince status has similar behaviour at the system Line 14: Line 8: Line 9: Because of change in behaviour at error flows, all Line 10: statuses of storage domains which were InActive should Line 11: be moved to Maintaince status. Line 12: The reason for these is because before a change InActive and s/these/this s/a change/the change/ s/InActive/Inactive/ Line 13: Maintaince status has similar behaviour at the system Line 14: Line 15: Change-Id: Ibf2316023849648ecc8bee45061ccae0ded5e120 Line 9: Because of change in behaviour at error flows, all Line 10: statuses of storage domains which were InActive should Line 11: be moved to Maintaince status. Line 12: The reason for these is because before a change InActive and Line 13: Maintaince status has similar behaviour at the system s/at/in/ Line 14: Line 15: Change-Id: Ibf2316023849648ecc8bee45061ccae0ded5e120 -- To view, visit http://gerrit.ovirt.org/8014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2316023849648ecc8bee45061ccae0ded5e120 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
