Oved Ourfali has posted comments on this change.
Change subject: core: Changing mangage-domains permissions msg (#856581)
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java
Line 31: public static final String CONF_FILE_PATH =
"/etc/ovirt-engine/engine-manage-domains/engine-manage-domains.conf";
Line 32: private final String WARNING_ABOUT_TO_DELETE_LAST_DOMAIN =
Line 33: "WARNING: Domain %1$s is the last domain in the
configuration. After deleting it you will have to either add another domain, or
to use the internal admin user in order to login.";
Line 34: private final String INFO_ABOUT_NOT_ADDING_PERMISSIONS =
Line 35: "The domain %1$s has been added to the engine as an
authentication source but no users from that domain have been granted
permissions within the RHEV Manager.\nUsers from this domain can be granted
permissions from the Web administration interface.";
within the oVirt engine manager.
Line 36:
Line 37: private final String SERVICE_RESTART_MESSAGE =
Line 38: "oVirt Engine restart is required in order for the changes
to take place (service ovirt-engine restart).";
Line 39: private final String DELETE_DOMAIN_SUCCESS =
Line 464: if (addPermissions) {
Line 465:
System.out.println(String.format(SUCCESSFULLY_COMPLETED_ACTION_ON_DOMAIN,
"added", domainName));
Line 466: } else {
Line 467: System.out.println(SERVICE_RESTART_MESSAGE);
Line 468: }
addPermissions means you added a permission, but it doesn't mean that no
restart is needed... unless I'm missing something here.
Line 469: }
Line 470:
Line 471: private void handleAddPermissions(String
domainName,DomainsConfigurationEntry adUserNameEntry, DomainsConfigurationEntry
adUserIdEntry) {
Line 472: if (addPermissions) {
--
To view, visit http://gerrit.ovirt.org/8062
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I896a6514b4e63706c49b8a0d5121caff31644304
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
