Sharad Mishra has uploaded a new change for review.
Change subject: core: cleanup method names to start with lower case.
......................................................................
core: cleanup method names to start with lower case.
Method names in java should start with lower case letter.
Change-Id: I294c26dc7f182c8addfe4e91b0420233c6c82632
Signed-off-by: Sharad Mishra <snmis...@linux.vnet.ibm.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
4 files changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/67/8067/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
index c3f9f12..36d1def 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
@@ -203,7 +203,7 @@
return getBlockSparseInitSizeInGB() *
storageToDisksMap.get(domainId).size();
}
- protected boolean CanDoAddVmCommand() {
+ protected boolean canDoAddVmCommand() {
boolean returnValue = false;
returnValue =
areParametersLegal(getReturnValue().getCanDoActionMessages());
// Check if number of monitors passed is legal
@@ -291,7 +291,7 @@
storageToDisksMap =
ImagesHandler.buildStorageToDiskMap(getImagesToCheckDestinationStorageDomains(),
diskInfoDestinationMap);
- returnValue = CanDoAddVmCommand();
+ returnValue = canDoAddVmCommand();
}
String vmName = getParameters().getVm().getvm_name();
@@ -482,10 +482,10 @@
@Override
public Void runInTransaction() {
- AddVmStatic();
+ addVmStatic();
addVmDynamic();
- AddVmNetwork();
- AddVmStatistics();
+ addVmNetwork();
+ addVmStatistics();
addActiveSnapshot();
getCompensationContext().stateChanged();
return null;
@@ -494,7 +494,7 @@
freeLock();
addVmPermission();
- if (AddVmImages()) {
+ if (addVmImages()) {
copyVmDevices();
addDiskPermissions(newDiskImages);
addVmPayload();
@@ -566,7 +566,7 @@
return returnValue;
}
- protected void AddVmNetwork() {
+ protected void addVmNetwork() {
// Add interfaces from template
for (VmNetworkInterface iface : getVmInterfaces()) {
iface.setId(Guid.NewGuid());
@@ -581,7 +581,7 @@
}
}
- protected void AddVmStatic() {
+ protected void addVmStatic() {
VmStatic vmStatic = getParameters().getVmStaticData();
if (vmStatic.getorigin() == null) {
vmStatic.setorigin(OriginType.valueOf(Config.<String>
GetValue(ConfigValues.OriginType)));
@@ -618,14 +618,14 @@
getCompensationContext().snapshotNewEntity(vmDynamic);
}
- void AddVmStatistics() {
+ void addVmStatistics() {
VmStatistics stats = new VmStatistics();
stats.setId(getVmId());
DbFacade.getInstance().getVmStatisticsDAO().save(stats);
getCompensationContext().snapshotNewEntity(stats);
}
- protected boolean AddVmImages() {
+ protected boolean addVmImages() {
if (getVmTemplate().getDiskMap().size() > 0) {
if (getVm().getstatus() != VMStatus.Down) {
log.error("Cannot add images. VM is not Down");
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java
index d0ce294..3ec2e35 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java
@@ -60,7 +60,7 @@
}
@Override
- protected boolean AddVmImages() {
+ protected boolean addVmImages() {
List<Disk> disks = DbFacade.getInstance().getDiskDao().getAllForVm(
getParameters().getVmStaticData().getvmt_guid());
if (disks.isEmpty() &&
!getParameters().getVmStaticData().getvmt_guid().equals(Guid.Empty)) {
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
index eede0e1..6580c97 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
@@ -106,7 +106,7 @@
}
@Override
- protected boolean AddVmImages() {
+ protected boolean addVmImages() {
int numberOfStartedCopyTasks = 0;
try {
if (!getDiskImagesFromConfiguration().isEmpty()) {
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
index 210459c..5ca9455 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
@@ -48,7 +48,7 @@
}
@Override
- protected boolean AddVmImages() {
+ protected boolean addVmImages() {
if (getVmTemplate().getDiskMap().size() > 0) {
if (getVm().getstatus() != VMStatus.Down) {
log.error("Cannot add images. VM is not Down");
--
To view, visit http://gerrit.ovirt.org/8067
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I294c26dc7f182c8addfe4e91b0420233c6c82632
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
