Eli Mesika has uploaded a new change for review. Change subject: core: Template stuck in Locked status ...(#846324) ......................................................................
core: Template stuck in Locked status ...(#846324) core: Template stuck in Locked status after restart of VDSM during template import(#846324) https://bugzilla.redhat.com/846324 Problem was that stop task command was sent to VDSM even if the status of the task is unknown or aborting causing VDSM to stop the task without cleaning and leave garbage behind. The patch adds a condition to SPMAsyncTask:stopTask that checks if the task is not in unknown or aborting state before attempting to send a StopTask command. Change-Id: I75947f44448ce07f36e295a520e373ad6e7546fe Signed-off-by: Eli Mesika <emes...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/57/8057/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java index f95736b..adca4eb 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java @@ -443,7 +443,7 @@ public void StopTask() { if (getState() != AsyncTaskState.AttemptingEndAction && getState() != AsyncTaskState.Cleared - && getState() != AsyncTaskState.ClearFailed) { + && getState() != AsyncTaskState.ClearFailed && !getLastTaskStatus().getTaskIsInUnusualState()) { try { log.infoFormat( "SPMAsyncTask::StopTask: Attempting to stop task '{0}' (Parent Command {1}, Parameters Type {2}).", -- To view, visit http://gerrit.ovirt.org/8057 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I75947f44448ce07f36e295a520e373ad6e7546fe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
