Yair Zaslavsky has posted comments on this change.
Change subject: core: [WIP] introducing SPMAsyncTaskHandler
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CompleteCommandSPMAsyncTaskHandler.java
Line 17: }
Line 18:
Line 19: @Override
Line 20: public SPMAsyncTask createTask() {
Line 21: // Intentionally not implemented - for backwards
compatibility, the task is created in cmd's Execute()
Why not throwing NotImplementedException?
Line 22: return null;
Line 23: }
Line 24:
Line 25: @Override
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTaskHandler.java
Line 24: /** A callback for the task fails to complete */
Line 25: public void endWithFailure();
Line 26:
Line 27: /** A callback for undoing the work of a task that has previously
succeeded */
Line 28: public void compensate();
Maybe name this revertTask?
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java
Line 52: private long taskStartTime;
Line 53:
Line 54: private ArrayList<Guid> taskIds;
Line 55:
Line 56: int executionIndex = 0;
Any reason for it being a "package" and not private or protected?
Line 57:
Line 58: /**
Line 59: * A cross system identifier of the executed action
Line 60: */
--
To view, visit http://gerrit.ovirt.org/7956
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f2d113ced0276a9d849b7f00c7757e003d35f4c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
