Oved Ourfali has submitted this change and it was merged. Change subject: core: fix power user roles and GetAllVmPoolsAttachedToUser query ......................................................................
core: fix power user roles and GetAllVmPoolsAttachedToUser query Assigning user roles to System/DC/Cluster can cause weird behavior, as user will be able to see all VMs under these objects, but when looking at VM pools he won't be able to operate them. In this patch we do the following: 1. Make PowerUser role contain the following action groups (and changes the description accordingly): * login * create disk * create VM * create template 2. Mark it as "allow_viewing_children = false". 3. Fix the get pools query, to get the filtered pools from the correct view. Change-Id: I9acba40db76fbd5e8ffbeb1d615d4675b6903ccb Signed-off-by: Oved Ourfali <oourf...@redhat.com> --- M backend/manager/dbscripts/bookmarks_sp.sql A backend/manager/dbscripts/upgrade/03_01_1390_update_power_user_role.sql 2 files changed, 14 insertions(+), 9 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7985 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9acba40db76fbd5e8ffbeb1d615d4675b6903ccb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches