Yair Zaslavsky has uploaded a new change for review. Change subject: core: Refactor manage-domains permission handling (#856581) ......................................................................
core: Refactor manage-domains permission handling (#856581) https://bugzilla.redhat.com/856581 As part of fixing this bug, a method for handling the permission is extracted, in order to provide code reuse for add and edit actions Change-Id: I7636e84ffc66ae6fda3d3bc5f5c48d9e1449da6f Signed-off-by: Yair Zaslavsky <yzasl...@redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java 1 file changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/61/8061/1 diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java index bc84fe8..8703fe8 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java @@ -447,11 +447,7 @@ true, false); - if (addPermissions) { - updatePermissionsTable(adUserNameEntry, adUserIdEntry); - } else { - System.out.println(WARNING_NOT_ADDING_PERMISSIONS); - } + handleAddPermissions(adUserNameEntry, adUserIdEntry); // Update the configuration setConfigurationEntries(domainNameEntry, @@ -463,6 +459,14 @@ ldapProviderTypesEntry); System.out.println(String.format(SUCCESSFULLY_COMPLETED_ACTION_ON_DOMAIN, "added", domainName)); + } + + private void handleAddPermissions(DomainsConfigurationEntry adUserNameEntry, DomainsConfigurationEntry adUserIdEntry) { + if (addPermissions) { + updatePermissionsTable(adUserNameEntry, adUserIdEntry); + } else { + System.out.println(WARNING_NOT_ADDING_PERMISSIONS); + } } private ManageDomainsResult updatePermissionsTable(DomainsConfigurationEntry adUserNameEntry, @@ -560,11 +564,7 @@ true, false); - if (addPermissions) { - updatePermissionsTable(adUserNameEntry, adUserIdEntry); - } else { - System.out.println(WARNING_NOT_ADDING_PERMISSIONS); - } + handleAddPermissions(adUserNameEntry, adUserIdEntry); setConfigurationEntries(domainNameEntry, adUserNameEntry, -- To view, visit http://gerrit.ovirt.org/8061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7636e84ffc66ae6fda3d3bc5f5c48d9e1449da6f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
