[Engine-patches] Change in ovirt-log-collector[master]: tools: Make system and REST API rebase for log collector

Keith Robertson has posted comments on this change. Change subject: tools: Make system and REST API rebase for log collector .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/3212 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-log-collector[master]: tools: Make system and REST API rebase for log collector

Keith Robertson has uploaded a new change for review. Change subject: tools: Make system and REST API rebase for log collector .. tools: Make system and REST API rebase for log collector This commit does the following: - Proper

[Engine-patches] Jenkins build is back to normal : ovirt_engine_create_rpms #150

See ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 492 - Fixed!

ovirt_engine_unit_tests - Build # 492 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/492/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinf

[Engine-patches] Change in ovirt-engine[master]: webadmin: Control refresh behavior (#802378)

Gilad Chaplik has posted comments on this change. Change subject: webadmin: Control refresh behavior (#802378) .. Patch Set 1: I wonder if the user will ever leave it un-checked :) -- To view, visit http://gerrit.ovirt.org/319

[Engine-patches] Change in ovirt-engine[master]: webadmin: Control refresh behavior (#802378)

Gilad Chaplik has posted comments on this change. Change subject: webadmin: Control refresh behavior (#802378) .. Patch Set 1: this is the first time I see such a check-box :) -- To view, visit http://gerrit.ovirt.org/3197 To

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 491 - Unstable!

ovirt_engine_unit_tests - Build # 491 - Unstable: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/491/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/list

[Engine-patches] Build failed in Jenkins: ovirt_engine_create_rpms #149

See -- [...truncated 1931 lines...] [INFO] [compiler:testCompile {execution: default-testCompile}] [INFO] No sources to compile [INFO] [surefire:test {execution: default-test}] [INFO] Tests are ski

[Engine-patches] Change in ovirt-engine[master]: webadmin: gluster - set title for volume sub tabs

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: gluster - set title for volume sub tabs .. webadmin: gluster - set title for volume sub tabs Change-Id: I020252aa654435749bdde9d685803374ec3b1

[Engine-patches] Change in ovirt-engine[master]: webadmin: gluster - set title for volume sub tabs

Gilad Chaplik has posted comments on this change. Change subject: webadmin: gluster - set title for volume sub tabs .. Patch Set 5: Verified; Looks good to me, approved rebased and verified -- To view, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: core: gluster- avoid using final for members for BE

Gilad Chaplik has submitted this change and it was merged. Change subject: core: gluster- avoid using final for members for BE .. core: gluster- avoid using final for members for BE the GWT convertion skips this in the conversi

[Engine-patches] Change in ovirt-engine[master]: core: gluster- avoid using final for members for BE

Gilad Chaplik has posted comments on this change. Change subject: core: gluster- avoid using final for members for BE .. Patch Set 5: Verified; Looks good to me, approved rebased and verified -- To view, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: webadmin: gluster - support volume search

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: gluster - support volume search .. webadmin: gluster - support volume search Change-Id: If7b64a9121516afcc8f34d84852d8336901cfbd9 --- M front

[Engine-patches] Change in ovirt-engine[master]: webadmin: gluster - support volume search

Gilad Chaplik has posted comments on this change. Change subject: webadmin: gluster - support volume search .. Patch Set 5: Verified; Looks good to me, approved rebased and verified -- To view, visit http://gerrit.ovirt.org/31

[Engine-patches] Change in ovirt-engine[master]: webadmin: gluster - error in search jump to wrong tab

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: gluster - error in search jump to wrong tab .. webadmin: gluster - error in search jump to wrong tab Change-Id: I464c5c5726720b26cd9e741efd0c0

[Engine-patches] Change in ovirt-engine[master]: webadmin: gluster - error in search jump to wrong tab

Gilad Chaplik has posted comments on this change. Change subject: webadmin: gluster - error in search jump to wrong tab .. Patch Set 5: Verified; Looks good to me, approved rebased and verified -- To view, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: webadmin: gluster - further commands and general tab form

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: gluster - further commands and general tab form .. webadmin: gluster - further commands and general tab form commands: start, stop and rebalan

[Engine-patches] Change in ovirt-engine[master]: webadmin: gluster - further commands and general tab form

Gilad Chaplik has posted comments on this change. Change subject: webadmin: gluster - further commands and general tab form .. Patch Set 5: Verified; Looks good to me, approved rebased and verified -- To view, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: webadmin: volume tab and sub tab grids

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: volume tab and sub tab grids .. webadmin: volume tab and sub tab grids Change-Id: I6a0142e7adaaccb9c65766f8ec5c3dc5b28eb108 --- M frontend/we

[Engine-patches] Change in ovirt-engine[master]: webadmin: volume tab and sub tab grids

Gilad Chaplik has posted comments on this change. Change subject: webadmin: volume tab and sub tab grids .. Patch Set 5: Verified; Looks good to me, approved rebased and verified -- To view, visit http://gerrit.ovirt.org/3131

[Engine-patches] Change in ovirt-engine[master]: webadmin: adding commented out gluster roles

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: adding commented out gluster roles .. webadmin: adding commented out gluster roles Change-Id: Ica311641a4ba72d849a2e4b52627db246bd251ae --- M

[Engine-patches] Change in ovirt-engine[master]: webadmin: adding commented out gluster roles

Gilad Chaplik has posted comments on this change. Change subject: webadmin: adding commented out gluster roles .. Patch Set 5: Verified; Looks good to me, approved rebased and verified -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: webadmin: gluster - calling list of volumes

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: gluster - calling list of volumes .. webadmin: gluster - calling list of volumes Change-Id: Iff64d1d84a7c1b63342d34c98cc31dd4f1c24fc5 --- M f

[Engine-patches] Change in ovirt-engine[master]: webadmin: gluster - calling list of volumes

Gilad Chaplik has posted comments on this change. Change subject: webadmin: gluster - calling list of volumes .. Patch Set 5: Verified; Looks good to me, approved rebased and verified -- To view, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: webadmin: gluster- fix model provider bug

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: gluster- fix model provider bug .. webadmin: gluster- fix model provider bug the VM model provider was used instead of volume model provider.

[Engine-patches] Change in ovirt-engine[master]: webadmin: gluster- fix model provider bug

Gilad Chaplik has posted comments on this change. Change subject: webadmin: gluster- fix model provider bug .. Patch Set 5: Verified; Looks good to me, approved rebased and verified -- To view, visit http://gerrit.ovirt.org/31

[Engine-patches] Change in ovirt-engine[master]: webadmin: gluster - add create volume command

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: gluster - add create volume command .. webadmin: gluster - add create volume command also in this patch: adding dataCenter & cluster, tree tab

[Engine-patches] Change in ovirt-engine[master]: webadmin: gluster - add create volume command

Gilad Chaplik has posted comments on this change. Change subject: webadmin: gluster - add create volume command .. Patch Set 5: Verified; Looks good to me, approved rebased and verified -- To view, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adding Volumes sub tabs and new Volume dialog

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Adding Volumes sub tabs and new Volume dialog .. webadmin: Adding Volumes sub tabs and new Volume dialog Change-Id: If4e2885187c7c050c27b5821f

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adding Volumes sub tabs and new Volume dialog

Gilad Chaplik has posted comments on this change. Change subject: webadmin: Adding Volumes sub tabs and new Volume dialog .. Patch Set 5: Verified; Looks good to me, approved rebased and verified -- To view, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: webadmin: Volume Main Tab

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Volume Main Tab .. webadmin: Volume Main Tab adding the infrastructure to Volume main tab in webadmin, currently there will not be any backend

[Engine-patches] Change in ovirt-engine[master]: webadmin: Volume Main Tab

Gilad Chaplik has posted comments on this change. Change subject: webadmin: Volume Main Tab .. Patch Set 5: Verified; Looks good to me, approved rebased and verified -- To view, visit http://gerrit.ovirt.org/3125 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: webadmin: adding client configuration for gluster

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: adding client configuration for gluster .. webadmin: adding client configuration for gluster Adding an enum field to client configuration that

[Engine-patches] Change in ovirt-engine[master]: webadmin: adding client configuration for gluster

Gilad Chaplik has posted comments on this change. Change subject: webadmin: adding client configuration for gluster .. Patch Set 5: Verified; Looks good to me, approved rebased and verified -- To view, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: webadmin: adding gluster entities as 'shared files'

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: adding gluster entities as 'shared files' .. webadmin: adding gluster entities as 'shared files' In order that gluster BE will be compiled wit

[Engine-patches] Change in ovirt-engine[master]: webadmin: adding gluster entities as 'shared files'

Gilad Chaplik has posted comments on this change. Change subject: webadmin: adding gluster entities as 'shared files' .. Patch Set 5: Verified; Looks good to me, approved rebased and verified -- To view, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: webadmin: Update Firefox supported version

Gilad Chaplik has posted comments on this change. Change subject: webadmin: Update Firefox supported version .. Patch Set 2: I suggest to remove it, IMHO the login message is more than enough, maybe adding it in an 'About' sec

[Engine-patches] Change in ovirt-engine[master]: webadmin: Update Firefox supported version

Daniel Erez has posted comments on this change. Change subject: webadmin: Update Firefox supported version .. Patch Set 2: We should support IE 9.0 and up (though I seldom use it). I guess Chrome should be considered as well.

[Engine-patches] Change in ovirt-engine[master]: webadmin: Update Firefox supported version

Gilad Chaplik has posted comments on this change. Change subject: webadmin: Update Firefox supported version .. Patch Set 2: Daniel should answer the IE question, he's the only guy who use it. what about the footer?? -- To vi

[Engine-patches] Change in ovirt-engine[master]: core: allow synchronous multiple actions

Danny Rankevich has uploaded a new change for review. Change subject: core: allow synchronous multiple actions .. core: allow synchronous multiple actions * Add a flag to Execute() indicating sync execution * In case of a sync e

[Engine-patches] Change in ovirt-engine[master]: webadmin: manage cluster networks dialog

Danny Rankevich has uploaded a new change for review. Change subject: webadmin: manage cluster networks dialog .. webadmin: manage cluster networks dialog on going... Change-Id: I617a73105dcadd6733b4a854ebdece47b066d367 --- M

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 489 - Fixed!

ovirt_engine_unit_tests - Build # 489 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/489/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinf

[Engine-patches] Jenkins build is back to normal : ovirt_engine_create_rpms #147

See ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 488 - Failure!

ovirt_engine_unit_tests - Build # 488 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/488/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listi

[Engine-patches] Build failed in Jenkins: ovirt_engine_create_rpms #146

See -- [...truncated 1904 lines...] [INFO] Building war:

[Engine-patches] Change in ovirt-engine[master]: core: Fix findbugs high warning

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix findbugs high warning .. core: Fix findbugs high warning The patch fix findbugs warning of self comparison. Change-Id: Ic0cb9f465f2c7e3367a1cf

[Engine-patches] Change in ovirt-engine[master]: core: Fix findbugs high warning

Maor Lipchuk has posted comments on this change. Change subject: core: Fix findbugs high warning .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3208 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: Revert "core: Add grant_mode attribute to permissions entity...

Moti Asayag has submitted this change and it was merged. Change subject: Revert "core: Add grant_mode attribute to permissions entity" .. Revert "core: Add grant_mode attribute to permissions entity" The grant_mode column is de

[Engine-patches] Change in ovirt-engine[master]: Revert "core: rename DB Script"

Moti Asayag has submitted this change and it was merged. Change subject: Revert "core: rename DB Script" .. Revert "core: rename DB Script" A patch to remove the grant_mode add column db script. This reverts commit a905a54da3c

[Engine-patches] Change in ovirt-engine[master]: Revert "core: rename DB Script"

Moti Asayag has posted comments on this change. Change subject: Revert "core: rename DB Script" .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3190 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: Revert "core: Add grant_mode attribute to permissions entity...

Moti Asayag has posted comments on this change. Change subject: Revert "core: Add grant_mode attribute to permissions entity" .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3191 T

[Engine-patches] Change in ovirt-engine[master]: core: Fix findbugs high warning

Moti Asayag has uploaded a new change for review. Change subject: core: Fix findbugs high warning .. core: Fix findbugs high warning The patch fix findbugs warning of self comparison. Change-Id: Ic0cb9f465f2c7e3367a1cf497571034

[Engine-patches] Change in ovirt-engine[master]: Revert "core: Add grant_mode attribute to permissions entity...

Omer Frenkel has posted comments on this change. Change subject: Revert "core: Add grant_mode attribute to permissions entity" .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3191 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: Revert "core: rename DB Script"

Omer Frenkel has posted comments on this change. Change subject: Revert "core: rename DB Script" .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3190 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: REST: add plug/unplug actions to vm nic

Roy Golan has uploaded a new change for review. Change subject: REST: add plug/unplug actions to vm nic .. REST: add plug/unplug actions to vm nic Change-Id: Ie38f648bf2a13e2e8b2e9a1283a40f27bcb34425 --- M backend/manager/modul

[Engine-patches] Change in ovirt-engine[master]: engine-core: add plug/unplug VM nic command

Roy Golan has uploaded a new change for review. Change subject: engine-core: add plug/unplug VM nic command .. engine-core: add plug/unplug VM nic command Change-Id: I17897c18eccae41954e01b264fa74427e0bce1a2 --- A backend/manag

[Engine-patches] Change in ovirt-engine[master]: engine-core: RunVm - filter out unplugged nics

Roy Golan has uploaded a new change for review. Change subject: engine-core: RunVm - filter out unplugged nics .. engine-core: RunVm - filter out unplugged nics Change-Id: Ie1e88b50646951e2a5ddbe0044cc29678659cfd0 --- M backend

[Engine-patches] Change in ovirt-engine[master]: engine-core: supported OS of plug/unplug shuould rely on VmO...

Roy Golan has uploaded a new change for review. Change subject: engine-core: supported OS of plug/unplug shuould rely on VmOsType .. engine-core: supported OS of plug/unplug shuould rely on VmOsType instead of vm.vmguest_os whi

[Engine-patches] Change in ovirt-engine[master]: core: extract common plug/unplug canDo checks

Roy Golan has uploaded a new change for review. Change subject: core: extract common plug/unplug canDo checks .. core: extract common plug/unplug canDo checks Change-Id: I28f8a6749989f04c13195c7dddb69b93bc4a0d4f --- M backend/m

[Engine-patches] Jenkins build is back to normal : ovirt_engine_create_rpms #144

See ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] Change in ovirt-engine[master]: engine-core: [nfs-options] cleanup StorageDomainStaticDAODbF...

Allon Mureinik has posted comments on this change. Change subject: engine-core: [nfs-options] cleanup StorageDomainStaticDAODbFacadeImpl .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://

[Engine-patches] Change in ovirt-engine[master]: webadmin: I18N support for the DataCenterModel.name (#786448...

Vojtech Szocs has posted comments on this change. Change subject: webadmin: I18N support for the DataCenterModel.name (#786448) .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3163

[Engine-patches] Change in ovirt-engine[master]: webadmin: I18N for TagModel.name (#786448)

Vojtech Szocs has posted comments on this change. Change subject: webadmin: I18N for TagModel.name (#786448) .. Patch Set 1: Looks good to me, approved Indeed, this is a union of all (both ASCII and Unicode) word character rang

[Engine-patches] Build failed in Jenkins: ovirt_engine_create_rpms #143

See -- [...truncated 1920 lines...] [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 832 resources [INFO] Copying 253 resources [INFO] [compiler:compile {execution: default-

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 486 - Fixed!

ovirt_engine_unit_tests - Build # 486 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/486/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinf

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 485 - Unstable!

ovirt_engine_unit_tests - Build # 485 - Unstable: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/485/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/list

[Engine-patches] Build failed in Jenkins: ovirt_engine_create_rpms #142

See Changes: [lhornyak] core: Cleanup VMInfoBuilder classes -- [...truncated 1906 lines...] [INFO] Building war:

[Engine-patches] Change in ovirt-engine[master]: webadmin: Control refresh behavior (#802378)

Vojtech Szocs has uploaded a new change for review. Change subject: webadmin: Control refresh behavior (#802378) .. webadmin: Control refresh behavior (#802378) https://bugzilla.redhat.com/802378 This patch allows the user to c

[Engine-patches] Change in ovirt-engine[master]: webadmin: Update Firefox supported version

Vojtech Szocs has posted comments on this change. Change subject: webadmin: Update Firefox supported version .. Patch Set 2: Added new patch set that includes changes discussed above. -- To view, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: Refactor images adding flows

Mike Kolesnik has posted comments on this change. Change subject: core: Refactor images adding flows .. Patch Set 1: I would do this slightly differently, and leave the methods in the base images command, but have them call th

[Engine-patches] Change in ovirt-engine[master]: packaging: Move sysprep files to /etc

Ofer Schreiber has posted comments on this change. Change subject: packaging: Move sysprep files to /etc .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3193 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: packaging: Move sysprep files to /etc

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Move sysprep files to /etc .. packaging: Move sysprep files to /etc According to Fedora packaging guidelines files marked as configuration s

[Engine-patches] Change in ovirt-engine[master]: packaging: Move sysprep files to /etc

Ofer Schreiber has posted comments on this change. Change subject: packaging: Move sysprep files to /etc .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3193 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: Refactor images adding flows

Yair Zaslavsky has posted comments on this change. Change subject: core: Refactor images adding flows .. Patch Set 1: Please review only, I still want to check it further... -- To view, visit http://gerrit.ovirt.org/3196 To un

[Engine-patches] Change in ovirt-engine[master]: core : Dettach command

Moti Asayag has posted comments on this change. Change subject: core : Dettach command .. Patch Set 2: (4 inline comments) File backend/manager/modules/bll/src/main/java/org

[Engine-patches] Change in ovirt-engine[master]: core: Refactor images adding flows

Yair Zaslavsky has uploaded a new change for review. Change subject: core: Refactor images adding flows .. core: Refactor images adding flows Introducing some code reuse - a. Using ImagesHandler.addImage instead of BaseImagesCom

[Engine-patches] Change in ovirt-engine[master]: core: Change to snapshot lock when removing snap

Mike Kolesnik has posted comments on this change. Change subject: core: Change to snapshot lock when removing snap .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/3195 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: core: gluster- avoid using final for members for BE

Yair Zaslavsky has posted comments on this change. Change subject: core: gluster- avoid using final for members for BE .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3135 To unsub

[Engine-patches] Change in ovirt-engine[master]: engine: Create Gluster Volume & Volume Option Set

Shireesh Anjal has posted comments on this change. Change subject: engine: Create Gluster Volume & Volume Option Set .. Patch Set 4: Incorporated Omer's comments from patch-set 2 as follows: - Introduced Data Center in MLA hi

[Engine-patches] Change in ovirt-engine[master]: core: Change to snapshot lock when removing snap

Mike Kolesnik has uploaded a new change for review. Change subject: core: Change to snapshot lock when removing snap .. core: Change to snapshot lock when removing snap Change remove snapshot to lock the snapshot instead of the

[Engine-patches] Change in ovirt-engine[master]: engine: Create Gluster Volume & Volume Option Set

Shireesh Anjal has posted comments on this change. Change subject: engine: Create Gluster Volume & Volume Option Set .. Patch Set 2: (12 inline comments) Incorporated most comments by Omer. New patch-set to follow. ...

[Engine-patches] Change in ovirt-engine[master]: webadmin: Implement waiting animation Events (#783680)

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Implement waiting animation Events (#783680) .. webadmin: Implement waiting animation Events (#783680) https://bugzilla.redhat.com/783680 Thi

[Engine-patches] Change in ovirt-engine[master]: webadmin: Implement waiting animation Events (#783680)

Vojtech Szocs has posted comments on this change. Change subject: webadmin: Implement waiting animation Events (#783680) .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3118 To uns

[Engine-patches] Change in ovirt-engine[master]: webadmin: Implement waiting animation Events (#783680)

Vojtech Szocs has posted comments on this change. Change subject: webadmin: Implement waiting animation Events (#783680) .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3118 To uns

[Engine-patches] Change in ovirt-engine[master]: webadmin: Implement waiting animation Events (#783680)

Vojtech Szocs has posted comments on this change. Change subject: webadmin: Implement waiting animation Events (#783680) .. Patch Set 2: Verified; Looks good to me, approved Rebased and verified. -- To view, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: packaging: Move sysprep files to /etc

Juan Hernandez has posted comments on this change. Change subject: packaging: Move sysprep files to /etc .. Patch Set 3: Rebased. -- To view, visit http://gerrit.ovirt.org/3193 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[master]: packaging: Move sysprep files to /etc

Ofer Schreiber has posted comments on this change. Change subject: packaging: Move sysprep files to /etc .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3193 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: packaging: add the all-in-one plugin - DO NOT MERGE

Ofer Schreiber has posted comments on this change. Change subject: packaging: add the all-in-one plugin - DO NOT MERGE .. Patch Set 7: Fails (21 inline comments) 1. Missing cosnsts 2. Add host should use real host name ..

[Engine-patches] Change in ovirt-engine[master]: webadmin: Make Firefox 10 the supported browser

Vojtech Szocs has posted comments on this change. Change subject: webadmin: Make Firefox 10 the supported browser .. Patch Set 1: I agree, instead of defining exact browser versions, we should define version ranges. I'll upda

[Engine-patches] Change in ovirt-engine[master]: packaging: Move sysprep files to /etc

Juan Hernandez has uploaded a new change for review. Change subject: packaging: Move sysprep files to /etc .. packaging: Move sysprep files to /etc According to Fedora packaging guidelines files marked as configuration should go

[Engine-patches] Change in ovirt-engine[master]: core: Rename method saveDiskImage to saveImage

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Rename method saveDiskImage to saveImage .. core: Rename method saveDiskImage to saveImage The method saveDiskImage is renamed to saveImage , as

[Engine-patches] Change in ovirt-engine[master]: core: Rename method saveDiskImage to saveImage

Yair Zaslavsky has posted comments on this change. Change subject: core: Rename method saveDiskImage to saveImage .. Patch Set 3: Verified; Looks good to me, approved only rebased. -- To view, visit http://gerrit.ovirt.org/319

[Engine-patches] Change in ovirt-engine[master]: engine: quota support for multiple storage images

Michael Kublin has posted comments on this change. Change subject: engine: quota support for multiple storage images .. Patch Set 9: "Hi Michael, please see my comments inline. I think using a list for images will gain us more

[Engine-patches] Change in ovirt-engine[master]: core: Rename method saveDiskImage to saveImage

Yair Zaslavsky has posted comments on this change. Change subject: core: Rename method saveDiskImage to saveImage .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3192 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: core: Rename method saveDiskImage to saveImage

Mike Kolesnik has posted comments on this change. Change subject: core: Rename method saveDiskImage to saveImage .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3192 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: engine: quota support for multiple storage images

Maor Lipchuk has posted comments on this change. Change subject: engine: quota support for multiple storage images .. Patch Set 9: (8 inline comments) Hi Michael, please see my comments inline. I think using a list for images w

[Engine-patches] Change in ovirt-engine[master]: engine: Create Gluster Volume & Volume Option Set

Omer Frenkel has posted comments on this change. Change subject: engine: Create Gluster Volume & Volume Option Set .. Patch Set 2: (12 inline comments) File backend/manager/d

[Engine-patches] Change in ovirt-engine[master]: core: Rename method

Mike Kolesnik has posted comments on this change. Change subject: core: Rename method .. Patch Set 1: (1 inline comment) Commit Message Line 7: core: Rename method minor: May

[Engine-patches] Change in ovirt-engine[master]: engine: Create Gluster Volume & Volume Option Set

Shireesh Anjal has posted comments on this change. Change subject: engine: Create Gluster Volume & Volume Option Set .. Patch Set 3: Have incorporated comments from patch-set 2. Key changes: - Started using @NotNull annotation

[Engine-patches] Change in ovirt-engine[master]: core: Rename method

Yair Zaslavsky has uploaded a new change for review. Change subject: core: Rename method .. core: Rename method The method saveDiskImage is renamed to saveImage , as it saves only image related entities (the image and the storag

  1   2   >