Mike Kolesnik has posted comments on this change. Change subject: core: Refactor images adding flows ......................................................................
Patch Set 1: I would do this slightly differently, and leave the methods in the base images command, but have them call the ImagesHandler. This way it is easy to mock out this call. Also please note that the ImagesHandler.addImage adds a dynamic entry which is not added by BaseImagesCommand.saveImage and the BaseImagesCommand.AddDiskImageToDb has try/catch while ImagesHandler.addDiskImageWithNoVmDevice doesn't. -- To view, visit http://gerrit.ovirt.org/3196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff8247f676354ec8ffa02e26daf430297a8859c0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
