Vojtech Szocs has uploaded a new change for review. Change subject: webadmin: Control refresh behavior (#802378) ......................................................................
webadmin: Control refresh behavior (#802378) https://bugzilla.redhat.com/802378 This patch allows the user to control the auto-refresh behavior for all data grids. See the above BZ for more details. Before this patch, when the application window was out of focus, the auto-refresh behavior for all data grids was suspended by default. When the window gained focus again, auto-refresh was resumed. After this patch, the user can control whether the auto-refresh should be suspended in case the window is out of focus, using a checkbox within the login screen. This affects both WebAdmin and UserPortal. The "suspend-refresh-on-lost-focus" option is turned off by default now. The user can turn this feature on using the checkbox. The value of this option is remembered by the browser so the user doesn't have to set it each time he opens the application. This patch also does some cleanup regarding login logic shared by both applications: - AbstractLoginPopupPresenterWidget prevents common code duplication - LoginModel fixes to eliminate TODO/FIXME application code: - LoginCommand is the "default" command - LoginCommand is added to LoginModel's command list - upon failed login, corresponding EntityModels (userName, password, domain) and LoginCommand are re-enabled again Change-Id: I08c6dd9fe2c63d58b7a2d865552564d7e73425c2 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseClientGinjector.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DataBoundTabModelProvider.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/ManagedComponents.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/presenter/ConnectAutomaticallyProvider.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/presenter/LoginPopupPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/public/UserPortal.css M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ManagedComponents.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/presenter/LoginPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/public/WebAdmin.css 18 files changed, 357 insertions(+), 197 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/97/3197/1 -- To view, visit http://gerrit.ovirt.org/3197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I08c6dd9fe2c63d58b7a2d865552564d7e73425c2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
