Shireesh Anjal has posted comments on this change. Change subject: engine: Create Gluster Volume & Volume Option Set ......................................................................
Patch Set 3: Have incorporated comments from patch-set 2. Key changes: - Started using @NotNull annotations instead of null check in CanDoAction - Introduced setActionMessageParameters to set action and type messages - Removed calls to TransactionSupport.executeInNewTransaction since a single DB update doesn't require it. - Started using runVdsCommand from CommandBase instead of introducing similar method in GlusterCommandBase -- To view, visit http://gerrit.ovirt.org/3142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e5a857d188450409ce9f6eefd4df6bc1b10f9b2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
