Moti Asayag has posted comments on this change.
Change subject: core : Dettach command
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
Line 165: protected boolean isInterfaceSupportedForPlugUnPlug(DiskImageBase
diskImage) {
maybe isPlugActionAllowedForInterface ?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DettachDiskFromVmCommand.java
Line 31: diskImage =
getDiskImageDao().get(getParameters().getImageId());
why to perform this fetch from DB if retValue is false? move this after the
check of rertValue value.
Line 36: vmDevice = getVmDeviceDao().get(new
VmDeviceId(diskImage.getimage_group_id(), getVmId()));
same here
....................................................
Commit Message
Line 7: core : Dettach command
s/Dettach/Detach
--
To view, visit http://gerrit.ovirt.org/3100
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc12b29d864bdfc9e50e798f8f8720e7aaceca8f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
