Shireesh Anjal has posted comments on this change. Change subject: engine: Create Gluster Volume & Volume Option Set ......................................................................
Patch Set 4: Incorporated Omer's comments from patch-set 2 as follows: - Introduced Data Center in MLA hierarchy (create_functions.sql) - Modified constructor of CreateGlusterVolumeCommand to set the cluster id - Modified getGlusterVolumeName in AuditLogableBase to fetch the value from DB if it is null - Modified GlusterVolumeCommandBase to set cluster id only if volume id passed is correct - removed unnecessary call to super() in constructor of CreateGlusterVolumeParameters - Introduced VAR__TYPE__GLUSTER_VOLUME_OPTION in AppErrors.properties - Modified CreateGlusterVolumeVDSCommand to use "name()" method on enums instead of "toString" -- To view, visit http://gerrit.ovirt.org/3142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e5a857d188450409ce9f6eefd4df6bc1b10f9b2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
