Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Implement waiting animation Events (#783680) ......................................................................
webadmin: Implement waiting animation Events (#783680) https://bugzilla.redhat.com/783680 This patch ensures that the application detects when an EventListModel clears its data (items) before requesting new data, and updates the UI by displaying a loading indicator within the corresponding Event-related data table widget. Implementation notes: - for EventListModel classes, ItemsChangedEvent is not handled due to the model clearing its items before requesting new data (we use "LastEvent" PropertyChangedEvent to detect arrival of new data) - introduced new boolean flag in EventListModel ("requestingData") used to differentiate between two situations: a) lastEvent == null because empty list of data arrived b) lastEvent == null because new data is about to get requested - handleNullDataAsEmpty() related logic removed due to changes above Change-Id: Ieb1471fc0017455117088bf9b1a621217d4b4462 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DataBoundTabModelProvider.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/SearchableTabModelProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/EventModule.java 4 files changed, 38 insertions(+), 22 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3118 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb1471fc0017455117088bf9b1a621217d4b4462 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
