[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880931#comment-15880931 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in

[jira] [Updated] (GEODE-2342) Update GemfireTypeIds

2017-02-23 Thread Anthony Baker (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Baker updated GEODE-2342: - Fix Version/s: (was: 1.2.0) > Update GemfireTypeIds > - > >

[jira] [Created] (GEODE-2534) concurrently started locators fail to create a unified system

2017-02-23 Thread Bruce Schuchardt (JIRA)
Bruce Schuchardt created GEODE-2534: --- Summary: concurrently started locators fail to create a unified system Key: GEODE-2534 URL: https://issues.apache.org/jira/browse/GEODE-2534 Project: Geode

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880932#comment-15880932 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in

Review Request 56991: GEODE-2416: Collect together artifacts from individual servers into a single zip file

2017-02-23 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56991/ --- Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, and Kirk Lund.

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102784061 --- Diff: src/cppcache/include/geode/geode_base.hpp --- @@ -69,32 +69,9 @@ #define GF_TEMPLATE_EXPORT #endif -#if defined(_MSC_VER)

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880989#comment-15880989 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in

Re: Review Request 56964: GEODE-2526: Enhance log statement in StatsArchiveReader

2017-02-23 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56964/#review166546 --- Ship it! Ship It! - Darrel Schneider On Feb. 22, 2017, 7:03

[GitHub] geode-native pull request #25: GEODE-2382: Replace gemstone with geode.

2017-02-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode-native/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102789698 --- Diff: src/clicache/src/CacheableDate.cpp --- @@ -90,7 +90,7 @@ namespace Apache TimeSpan epochSpan = m_dateTime - EpochTime;

[jira] [Commented] (GEODE-2382) Remove "gemstone" from code base

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881017#comment-15881017 ] ASF GitHub Bot commented on GEODE-2382: --- Github user asfgit closed the pull request

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881021#comment-15881021 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a

[jira] [Commented] (GEODE-2382) Remove "gemstone" from code base

2017-02-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881016#comment-15881016 ] ASF subversion and git services commented on GEODE-2382: Commit 93

[jira] [Commented] (GEODE-2231) Create new partitioning example

2017-02-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881037#comment-15881037 ] ASF subversion and git services commented on GEODE-2231: Commit d5

[jira] [Commented] (GEODE-2480) Need to specify correct version of CMake required for building Native Client

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881050#comment-15881050 ] ASF GitHub Bot commented on GEODE-2480: --- GitHub user PivotalSarge opened a pull requ

[GitHub] geode-native pull request #29: GEODE-2480: Correct the version of CMake.

2017-02-23 Thread PivotalSarge
GitHub user PivotalSarge opened a pull request: https://github.com/apache/geode-native/pull/29 GEODE-2480: Correct the version of CMake. - Modify BUILDING.md to correct the typo in the version of CMake. You can merge this pull request into a Git repository by running: $ git pul

[GitHub] geode-native pull request #30: GEODE-2532: Create config files in runtime di...

2017-02-23 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode-native/pull/30 GEODE-2532: Create config files in runtime directory. Some config xml files were being created in the source directory instead of the runtime test directory. You can merge this pull request i

[jira] [Commented] (GEODE-2532) .NET Integration Tests Create Temp Files in the Source Directory

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881064#comment-15881064 ] ASF GitHub Bot commented on GEODE-2532: --- GitHub user mmartell opened a pull request:

Re: Review Request 56960: GEODE-2491 - Don't suppress IOExceptions when writing to the lucene index

2017-02-23 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56960/#review166553 --- Ship it! Ship It! - Jason Huynh On Feb. 23, 2017, 5:19 p.m.,

[GitHub] geode-examples pull request #3: GEODE-2231 A partitioned region example

2017-02-23 Thread karensmolermiller
GitHub user karensmolermiller opened a pull request: https://github.com/apache/geode-examples/pull/3 GEODE-2231 A partitioned region example This example intends to demonstrate what partitioning does (distributes entries across buckets, and therefore across servers). It also illust

[jira] [Commented] (GEODE-2231) Create new partitioning example

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881071#comment-15881071 ] ASF GitHub Bot commented on GEODE-2231: --- GitHub user karensmolermiller opened a pull

Re: Review Request 56989: Adding an exception listener for the last lucene exception

2017-02-23 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56989/#review166556 --- Ship it! Looks good. Would it be helpful to add which event ca

Re: Review Request 56990: Lowering the log level for errors when cleaning up the index repository

2017-02-23 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56990/#review166557 --- Ship it! Ship It! - Jason Huynh On Feb. 23, 2017, 5:22 p.m.,

[jira] [Updated] (GEODE-2480) Need to specify correct version of CMake required for building Native Client

2017-02-23 Thread Joey McAllister (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joey McAllister updated GEODE-2480: --- Component/s: (was: docs) > Need to specify correct version of CMake required for building

Re: Review Request 56801: GEODE-2457: Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

2017-02-23 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56801/ --- (Updated Feb. 23, 2017, 11:41 a.m.) Review request for geode, Jinmei Liao, Jare

[jira] [Commented] (GEODE-2457) Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

2017-02-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881104#comment-15881104 ] ASF subversion and git services commented on GEODE-2457: Commit 29

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #481 has FAILED

2017-02-23 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #481 failed. --- This was manually triggered by Trevor Marshall. No failed tests found, a possible compilation err

a new example needs your review

2017-02-23 Thread Karen Miller
Calling all Geode devs: I've put together a new, and quite basic example that attempts to demonstrate what partitioning does. Please review and see the PR at https://github.com/apache/geode-examples/pull/3 When reviewing this example, please keep in mind that my goal is to tightly focus on par

Re: Review Request 56986: GEODE-2497 surprise members are never timed out during startu

2017-02-23 Thread Galen O'Sullivan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56986/#review166563 --- geode-core/src/main/java/org/apache/geode/distributed/internal/me

Re: [Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #481 has FAILED

2017-02-23 Thread Mark Bretl
John, It looks like this is failing because it can't find the geode-*-1.1.0-SNAPSHOT.jars. As 1.1.0 has been released, we have removed these jars. Next version is currently 1.2.0(-SNAPSHOT). Would you or someone else be able to update this job? Thanks, --Mark On Thu, Feb 23, 2017 at 11:51 AM,

[GitHub] geode-native pull request #28: Feature/geode 2440

2017-02-23 Thread echobravopapa
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/28#discussion_r102809166 --- Diff: src/cppcache/integration-test/testThinClientFixedPartitionResolver.cpp --- @@ -236,8 +236,8 @@ DUNIT_TASK_DEFINITION(CLIENT1, CheckPrSi

Re: [Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #481 has FAILED

2017-02-23 Thread John Blum
Hi Mark- Thank you for your attention to this matter. I do not rebase SD Geode on Apache Geode 1.2.0 build snapshots ( 1.2.0-SNAPSHOT) until I release SD Geode 1.1.0.RELEASE based on Apache Geode 1.1.0 (release). 2 things... 1. Because Apache infra deletes (build) snapshots after a release (whi

[GitHub] geode-native pull request #28: Feature/geode 2440

2017-02-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode-native/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (GEODE-2440) Fix CacheableKey::hashcode to int32_t to match Server.

2017-02-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881210#comment-15881210 ] ASF subversion and git services commented on GEODE-2440: Commit 6c

[jira] [Commented] (GEODE-2440) Fix CacheableKey::hashcode to int32_t to match Server.

2017-02-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881209#comment-15881209 ] ASF subversion and git services commented on GEODE-2440: Commit 71

[jira] [Commented] (GEODE-2440) Fix CacheableKey::hashcode to int32_t to match Server.

2017-02-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881211#comment-15881211 ] ASF subversion and git services commented on GEODE-2440: Commit a6

[jira] [Commented] (GEODE-2480) Need to specify correct version of CMake required for building Native Client

2017-02-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881214#comment-15881214 ] ASF subversion and git services commented on GEODE-2480: Commit 8e

[jira] [Commented] (GEODE-2480) Need to specify correct version of CMake required for building Native Client

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881215#comment-15881215 ] ASF GitHub Bot commented on GEODE-2480: --- Github user asfgit closed the pull request

[GitHub] geode-native issue #30: GEODE-2532: Create config files in runtime directory...

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the issue: https://github.com/apache/geode-native/pull/30 Does this change create the xml files in each of the individual integration test's runtime directory of the root of the all the tests? --- If your project is set up for it, you can rep

[jira] [Commented] (GEODE-2532) .NET Integration Tests Create Temp Files in the Source Directory

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881220#comment-15881220 ] ASF GitHub Bot commented on GEODE-2532: --- Github user pivotal-jbarrett commented on t

[GitHub] geode-native pull request #29: GEODE-2480: Correct the version of CMake.

2017-02-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode-native/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881224#comment-15881224 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102813470 --- Diff: src/cppcache/src/RegionStats.hpp --- @@ -129,7 +129,7 @@ class CPPCACHE_EXPORT RegionStats { class RegionStatType { p

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102813688 --- Diff: src/cppcache/integration-test/testThinClientFixedPartitionResolver.cpp --- @@ -245,7 +245,7 @@ DUNIT_TASK_DEFINITION(CLIENT1, CheckP

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881226#comment-15881226 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on a

[jira] [Commented] (GEODE-2532) .NET Integration Tests Create Temp Files in the Source Directory

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881242#comment-15881242 ] ASF GitHub Bot commented on GEODE-2532: --- Github user echobravopapa commented on the

[GitHub] geode-native issue #30: GEODE-2532: Create config files in runtime directory...

2017-02-23 Thread echobravopapa
Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/30 @pivotal-jbarrett good question, @mmartell where do the files go to now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: Review Request 56986: GEODE-2497 surprise members are never timed out during startu

2017-02-23 Thread Bruce Schuchardt
> On Feb. 23, 2017, 8:11 p.m., Galen O'Sullivan wrote: > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java, > > line 980 > > > > > > Is it worth checking f

[GitHub] geode-native issue #30: GEODE-2532: Create config files in runtime directory...

2017-02-23 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode-native/pull/30 The xml files are created in the runtime working directory. For a Debug build this is: BUILD_DIR\clicache\integration-test\Debug, where BUILD_DIR is the cmake build directory. This

[jira] [Commented] (GEODE-2532) .NET Integration Tests Create Temp Files in the Source Directory

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881301#comment-15881301 ] ASF GitHub Bot commented on GEODE-2532: --- Github user mmartell commented on the issue

[jira] [Commented] (GEODE-2460) Update dependency versions

2017-02-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881304#comment-15881304 ] ASF subversion and git services commented on GEODE-2460: Commit 38

Re: Review Request 56986: GEODE-2497 surprise members are never timed out during startu

2017-02-23 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56986/#review166579 --- Ship it! Ship It! - Hitesh Khamesra On Feb. 23, 2017, 4:17 p

[GitHub] geode-native issue #30: GEODE-2532: Create config files in runtime directory...

2017-02-23 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode-native/pull/30 @echobravopapa There is an inconsistency in how a few of the tests compute the path for the configured xml file. After inspection, there didn't appear to be a simple high level way to fix this.

[jira] [Commented] (GEODE-2532) .NET Integration Tests Create Temp Files in the Source Directory

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881317#comment-15881317 ] ASF GitHub Bot commented on GEODE-2532: --- Github user mmartell commented on the issue

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102825908 --- Diff: src/cppcache/src/statistics/GeodeStatisticsFactory.hpp --- @@ -98,50 +98,50 @@ class GeodeStatisticsFactory : public StatisticsFactory {

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102825863 --- Diff: src/cppcache/src/RegionStats.hpp --- @@ -129,7 +129,7 @@ class CPPCACHE_EXPORT RegionStats { class RegionStatType { private:

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881322#comment-15881322 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102825954 --- Diff: src/cppcache/src/statistics/HostStatHelperSolaris.cpp --- @@ -86,23 +86,23 @@ void HostStatHelperSolaris::refreshProcess(ProcessStats* proces

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881323#comment-15881323 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881324#comment-15881324 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102826049 --- Diff: src/cppcache/src/statistics/StatisticDescriptorImpl.cpp --- @@ -41,8 +41,8 @@ StatisticDescriptorImpl::StatisticDescriptorImpl(const char* st

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881327#comment-15881327 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on a diff in

Review Request 56999: GEODE-2534 concurrently started locators fail to create a unified system

2017-02-23 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56999/ --- Review request for geode, Galen O'Sullivan and Hitesh Khamesra. Bugs: GEODE-253

[jira] [Assigned] (GEODE-2457) Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

2017-02-23 Thread Kevin Duling (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Duling reassigned GEODE-2457: --- Assignee: Kevin Duling (was: Kirk Lund) > Replace org.apache.geode.internal.FileUtil with >

[jira] [Resolved] (GEODE-2457) Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

2017-02-23 Thread Kevin Duling (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Duling resolved GEODE-2457. - Resolution: Fixed Fix Version/s: 1.2.0 > Replace org.apache.geode.internal.FileUtil with >

Re: Review Request 56989: Adding an exception listener for the last lucene exception

2017-02-23 Thread Dan Smith
> On Feb. 23, 2017, 7:30 p.m., Jason Huynh wrote: > > Looks good. Would it be helpful to add which event caused the exception as > > well? That might be a good idea - although it some cases it might not be a single event, but the whole batch. If we want that I can add it in a later commit.

[GitHub] geode-native pull request #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread echobravopapa
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/27#discussion_r102831481 --- Diff: src/cppcache/src/ThinClientRegion.hpp --- @@ -149,7 +149,7 @@ class CPPCACHE_EXPORT ThinClientRegion : public LocalRegion {

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881382#comment-15881382 ] ASF GitHub Bot commented on GEODE-2439: --- Github user echobravopapa commented on a di

Re: Review Request 56991: GEODE-2416: Collect together artifacts from individual servers into a single zip file

2017-02-23 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56991/#review166581 --- My main input overall is to create a UnitTest using mocking for ev

[jira] [Resolved] (GEODE-2440) Fix CacheableKey::hashcode to int32_t to match Server.

2017-02-23 Thread Ernest Burghardt (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernest Burghardt resolved GEODE-2440. - Resolution: Fixed > Fix CacheableKey::hashcode to int32_t to match Server. > -

[jira] [Resolved] (GEODE-2508) Generize lib naming

2017-02-23 Thread Ernest Burghardt (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernest Burghardt resolved GEODE-2508. - Resolution: Fixed > Generize lib naming > --- > > Key: GEO

Re: Review Request 56964: GEODE-2526: Enhance log statement in StatsArchiveReader

2017-02-23 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56964/#review166590 --- +1 I know this change is good and would be safe commit it as is, h

Review Request 57001: Added Dunit tests for to test out Lucene pagination in persistent PR

2017-02-23 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57001/ --- Review request for geode, Jason Huynh, Lynn Hughes-Godfrey, Dan Smith, and xiaoj

Re: Review Request 57001: Added Dunit tests for to test out Lucene pagination in persistent PR

2017-02-23 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57001/#review166593 --- geode-lucene/src/test/java/org/apache/geode/cache/lucene/Paginati

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #482 was SUCCESSFUL (with 1679 tests)

2017-02-23 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #482 was successful. --- Scheduled 1681 tests in total. https://build.spring.io/browse/SGF-NAG-482/ -- This

Re: Review Request 56991: GEODE-2416: Collect together artifacts from individual servers into a single zip file

2017-02-23 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56991/#review166599 --- Kirk did a very comprehensive review. I only have this to add aft

[GitHub] geode-native issue #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the issue: https://github.com/apache/geode-native/pull/27 A rebase would have been preferable to a merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881536#comment-15881536 ] ASF GitHub Bot commented on GEODE-2439: --- Github user pivotal-jbarrett commented on t

[GitHub] geode-native issue #30: GEODE-2532: Create config files in runtime directory...

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the issue: https://github.com/apache/geode-native/pull/30 The C++ integration test framework keeps the test files in a directory specific to the current test. Can we not do the same thing here and avoid this random thing? --- If your project

[jira] [Commented] (GEODE-2532) .NET Integration Tests Create Temp Files in the Source Directory

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881540#comment-15881540 ] ASF GitHub Bot commented on GEODE-2532: --- Github user pivotal-jbarrett commented on t

[GitHub] geode-native issue #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread dgkimura
Github user dgkimura commented on the issue: https://github.com/apache/geode-native/pull/27 @pivotal-jbarrett Yes. Shall I redo? I had decided to use the github UI to resolve conflict and that's how it came out. I guess that's what I get for leaving the terminal? --- If your proj

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881557#comment-15881557 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on the issue

[GitHub] geode-native issue #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread echobravopapa
Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/27 @dgkimura yes, you want to handle all that locally... it was just your turn to fall for Github's siren song --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881560#comment-15881560 ] ASF GitHub Bot commented on GEODE-2439: --- Github user echobravopapa commented on the

Re: Review Request 56964: GEODE-2526: Enhance log statement in StatsArchiveReader

2017-02-23 Thread Kirk Lund
> On Feb. 23, 2017, 10:18 p.m., Kirk Lund wrote: > > +1 I know this change is good and would be safe commit it as is, however we > > have been trying to create UnitTests for any class that we touch that > > doesn't already have a UnitTest. As a whole, the project relies too much on > > end-to-

Re: Review Request 56964: GEODE-2526: Enhance log statement in StatsArchiveReader

2017-02-23 Thread Kirk Lund
> On Feb. 23, 2017, 10:18 p.m., Kirk Lund wrote: > > +1 I know this change is good and would be safe commit it as is, however we > > have been trying to create UnitTests for any class that we touch that > > doesn't already have a UnitTest. As a whole, the project relies too much on > > end-to-

Re: Review Request 57001: Added Dunit tests for to test out Lucene pagination in persistent PR

2017-02-23 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57001/#review166609 --- Fix it, then Ship it! geode-lucene/src/test/java/org/apache/ge

[jira] [Created] (GEODE-2535) DiskId keyId is not correctly updated

2017-02-23 Thread Darrel Schneider (JIRA)
Darrel Schneider created GEODE-2535: --- Summary: DiskId keyId is not correctly updated Key: GEODE-2535 URL: https://issues.apache.org/jira/browse/GEODE-2535 Project: Geode Issue Type: Bug

Re: Review Request 56991: GEODE-2416: Collect together artifacts from individual servers into a single zip file

2017-02-23 Thread Kirk Lund
> On Feb. 23, 2017, 11:09 p.m., Kevin Duling wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/cli/CliAroundInterceptor.java, > > lines 47-55 > > > > > > Incomplete javadoc. It should be eithe

[jira] [Resolved] (GEODE-2522) Refactor Lucene D Unit tests

2017-02-23 Thread Jason Huynh (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Huynh resolved GEODE-2522. Resolution: Fixed Fix Version/s: 1.2.0 > Refactor Lucene D Unit tests > -

[GitHub] geode-native issue #27: GEODE-2439: Remove non-standard int typedefs

2017-02-23 Thread dgkimura
Github user dgkimura commented on the issue: https://github.com/apache/geode-native/pull/27 @echobravopapa Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[jira] [Commented] (GEODE-2439) Replace all non-standard types in all public includes / API

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881604#comment-15881604 ] ASF GitHub Bot commented on GEODE-2439: --- Github user dgkimura commented on the issue

[jira] [Commented] (GEODE-2491) Reduce logging of handled exceptions in LuceneEventListener and LuceneBucketListeners

2017-02-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881608#comment-15881608 ] ASF subversion and git services commented on GEODE-2491: Commit 36

[jira] [Commented] (GEODE-2497) surprise members are never timed out during startup

2017-02-23 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881609#comment-15881609 ] ASF subversion and git services commented on GEODE-2497: Commit 42

[jira] [Updated] (GEODE-2461) Remove unnecessary entries from gradle/dependency-versions.properties

2017-02-23 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2461: - Description: These unused entries are potential candidates for removal from gradle/dependency-versions.pr

Re: Review Request 56999: GEODE-2534 concurrently started locators fail to create a unified system

2017-02-23 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56999/#review166616 --- Ship it! Ship It! - Hitesh Khamesra On Feb. 23, 2017, 9:50 p

[jira] [Resolved] (GEODE-2497) surprise members are never timed out during startup

2017-02-23 Thread Bruce Schuchardt (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Schuchardt resolved GEODE-2497. - Resolution: Fixed > surprise members are never timed out during startup >

Re: Review Request 57001: Added Dunit tests for to test out Lucene pagination in persistent PR

2017-02-23 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57001/ --- (Updated Feb. 24, 2017, 12:36 a.m.) Review request for geode, Jason Huynh, Lynn

[jira] [Created] (GEODE-2536) DiskId code confusing in how it implements needsToBeWritten

2017-02-23 Thread Darrel Schneider (JIRA)
Darrel Schneider created GEODE-2536: --- Summary: DiskId code confusing in how it implements needsToBeWritten Key: GEODE-2536 URL: https://issues.apache.org/jira/browse/GEODE-2536 Project: Geode

[jira] [Commented] (GEODE-2535) DiskId keyId is not correctly updated

2017-02-23 Thread Darrel Schneider (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881659#comment-15881659 ] Darrel Schneider commented on GEODE-2535: - Another related bug is code in the same

<    1   2   3   >