----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57001/#review166609 -----------------------------------------------------------
Fix it, then Ship it! geode-lucene/src/test/java/org/apache/geode/cache/lucene/PaginationOnPersistentRegionDUnitTest.java (line 76) <https://reviews.apache.org/r/57001/#comment238613> You only need to flush from one member. geode-lucene/src/test/java/org/apache/geode/cache/lucene/PaginationOnPersistentRegionDUnitTest.java (line 92) <https://reviews.apache.org/r/57001/#comment238614> Maybe use ExpectedException for this. - Dan Smith On Feb. 23, 2017, 10:24 p.m., nabarun nag wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57001/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2017, 10:24 p.m.) > > > Review request for geode, Jason Huynh, Lynn Hughes-Godfrey, Dan Smith, and > xiaojian zhou. > > > Repository: geode > > > Description > ------- > > The following cases are being tested in the newly created > PaginationOnPersistentRegionDUnitTest.java: > > 1. The only single data store goes offline while paginating -> expected : > NoSuchElementException > 2. One data store goes offline while one still remains online while > paginating -> expected : all keys must be retrieved successfully. > 3. Two data stores exists but we alternatively shut one down and bring the > other up in between getting a page -> expected : all keys must be > successfully retrieved. > > > Diffs > ----- > > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneDUnitTest.java > 6d8278e > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/PaginationOnPersistentRegionDUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/57001/diff/ > > > Testing > ------- > > spotlessApply > geode-lucene:prechecin > > > Thanks, > > nabarun nag > >
