----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56999/#review166616 -----------------------------------------------------------
Ship it! Ship It! - Hitesh Khamesra On Feb. 23, 2017, 9:50 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56999/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2017, 9:50 p.m.) > > > Review request for geode, Galen O'Sullivan and Hitesh Khamesra. > > > Bugs: GEODE-2534 > https://issues.apache.org/jira/browse/GEODE-2534 > > > Repository: geode > > > Description > ------- > > GMS services were being installed in the locator before they were started, > causing the locator to not know its own member ID. This caused the > concurrent startup registry to not contain its member ID, allowing > FindCoordinatorResponses to be incorrect. > > * locator A starts location service, installs GMS services w/o ID > * locator B sends FindCoordinatorRequest to A, gets response saying B should > be coordinator > * locator B starts to become coordinator > * locator A establishes its ID, sends FindCoordinator request to A & B, gets > responses saying A should be coordinator > * locator A becomes coordinator with view [A] > * locator B finishes becoming coordinator with view [B] > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/distributed/Locator.java > 2c7c251b3be09309819c4c413436cd47c70970be > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java > 6d7c5a91fdfbf43b7a9e6305a32f556390d05d3c > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/FindCoordinatorResponse.java > 8d340070bdf6839b73217879427785502710c3bd > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java > c05140d29fbdc26a1e218a9c393f3ba5bed81089 > geode-core/src/test/java/org/apache/geode/distributed/LocatorDUnitTest.java > da0daeb5f85a7c3aeb484ce1db820b9a96dd2f2e > > Diff: https://reviews.apache.org/r/56999/diff/ > > > Testing > ------- > > > Thanks, > > Bruce Schuchardt > >
