Github user dgkimura commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/27#discussion_r102784061
  
    --- Diff: src/cppcache/include/geode/geode_base.hpp ---
    @@ -69,32 +69,9 @@
     #define GF_TEMPLATE_EXPORT
     #endif
     
    -#if defined(_MSC_VER)
    -/* 32 bit Windows only, for now */
    -typedef signed char int8;        /**< single byte, character or boolean 
field */
    -typedef unsigned char uint8;     /**< unsigned integer value */
    -typedef signed short int16;      /**< signed 16 bit integer (short) */
    -typedef unsigned short uint16;   /**< unsigned 16 bit integer (ushort) */
    -typedef signed int int32;        /**< signed 32 bit integer */
    -typedef unsigned int uint32;     /**< unsigned 32 bit integer */
    -typedef signed __int64 int64;    /**< signed 64 bit integer */
    -typedef unsigned __int64 uint64; /**< unsigned 64 bit integer */
    -
    -// typedef int32            intptr_t; /**< a pointer to a 32 bit integer */
    -// typedef uint32           uintptr_t; /**< a pointer to an unsigned 32 bit
    -// integer */
    -
    -/* Windows does not have stdint.h */
    -typedef int8 int8_t;
    -typedef uint8 uint8_t;
    -typedef int16 int16_t;
    -typedef uint16 uint16_t;
    -typedef int32 int32_t;
    -typedef uint32 uint32_t;
    -typedef int64 int64_t;
    -typedef uint64 uint64_t;
    -/* end stdint.h */
    +#include <cstdint>
    --- End diff --
    
    I couldn't move this up much.  It's needed in `geode_globals.hpp` where we 
declare an external function millisleep that takes a `uint32_t`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to