[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881323#comment-15881323
 ] 

ASF GitHub Bot commented on GEODE-2439:
---------------------------------------

Github user dgkimura commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/27#discussion_r102825908
  
    --- Diff: src/cppcache/src/statistics/GeodeStatisticsFactory.hpp ---
    @@ -98,50 +98,50 @@ class GeodeStatisticsFactory : public StatisticsFactory 
{
       Statistics* createStatistics(StatisticsType* type, const char* textId);
     
       Statistics* createStatistics(StatisticsType* type, const char* textId,
    -                               int64 numericId);
    +                               int64_t numericId);
     
       Statistics* createOsStatistics(StatisticsType* type, const char* textId,
    -                                 int64 numericId);
    +                                 int64_t numericId);
     
       Statistics* createAtomicStatistics(StatisticsType* type);
     
       Statistics* createAtomicStatistics(StatisticsType* type, const char* 
textId);
     
       Statistics* createAtomicStatistics(StatisticsType* type, const char* 
textId,
    -                                     int64 numericId);
    +                                     int64_t numericId);
     
       //------------ StatisticsFactory methods: Statistics Type
       //------------------------------
       StatisticsType* createType(const char* name, const char* description,
    -                             StatisticDescriptor** stats, int32 
statsLength);
    +                             StatisticDescriptor** stats, int32_t 
statsLength);
     
       StatisticsType* findType(const char* name);
     
       //------------ StatisticsFactory methods: Statistics Descriptor
       //---------------------
       StatisticDescriptor* createIntCounter(const char* name,
                                             const char* description,
    -                                        const char* units, int8 
largerBetter);
    +                                        const char* units, int8_t 
largerBetter);
    --- End diff --
    
    Done!


> Replace all non-standard types in all public includes / API
> -----------------------------------------------------------
>
>                 Key: GEODE-2439
>                 URL: https://issues.apache.org/jira/browse/GEODE-2439
>             Project: Geode
>          Issue Type: Bug
>          Components: native client
>            Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to