Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102789698
--- Diff: src/clicache/src/CacheableDate.cpp ---
@@ -90,7 +90,7 @@ namespace Apache
TimeSpan epochSpan = m_dateTime - EpochTime;
int64_t millitime =
epochSpan.Ticks / TimeSpan::TicksPerMillisecond;
- m_hashcode = (int)millitime ^ (int)((int64)millitime >> 32);
+ m_hashcode = (int)millitime ^ (int)((int64_t)millitime >> 32);
--- End diff --
This version of CacheableDate is C++/CLI. C++/CLI is only C++ in name. It
does not make sense to use C++11 types in C++/CLI despite the fact that they
"work". In C++/CLI `int`, `long`, etc. are not ambiguous like they are in C++.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
