> On Feb. 23, 2017, 8:11 p.m., Galen O'Sullivan wrote: > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java, > > line 980 > > <https://reviews.apache.org/r/56986/diff/1/?file=1645882#file1645882line980> > > > > Is it worth checking for dcReceiver after this? Do you know what the > > difference is?
The listener instance variable is always set in the constructor. I need the null checks here for certain junit tests using mocks. In practice it is never null. The dcListener instance variable is conditionally set in the init(Services) method and is null if use of tcp/ip stream sockets is disabled. - Bruce ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56986/#review166563 ----------------------------------------------------------- On Feb. 23, 2017, 4:17 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56986/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2017, 4:17 p.m.) > > > Review request for geode, Galen O'Sullivan and Hitesh Khamesra. > > > Bugs: GEODE-2497 > https://issues.apache.org/jira/browse/GEODE-2497 > > > Repository: geode > > > Description > ------- > > fixing NPE hit by tests using disable-tcp=true. In this configuration there > is no dclistener in the membership manager but there _is_ a listener. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java > d0a0cbed9c895af26dfba9c5d5ca7fe50b195a30 > > Diff: https://reviews.apache.org/r/56986/diff/ > > > Testing > ------- > > precheckin, disable-tcp=true testing > > > Thanks, > > Bruce Schuchardt > >
