Re: [PR] Add validations for Pauseless Tables [pinot]

2025-04-17 Thread via GitHub
Jackie-Jiang commented on code in PR #15567: URL: https://github.com/apache/pinot/pull/15567#discussion_r2049440985 ## pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisStreamMetadataProvider.java: ## @@ -101,7 +100,11

Re: [PR] Add button to repair realtime table by triggering RealtimeSegmentValidationManager [pinot]

2025-04-17 Thread via GitHub
jayeshchoudhary commented on code in PR #15584: URL: https://github.com/apache/pinot/pull/15584#discussion_r2049173800 ## pinot-controller/src/main/resources/app/utils/PinotMethodUtils.ts: ## @@ -1008,6 +1009,12 @@ const rebalanceBrokersForTableOp = (tableName) => { return

Re: [PR] Add button to repair realtime table by triggering RealtimeSegmentValidationManager [pinot]

2025-04-17 Thread via GitHub
jayeshchoudhary commented on code in PR #15584: URL: https://github.com/apache/pinot/pull/15584#discussion_r2049176025 ## pinot-controller/src/main/resources/app/pages/TenantDetails.tsx: ## @@ -466,6 +466,20 @@ const TenantPageDetails = ({ match }: RouteComponentProps) => {

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

2025-04-17 Thread via GitHub
ankitsultana commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2049189342 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/ParserUtils.java: ## @@ -39,6 +39,49 @@ public static void validateFunction(String canonicalName, List

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

2025-04-17 Thread via GitHub
ankitsultana commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2049189342 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/ParserUtils.java: ## @@ -39,6 +39,49 @@ public static void validateFunction(String canonicalName, List

Re: [PR] Move Query Execution Planning to TableExecutionInfo in SSE [pinot]

2025-04-17 Thread via GitHub
vrajat commented on PR #15523: URL: https://github.com/apache/pinot/pull/15523#issuecomment-2813314137 Test failure is unrelated and seems like a flaky test. It passed locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] Add button to repair realtime table by triggering RealtimeSegmentValidationManager [pinot]

2025-04-17 Thread via GitHub
jayeshchoudhary commented on code in PR #15584: URL: https://github.com/apache/pinot/pull/15584#discussion_r2049176025 ## pinot-controller/src/main/resources/app/pages/TenantDetails.tsx: ## @@ -466,6 +466,20 @@ const TenantPageDetails = ({ match }: RouteComponentProps) => {

Re: [PR] Add button to repair realtime table by triggering RealtimeSegmentValidationManager [pinot]

2025-04-17 Thread via GitHub
jayeshchoudhary commented on code in PR #15584: URL: https://github.com/apache/pinot/pull/15584#discussion_r2049175562 ## pinot-controller/src/main/resources/app/pages/TenantDetails.tsx: ## @@ -466,6 +466,20 @@ const TenantPageDetails = ({ match }: RouteComponentProps) => {

Re: [PR] [ui][refactor] New API util - FetchRebalanceTableJobs [pinot]

2025-04-17 Thread via GitHub
somandal merged PR #15581: URL: https://github.com/apache/pinot/pull/15581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[PR] update docker compose file [pinot]

2025-04-17 Thread via GitHub
xiangfu0 opened a new pull request, #15583: URL: https://github.com/apache/pinot/pull/15583 updated the image version and adding minion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Bump software.amazon.awssdk:bom from 2.31.22 to 2.31.23 [pinot]

2025-04-17 Thread via GitHub
codecov-commenter commented on PR #15582: URL: https://github.com/apache/pinot/pull/15582#issuecomment-2812639107 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15582?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Bump software.amazon.awssdk:bom from 2.31.22 to 2.31.23 [pinot]

2025-04-17 Thread via GitHub
dependabot[bot] opened a new pull request, #15582: URL: https://github.com/apache/pinot/pull/15582 Bumps software.amazon.awssdk:bom from 2.31.22 to 2.31.23. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- |

Re: [PR] Logical table CRUD operations. [pinot]

2025-04-17 Thread via GitHub
vrajat commented on code in PR #15515: URL: https://github.com/apache/pinot/pull/15515#discussion_r2048481715 ## pinot-common/src/main/java/org/apache/pinot/common/utils/LogicalTableUtils.java: ## @@ -0,0 +1,121 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Logical table CRUD operations. [pinot]

2025-04-17 Thread via GitHub
abhishekbafna commented on code in PR #15515: URL: https://github.com/apache/pinot/pull/15515#discussion_r2048419062 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java: ## @@ -152,6 +154,21 @@ public static ControllerTest getInstance() {

Re: [PR] [Priority Replica Group Routing] Support orderedPreferredReplicas query option for customizable routing strategy [pinot]

2025-04-17 Thread via GitHub
wirybeaver commented on code in PR #15203: URL: https://github.com/apache/pinot/pull/15203#discussion_r2048320915 ## pinot-broker/src/main/java/org/apache/pinot/broker/routing/adaptiveserverselector/PriorityGroupInstanceSelector.java: ## @@ -0,0 +1,194 @@ +/** + * Licensed to th

Re: [PR] [ui][refactor] New API util - FetchRebalanceTableJobs [pinot]

2025-04-16 Thread via GitHub
codecov-commenter commented on PR #15581: URL: https://github.com/apache/pinot/pull/15581#issuecomment-2811523039 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15581?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] STP-3739: Segment files batch deletion. [pinot]

2025-04-16 Thread via GitHub
ankitsultana commented on code in PR #15473: URL: https://github.com/apache/pinot/pull/15473#discussion_r2048210586 ## pinot-spi/src/main/java/org/apache/pinot/spi/filesystem/PinotFS.java: ## @@ -70,6 +70,16 @@ boolean mkdir(URI uri) boolean delete(URI segmentUri, boolean for

Re: [PR] Preserve the Order of the Pre-check Items [pinot]

2025-04-16 Thread via GitHub
Jackie-Jiang commented on code in PR #15496: URL: https://github.com/apache/pinot/pull/15496#discussion_r2047996189 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java: ## @@ -77,7 +78,9 @@ public Map check(PreCheck

Re: [PR] Add mergedTextIndexPrefixToExclude config to SchemaConformingTransformer [pinot]

2025-04-16 Thread via GitHub
itschrispeck merged PR #15542: URL: https://github.com/apache/pinot/pull/15542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Add a config to skip updating dedup metadata for non-default tier segments [pinot]

2025-04-16 Thread via GitHub
Jackie-Jiang merged PR #15576: URL: https://github.com/apache/pinot/pull/15576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[PR] [ui][refactor] New API util - FetchRebalanceTableJobs [pinot]

2025-04-16 Thread via GitHub
himanish-star opened a new pull request, #15581: URL: https://github.com/apache/pinot/pull/15581 In follow up to PR #15554 This PR creates a new PinotMethodUtil named `fetchRebalanceTableJobs` that fetches the rebalance jobs and sorts them based on descending order of date time --

Re: [I] [Flaky-test] MailboxServiceTest.testRemoteEarlyTerminated [pinot]

2025-04-16 Thread via GitHub
Jackie-Jiang commented on issue #15580: URL: https://github.com/apache/pinot/issues/15580#issuecomment-281080 @gortiz This is very likely caused by #15245. Please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Fallback for bad values in periodic controller task configurations [pinot]

2025-04-16 Thread via GitHub
Jackie-Jiang commented on code in PR #15466: URL: https://github.com/apache/pinot/pull/15466#discussion_r2048000600 ## pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java: ## @@ -367,6 +372,8 @@ private static long getRandomInitialDelayInSeconds() {

Re: [I] Raplace spaces with underscore in segment name otherwise segment is going to be bad state [pinot]

2025-04-16 Thread via GitHub
Jackie-Jiang commented on issue #15472: URL: https://github.com/apache/pinot/issues/15472#issuecomment-2811335913 Do run run into issues for segment name with spaces? We explicitly test that in our integration test. See `ClusterIntegrationTestUtils.buildSegmentFromAvro()` where we added `"

Re: [PR] Add Configurable Limit For `GridDisk` Function To Avoid OOM [pinot]

2025-04-16 Thread via GitHub
Jackie-Jiang commented on code in PR #15529: URL: https://github.com/apache/pinot/pull/15529#discussion_r2047986635 ## pinot-core/src/main/java/org/apache/pinot/core/geospatial/transform/function/ScalarFunctions.java: ## @@ -37,6 +37,13 @@ public class ScalarFunctions { priva

Re: [PR] Enable kinesis tests [pinot]

2025-04-16 Thread via GitHub
Jackie-Jiang merged PR #15564: URL: https://github.com/apache/pinot/pull/15564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Bump http-proxy-middleware and webpack-dev-server in /pinot-controller/src/main/resources [pinot]

2025-04-16 Thread via GitHub
Jackie-Jiang closed pull request #15579: Bump http-proxy-middleware and webpack-dev-server in /pinot-controller/src/main/resources URL: https://github.com/apache/pinot/pull/15579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Bump http-proxy-middleware and webpack-dev-server in /pinot-controller/src/main/resources [pinot]

2025-04-16 Thread via GitHub
dependabot[bot] commented on PR #15579: URL: https://github.com/apache/pinot/pull/15579#issuecomment-2811281481 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by

Re: [PR] Bump http-proxy-middleware and webpack-dev-server in /pinot-controller/src/main/resources [pinot]

2025-04-16 Thread via GitHub
codecov-commenter commented on PR #15579: URL: https://github.com/apache/pinot/pull/15579#issuecomment-2810896252 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15579?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add a config to skip updating upsert/dedup metadata for non-default tier segments [pinot]

2025-04-16 Thread via GitHub
codecov-commenter commented on PR #15576: URL: https://github.com/apache/pinot/pull/15576#issuecomment-2810875922 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15576?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Bump com.microsoft.azure:msal4j from 1.20.0 to 1.20.1 [pinot]

2025-04-16 Thread via GitHub
Jackie-Jiang merged PR #15568: URL: https://github.com/apache/pinot/pull/15568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[I] [Flaky-test] MailboxServiceTest.testRemoteEarlyTerminated [pinot]

2025-04-16 Thread via GitHub
Jackie-Jiang opened a new issue, #15580: URL: https://github.com/apache/pinot/issues/15580 ``` [INFO] Running org.apache.pinot.query.mailbox.MailboxServiceTest 12:42:02.146 WARN [MailboxContentObserver] [grpc-default-executor-2] Timed out adding block into mailbox: 8|1|0|0|0 with timeo

Re: [PR] roundDecimal() fails for null FLOAT values [pinot]

2025-04-16 Thread via GitHub
Jackie-Jiang commented on code in PR #15377: URL: https://github.com/apache/pinot/pull/15377#discussion_r2047784751 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/RoundDecimalTransformFunction.java: ## @@ -90,18 +90,33 @@ public double[] transformT

Re: [PR] roundDecimal() fails for null FLOAT values [pinot]

2025-04-16 Thread via GitHub
Jackie-Jiang commented on code in PR #15377: URL: https://github.com/apache/pinot/pull/15377#discussion_r2047781243 ## pinot-core/src/main/java/org/apache/pinot/core/operator/query/SelectionOnlyOperator.java: ## @@ -132,7 +132,11 @@ protected SelectionResultsBlock getNextBlock()

[PR] Add a New Pre-check Item for Replica Groups Info [pinot]

2025-04-16 Thread via GitHub
J-HowHuang opened a new pull request, #15575: URL: https://github.com/apache/pinot/pull/15575 ## Description Replica groups is an important config that user often check while operating table rebalance. To avoid any overlook, this PR escalates the check into one of the pre-check items.

Re: [PR] Part 2: Enhance rebalance progress stats - Rollback Support [pinot]

2025-04-16 Thread via GitHub
somandal commented on code in PR #15510: URL: https://github.com/apache/pinot/pull/15510#discussion_r2047774864 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/ZkBasedTableRebalanceObserver.java: ## @@ -100,6 +110,12 @@ public void onTrigger(Tr

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

2025-04-16 Thread via GitHub
Jackie-Jiang commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2047770813 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/ParserUtils.java: ## @@ -39,6 +39,49 @@ public static void validateFunction(String canonicalName, List

[PR] Bump http-proxy-middleware and webpack-dev-server in /pinot-controller/src/main/resources [pinot]

2025-04-16 Thread via GitHub
dependabot[bot] opened a new pull request, #15579: URL: https://github.com/apache/pinot/pull/15579 Bumps [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) to 2.0.9 and updates ancestor dependency [webpack-dev-server](https://github.com/webpack/webpack-dev-server).

Re: [PR] Part 2: Enhance rebalance progress stats - Rollback Support [pinot]

2025-04-16 Thread via GitHub
raghavyadav01 commented on code in PR #15510: URL: https://github.com/apache/pinot/pull/15510#discussion_r2047764716 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/ZkBasedTableRebalanceObserver.java: ## @@ -100,6 +110,12 @@ public void onTrigg

Re: [PR] Bump org.apache.datasketches:datasketches-java from 6.2.0 to 8.0.0 [pinot]

2025-04-16 Thread via GitHub
dependabot[bot] commented on PR #15570: URL: https://github.com/apache/pinot/pull/15570#issuecomment-2810800884 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Bump org.apache.datasketches:datasketches-java from 6.2.0 to 8.0.0 [pinot]

2025-04-16 Thread via GitHub
Jackie-Jiang closed pull request #15570: Bump org.apache.datasketches:datasketches-java from 6.2.0 to 8.0.0 URL: https://github.com/apache/pinot/pull/15570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] Add a config to skip updating upsert/dedup metadata for non-default tier segments [pinot]

2025-04-16 Thread via GitHub
Jackie-Jiang opened a new pull request, #15576: URL: https://github.com/apache/pinot/pull/15576 TODO: - Add test for this new feature - Ensure minion tasks honor this new config to skip processing tier segments -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] [multistage] Minor Changes to Support Physical Optimizer Related Changes [pinot]

2025-04-16 Thread via GitHub
ankitsultana commented on code in PR #15562: URL: https://github.com/apache/pinot/pull/15562#discussion_r2047732275 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/exchange/SingletonExchange.java: ## @@ -38,9 +37,7 @@ class SingletonExchange extends

Re: [PR] Add a New Pre-check Item for Replica Groups Info [pinot]

2025-04-16 Thread via GitHub
codecov-commenter commented on PR #15575: URL: https://github.com/apache/pinot/pull/15575#issuecomment-2810681537 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15575?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Fix and clean-up upsert and dedup config [pinot]

2025-04-16 Thread via GitHub
Jackie-Jiang merged PR #15528: URL: https://github.com/apache/pinot/pull/15528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] [multistage] Minor Changes to Support Physical Optimizer Related Changes [pinot]

2025-04-16 Thread via GitHub
Jackie-Jiang commented on code in PR #15562: URL: https://github.com/apache/pinot/pull/15562#discussion_r2047670962 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/exchange/SingletonExchange.java: ## @@ -38,9 +37,7 @@ class SingletonExchange extends

Re: [PR] Fix and clean-up upsert and dedup config [pinot]

2025-04-16 Thread via GitHub
Jackie-Jiang commented on code in PR #15528: URL: https://github.com/apache/pinot/pull/15528#discussion_r2047644741 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java: ## @@ -44,12 +46,16 @@ public enum ConsistencyMode { } @JsonPropertyDescrip

[PR] Add TableSegmentsInfo to thrift specification [pinot]

2025-04-16 Thread via GitHub
vrajat opened a new pull request, #15573: URL: https://github.com/apache/pinot/pull/15573 The InstanceRequest thrift object is used to send query execution information to the server by the broker. The object can only store information for a single table. For Logical Table support, the objec

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

2025-04-16 Thread via GitHub
jitendrakr88 commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2047578237 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/ParserUtils.java: ## @@ -39,6 +39,49 @@ public static void validateFunction(String canonicalName, List

Re: [PR] Normalize excessive whitespaces in sql to avoid regex performance issues [pinot]

2025-04-16 Thread via GitHub
jitendrakr88 commented on code in PR #15498: URL: https://github.com/apache/pinot/pull/15498#discussion_r2047578237 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/ParserUtils.java: ## @@ -39,6 +39,49 @@ public static void validateFunction(String canonicalName, List

Re: [PR] Add TableSegmentsInfo to thrift specification [pinot]

2025-04-16 Thread via GitHub
codecov-commenter commented on PR #15573: URL: https://github.com/apache/pinot/pull/15573#issuecomment-2810292744 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15573?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Logical table CRUD operations. [pinot]

2025-04-16 Thread via GitHub
vrajat commented on code in PR #15515: URL: https://github.com/apache/pinot/pull/15515#discussion_r2047390065 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java: ## @@ -152,6 +154,21 @@ public static ControllerTest getInstance() { return

Re: [PR] Add TableSegmentsInfo to thrift specification [pinot]

2025-04-16 Thread via GitHub
vrajat commented on PR #15573: URL: https://github.com/apache/pinot/pull/15573#issuecomment-2810201827 cc @abhishekbafna -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Log query exceptions in query runner perf tool [pinot]

2025-04-16 Thread via GitHub
codecov-commenter commented on PR #15572: URL: https://github.com/apache/pinot/pull/15572#issuecomment-2809724714 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15572?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Log query exceptions in query runner perf tool [pinot]

2025-04-16 Thread via GitHub
yashmayya opened a new pull request, #15572: URL: https://github.com/apache/pinot/pull/15572 - Currently, if queries fail with errors in the perf `QueryRunner` tool, all we get is a log line at the end like: ``` [QueryRunner] [main] FINAL REPORT: [QueryRunner] [main] Time Passed: 79

Re: [PR] roundDecimal() fails for null FLOAT values [pinot]

2025-04-16 Thread via GitHub
mghildiy commented on PR #15377: URL: https://github.com/apache/pinot/pull/15377#issuecomment-2809572994 Please review the commit. I would add unit tests accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Documentation for creating new tenants is incorrect [pinot]

2025-04-16 Thread via GitHub
aneesh-raveendran commented on issue #10580: URL: https://github.com/apache/pinot/issues/10580#issuecomment-2809548009 I'm facing the same issue while trying to create a new tenant. Even though I have untagged broker instances available, I get the following error: ``` Failed to

Re: [PR] Bump io.grpc:grpc-bom from 1.71.0 to 1.72.0 [pinot]

2025-04-16 Thread via GitHub
codecov-commenter commented on PR #15569: URL: https://github.com/apache/pinot/pull/15569#issuecomment-2809465981 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15569?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Bump com.microsoft.azure:msal4j from 1.20.0 to 1.20.1 [pinot]

2025-04-16 Thread via GitHub
codecov-commenter commented on PR #15568: URL: https://github.com/apache/pinot/pull/15568#issuecomment-2809462497 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15568?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] byte-based splitting for mse query blocks [pinot]

2025-04-16 Thread via GitHub
albertobastos opened a new pull request, #15571: URL: https://github.com/apache/pinot/pull/15571 So far query blocks sent through gRPC by the Multi Stage Engine follow a row-based splitting strategy which is not ideal, given that a single row could be larger than the maximum block size allo

Re: [PR] Add validations for Pauseless Tables [pinot]

2025-04-16 Thread via GitHub
codecov-commenter commented on PR #15567: URL: https://github.com/apache/pinot/pull/15567#issuecomment-2809369727 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15567?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Bump org.apache.datasketches:datasketches-java from 6.2.0 to 8.0.0 [pinot]

2025-04-16 Thread via GitHub
dependabot[bot] opened a new pull request, #15570: URL: https://github.com/apache/pinot/pull/15570 Bumps org.apache.datasketches:datasketches-java from 6.2.0 to 8.0.0. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | ---

[PR] Bump com.microsoft.azure:msal4j from 1.20.0 to 1.20.1 [pinot]

2025-04-16 Thread via GitHub
dependabot[bot] opened a new pull request, #15568: URL: https://github.com/apache/pinot/pull/15568 Bumps [com.microsoft.azure:msal4j](https://github.com/AzureAD/microsoft-authentication-library-for-java) from 1.20.0 to 1.20.1. Release notes Sourced from https://github.com/AzureAD/

[PR] Bump io.grpc:grpc-bom from 1.71.0 to 1.72.0 [pinot]

2025-04-16 Thread via GitHub
dependabot[bot] opened a new pull request, #15569: URL: https://github.com/apache/pinot/pull/15569 Bumps [io.grpc:grpc-bom](https://github.com/grpc/grpc-java) from 1.71.0 to 1.72.0. Commits https://github.com/grpc/grpc-java/commit/b0794e4fb64faaf9af10fa86e85018edfd433056";>b079

[PR] Add validations for Pauseless Tables [pinot]

2025-04-16 Thread via GitHub
KKcorps opened a new pull request, #15567: URL: https://github.com/apache/pinot/pull/15567 * Enforce the peerSegmentDownloadScheme is always set -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[I] Error when using LEFT JOIN with json_extract_scalar function in SELECT clause and WHERE clause on right table column [pinot]

2025-04-16 Thread via GitHub
Raxx55 opened a new issue, #15566: URL: https://github.com/apache/pinot/issues/15566 ### **_The query contains JSON_EXTRACT_SCALAR in the SELECT clause, a LEFT JOIN between two tables, and a column from the right table used in the WHERE clause, which causes an error in Pinot._** **Note:*

Re: [PR] Fix and clean-up upsert and dedup config [pinot]

2025-04-16 Thread via GitHub
noob-se7en commented on code in PR #15528: URL: https://github.com/apache/pinot/pull/15528#discussion_r2046589943 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java: ## @@ -44,12 +46,16 @@ public enum ConsistencyMode { } @JsonPropertyDescripti

Re: [PR] Enable kinesis tests [pinot]

2025-04-16 Thread via GitHub
krishan1390 commented on PR #15564: URL: https://github.com/apache/pinot/pull/15564#issuecomment-2809063435 The failing test is an unrelated test which looks like a flaky test ```Error: MultiNodesOfflineClusterIntegrationTest>OfflineClusterIntegrationTest.setUp:246->OfflineClusterI

Re: [PR] Enable kinesis tests [pinot]

2025-04-16 Thread via GitHub
krishan1390 commented on PR #15564: URL: https://github.com/apache/pinot/pull/15564#issuecomment-2808990018 Validated that RealtimeKinesisIntegrationTest is running in test set 2 ``` 2025-04-16T08:58:18.8272667Z [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:

Re: [PR] reverse MSE case-insensitive capabilities [pinot]

2025-04-16 Thread via GitHub
codecov-commenter commented on PR #15565: URL: https://github.com/apache/pinot/pull/15565#issuecomment-2808976568 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15565?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Enable kinesis tests [pinot]

2025-04-16 Thread via GitHub
codecov-commenter commented on PR #15564: URL: https://github.com/apache/pinot/pull/15564#issuecomment-2808955415 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15564?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Codecov tests [pinot]

2025-04-16 Thread via GitHub
yashmayya commented on code in PR #15560: URL: https://github.com/apache/pinot/pull/15560#discussion_r2046440458 ## .github/workflows/pinot_tests.yml: ## @@ -78,19 +78,9 @@ jobs: fail-fast: false matrix: testset: [ 1, 2 ] -java: [ 11, 21 ] +

Re: [PR] Fix MIN_MAX_RANGE aggregation function behavior when all input values are null [pinot]

2025-04-16 Thread via GitHub
yashmayya commented on code in PR #15525: URL: https://github.com/apache/pinot/pull/15525#discussion_r2046438796 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/MinMaxRangeAggregationFunction.java: ## @@ -81,10 +84,13 @@ public void aggregate(int len

Re: [PR] Refactor check for all null values in MIN_MAX_RANGE aggregation function [pinot]

2025-04-16 Thread via GitHub
yashmayya merged PR #15545: URL: https://github.com/apache/pinot/pull/15545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[PR] reverse MSE case-insensitive capabilities [pinot]

2025-04-16 Thread via GitHub
albertobastos opened a new pull request, #15565: URL: https://github.com/apache/pinot/pull/15565 Recently Multi Stage Engine [has been updated](https://github.com/apache/pinot/pull/14830) to support the `enable.case.insensitive=true` configuration and ignore case for table and field identi

[PR] Enable kinesis tests [pinot]

2025-04-16 Thread via GitHub
krishan1390 opened a new pull request, #15564: URL: https://github.com/apache/pinot/pull/15564 Enable kinesis tests. "0.12.15" doesn't have an image for arm64. Its also outdated so might cause problems with new APIs. Using "latest" is an option. But it has caused problems prev

Re: [PR] Kinesis partition split fixes [pinot]

2025-04-16 Thread via GitHub
codecov-commenter commented on PR #15563: URL: https://github.com/apache/pinot/pull/15563#issuecomment-2808724373 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15563?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] [multistage] Minor Changes to Support Physical Optimizer Related Changes [pinot]

2025-04-16 Thread via GitHub
codecov-commenter commented on PR #15562: URL: https://github.com/apache/pinot/pull/15562#issuecomment-2808668620 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15562?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Kinesis partition split fixes [pinot]

2025-04-16 Thread via GitHub
krishan1390 opened a new pull request, #15563: URL: https://github.com/apache/pinot/pull/15563 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-incompat`

Re: [PR] [multistage] Bug Fixes / Refactoring Based on E2E Physical Optimizer Test [pinot]

2025-04-16 Thread via GitHub
codecov-commenter commented on PR #15561: URL: https://github.com/apache/pinot/pull/15561#issuecomment-2808614467 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15561?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Codecov tests [pinot]

2025-04-15 Thread via GitHub
codecov-commenter commented on PR #15560: URL: https://github.com/apache/pinot/pull/15560#issuecomment-2808575265 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15560?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] [multistage] Minor Changes to Support Physical Optimizer Related Changes [pinot]

2025-04-15 Thread via GitHub
ankitsultana opened a new pull request, #15562: URL: https://github.com/apache/pinot/pull/15562 This PR contains minor changes to some of the MSE code that is used by the existing optimizer / queries. These changes are required for the Physical Optimizer changes I am working on. ###

[PR] [multistage] Bug Fixes / Refactoring Based on E2E Physical Optimizer Test [pinot]

2025-04-15 Thread via GitHub
ankitsultana opened a new pull request, #15561: URL: https://github.com/apache/pinot/pull/15561 **Note:** This does NOT touch any reachable code path so expected to be a safe change. We are building the physical optimizer behind a flag to begin with since the changes involved are significan

[PR] Codecov tests [pinot]

2025-04-15 Thread via GitHub
gortiz opened a new pull request, #15560: URL: https://github.com/apache/pinot/pull/15560 This PR changes github actions in two ways: 1. Removes the skip bytebuffer tests we introduced more than a year ago to increase our confidence in our alternative to LArray buffers. We have been usin

[I] Refactor Table Route Calculation in SSE Broker Handler [pinot]

2025-04-15 Thread via GitHub
vrajat opened a new issue, #15557: URL: https://github.com/apache/pinot/issues/15557 Table Route calculation in `BaseSingleStageBrokerRequestHandler` is hard-coded for physical or hybrid tables. This code has to be refactored to support logical tables. The plan is to refactor the relevant c

[I] Add CRUD APIs for Logical Tables [pinot]

2025-04-15 Thread via GitHub
vrajat opened a new issue, #15556: URL: https://github.com/apache/pinot/issues/15556 Add the following APIs to manage Logical Tables. | API | Method | Description | | | --- | --- | |/logicalTables|GET|Get all logical tables| ||POST|Create a logical table|

Re: [PR] [bugfix]: Fixes rebalance server status rendering [pinot]

2025-04-15 Thread via GitHub
codecov-commenter commented on PR #15554: URL: https://github.com/apache/pinot/pull/15554#issuecomment-2808077443 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15554?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Prevent NPE in minion tasks [pinot]

2025-04-15 Thread via GitHub
rseetham commented on code in PR #15550: URL: https://github.com/apache/pinot/pull/15550#discussion_r2045855825 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableConfigsRestletResource.java: ## @@ -161,6 +162,10 @@ public String getConfig( try

[PR] [bugfix]: Fixes rebalance server status rendering [pinot]

2025-04-15 Thread via GitHub
himanish-star opened a new pull request, #15554: URL: https://github.com/apache/pinot/pull/15554 ### Description Rebalance status is not rendering leading to `undefined` ### Fix Since `rebalanceServerJobs` response is now an array, the selected rebalance server job is se

Re: [PR] [typo] Fix typo in error message in ControllerConf [pinot]

2025-04-15 Thread via GitHub
codecov-commenter commented on PR #15553: URL: https://github.com/apache/pinot/pull/15553#issuecomment-2807802225 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15553?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [I] Refactor ControllerRequestClient to PinotAdminClient [pinot]

2025-04-15 Thread via GitHub
varunu28 commented on issue #15537: URL: https://github.com/apache/pinot/issues/15537#issuecomment-2807766615 @xiangfu0 I will like to take this up after getting some context. Right now `ControllerRequestClient` is part of `pinot-controller`. As part of this requirement, do we want to move

Re: [PR] [typo] Fix typo in error message in ControllerConf [pinot]

2025-04-15 Thread via GitHub
J-HowHuang commented on PR #15553: URL: https://github.com/apache/pinot/pull/15553#issuecomment-2807744516 @Jackie-Jiang I think I confused that with `controller.zk.str`. Nevermind about this PR. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] [typo] Fix typo in error message in ControllerConf [pinot]

2025-04-15 Thread via GitHub
J-HowHuang closed pull request #15553: [typo] Fix typo in error message in ControllerConf URL: https://github.com/apache/pinot/pull/15553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix and clean-up upsert and dedup config [pinot]

2025-04-15 Thread via GitHub
Jackie-Jiang commented on code in PR #15528: URL: https://github.com/apache/pinot/pull/15528#discussion_r2045687545 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java: ## @@ -44,12 +46,16 @@ public enum ConsistencyMode { } @JsonPropertyDescrip

Re: [PR] Fix and clean-up upsert and dedup config [pinot]

2025-04-15 Thread via GitHub
Jackie-Jiang commented on code in PR #15528: URL: https://github.com/apache/pinot/pull/15528#discussion_r2045687127 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java: ## @@ -19,15 +19,17 @@ package org.apache.pinot.spi.config.table; import com.fa

Re: [PR] Fix and clean-up upsert and dedup config [pinot]

2025-04-15 Thread via GitHub
Jackie-Jiang commented on code in PR #15528: URL: https://github.com/apache/pinot/pull/15528#discussion_r2045685745 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/test/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGeneratorTest.java: ##

Re: [PR] Fix and clean-up upsert and dedup config [pinot]

2025-04-15 Thread via GitHub
Jackie-Jiang commented on code in PR #15528: URL: https://github.com/apache/pinot/pull/15528#discussion_r2045682172 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java: ## @@ -744,17 +744,18 @@ static void validateUpsertAndDedupConfig(

Re: [PR] Fix and clean-up upsert and dedup config [pinot]

2025-04-15 Thread via GitHub
Jackie-Jiang commented on code in PR #15528: URL: https://github.com/apache/pinot/pull/15528#discussion_r2045679139 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/dedup/BaseTableDedupMetadataManager.java: ## @@ -40,64 +39,91 @@ public abstract class BaseTabl

Re: [PR] Fix and clean-up upsert and dedup config [pinot]

2025-04-15 Thread via GitHub
Jackie-Jiang commented on code in PR #15528: URL: https://github.com/apache/pinot/pull/15528#discussion_r2045677023 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -1780,19 +1778,18 @@ ParallelSegmentConsumptionPolic

[PR] [typo] Fix typo in error message in ControllerConf [pinot]

2025-04-15 Thread via GitHub
J-HowHuang opened a new pull request, #15553: URL: https://github.com/apache/pinot/pull/15553 This pull request includes a minor change to the error message in the `getZkStr` method of the `ControllerConf` class. The change updates the configuration key in the error message to reflect the c

  1   2   3   4   5   6   7   8   9   10   >