gortiz commented on code in PR #15919:
URL: https://github.com/apache/pinot/pull/15919#discussion_r2121033671
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/ErrorMseBlock.java:
##########
@@ -24,43 +24,75 @@
import java.util.Collections;
import java.util.EnumMap;
import java.util.Map;
-import javax.validation.constraints.NotNull;
-import org.apache.pinot.common.datablock.DataBlockUtils;
+import javax.annotation.Nullable;
import org.apache.pinot.common.response.ProcessingException;
+import org.apache.pinot.common.utils.ExceptionUtils;
+import org.apache.pinot.query.MseWorkerThreadContext;
import org.apache.pinot.spi.exception.QueryErrorCode;
import org.apache.pinot.spi.exception.QueryException;
+import org.apache.pinot.spi.query.QueryThreadContext;
import org.apache.pinot.spi.utils.JsonUtils;
/// A block that represents a failed execution.
///
public class ErrorMseBlock implements MseBlock.Eos {
+ private final int _stage;
+ private final int _worker;
Review Comment:
Fixed
##########
pinot-common/src/main/java/org/apache/pinot/common/datablock/MetadataBlock.java:
##########
@@ -35,10 +34,12 @@
public class MetadataBlock extends BaseDataBlock {
private static final Logger LOGGER =
LoggerFactory.getLogger(MetadataBlock.class);
- @VisibleForTesting
- static final int VERSION = 2;
@Nullable
private List<DataBuffer> _statsByStage;
+ private final int _stage;
+ private final int _worker;
Review Comment:
Fixed
##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java:
##########
@@ -125,6 +126,13 @@ public class PinotClientRequest {
@Inject
private HttpClientConnectionManager _httpConnMgr;
+ private String _instanceId;
+
+ @PostConstruct
+ public void init() {
+ _instanceId =
_brokerConf.getProperty(CommonConstants.Broker.CONFIG_OF_BROKER_ID,
"unknownBroker");
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
