somandal commented on code in PR #15930:
URL: https://github.com/apache/pinot/pull/15930#discussion_r2121769760
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -913,6 +914,25 @@ static void
validatePartitionedReplicaGroupInstance(TableConfig tableConfig) {
}
}
+ @VisibleForTesting
+ static void validateInstanceAssignmentConfigs(TableConfig tableConfig) {
+ if (tableConfig.getInstanceAssignmentConfigMap() == null) {
+ return;
+ }
+ for (InstanceAssignmentConfig instanceAssignmentConfig :
tableConfig.getInstanceAssignmentConfigMap().values()) {
+ if (instanceAssignmentConfig.getPartitionSelector()
+ ==
InstanceAssignmentConfig.PartitionSelector.IMPLICIT_REALTIME_TABLE_PARTITION_SELECTOR)
{
+ Preconditions.checkState(tableConfig.getTableType() ==
TableType.REALTIME,
+ "IMPLICIT_REALTIME_TABLE_PARTITION_SELECTOR can only be used for
REALTIME tables");
+
Preconditions.checkState(instanceAssignmentConfig.getReplicaGroupPartitionConfig().isReplicaGroupBased(),
Review Comment:
oh yes, forgot about that. ignore this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
