vrajat commented on PR #15881: URL: https://github.com/apache/pinot/pull/15881#issuecomment-2929685228
The caching code looks good to me. Should this code go into `HelixInstanceDataManager` as private functions or in a separate class ? For example, for tables, there is `TableDataManagerProvider`. Should the caching logic be moved to `LogicalTableContext` or `LogicalTableContextManager` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
