dinoocch commented on PR #15878: URL: https://github.com/apache/pinot/pull/15878#issuecomment-2932298227
> I'm not sure if I correctly understood your case. pinot.offheap.prioritize.bytebuffer defaults to true. Are you changing it to false? Or were you using false and now you are trying to set it to true? Oops, default true values throw me off :) This is found when `pinot.offheap.prioritize.bytebuffer` is updated to `False` which means that the unsafe buffer would always be used. > PS: Can you add the benchmark as well? It's not a very pretty benchmark since it has to duplicate the BufferFactory, Buffer, and Util functions :/ Plus requires some change from `private -> protected` for `_address`. I can add but not sure if it has much value over the existing one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
