Jackie-Jiang commented on code in PR #15957:
URL: https://github.com/apache/pinot/pull/15957#discussion_r2121965680
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -276,20 +276,47 @@ public List<PartitionGroupConsumptionStatus>
getPartitionGroupConsumptionStatusL
}
// Create a {@link PartitionGroupConsumptionStatus} for each latest segment
- StreamPartitionMsgOffsetFactory offsetFactory =
-
StreamConsumerFactoryProvider.create(streamConfigs.get(0)).createStreamMsgOffsetFactory();
- for (Map.Entry<Integer, LLCSegmentName> entry :
partitionGroupIdToLatestSegment.entrySet()) {
- int partitionGroupId = entry.getKey();
- LLCSegmentName llcSegmentName = entry.getValue();
- SegmentZKMetadata segmentZKMetadata =
- getSegmentZKMetadata(streamConfigs.get(0).getTableNameWithType(),
llcSegmentName.getSegmentName());
- PartitionGroupConsumptionStatus partitionGroupConsumptionStatus =
- new PartitionGroupConsumptionStatus(partitionGroupId,
llcSegmentName.getSequenceNumber(),
- offsetFactory.create(segmentZKMetadata.getStartOffset()),
- segmentZKMetadata.getEndOffset() == null ? null :
offsetFactory.create(segmentZKMetadata.getEndOffset()),
- segmentZKMetadata.getStatus().toString());
- partitionGroupConsumptionStatusList.add(partitionGroupConsumptionStatus);
+ String tableNameWithType = streamConfigs.get(0).getTableNameWithType();
+ int numStreams = streamConfigs.size();
+ if (numStreams == 1) {
Review Comment:
For single stream case, we don't want to do the partition id to stream
partition id conversion. This is to handle the scenario where user's custom
stream uses partition id higher than 10000. See the issue linked in the PR.
Adding some comments explaining this.
Also, single stream is the much more common case, so specializing it with
simplified logic is good for performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
