[PR] Apply some o11y: [pinot]

2025-06-02 Thread via GitHub
gortiz opened a new pull request, #15975: URL: https://github.com/apache/pinot/pull/15975 A subset of the changes proposed in https://github.com/apache/pinot/pull/15919, so we merge them faster and discuss about larger changes in the other PR -- This is an automated message from the Apac

Re: [PR] Invalidate from cache the stats of opchains that finish successfully. [pinot]

2025-06-02 Thread via GitHub
gortiz commented on PR #15967: URL: https://github.com/apache/pinot/pull/15967#issuecomment-2933627063 > how long running were the queries that caused this? (what was their configured timeout) They were running for less than 1 second. But the issue is not on their execution time but

Re: [I] Group By Truncates at Limit in Combine Operator [pinot]

2025-06-02 Thread via GitHub
anandheritage commented on issue #14956: URL: https://github.com/apache/pinot/issues/14956#issuecomment-2933563238 @ankitsultana @Jackie-Jiang We can close this issue now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [I] [Tracker] Time Series Engine GA [pinot]

2025-06-02 Thread via GitHub
shauryachats commented on issue #15974: URL: https://github.com/apache/pinot/issues/15974#issuecomment-2933464440 @shauryachats thanks, can pick this up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[I] [Tracker] Time Series Engine GA [pinot]

2025-06-02 Thread via GitHub
ankitsultana opened a new issue, #15974: URL: https://github.com/apache/pinot/issues/15974 Tracker task for pending items for the Time Series Engine. - [ ] Remove reliance on table-type suffix. Presently users need to specify table name with type. This is because of the logic in `Tabl

Re: [PR] Use Kafka Admin client to Fetch offsets instead of Kafka Consumer [pinot]

2025-06-02 Thread via GitHub
KKcorps commented on code in PR #15641: URL: https://github.com/apache/pinot/pull/15641#discussion_r2122657503 ## pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaPartitionLevelConnectionHandler.java: ## @@ -56,6 +56,

Re: [PR] Add framework level support for segment operations level throttling for upsert and dedup [pinot]

2025-06-02 Thread via GitHub
codecov-commenter commented on PR #15973: URL: https://github.com/apache/pinot/pull/15973#issuecomment-2933420647 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15973?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch master updated: [timeseries] Introducing integration tests for time series engine (#15960)

2025-06-02 Thread ankitsultana
This is an automated email from the ASF dual-hosted git repository. ankitsultana pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 0c0281dbaf [timeseries] Introducing integra

Re: [PR] [timeseries] Introducing integration tests for time series engine [pinot]

2025-06-02 Thread via GitHub
ankitsultana merged PR #15960: URL: https://github.com/apache/pinot/pull/15960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] [multistage] Add Support for Broker Server/Segment Pruning [pinot]

2025-06-02 Thread via GitHub
ankitsultana commented on code in PR #15959: URL: https://github.com/apache/pinot/pull/15959#discussion_r2122602808 ## pinot-query-planner/src/main/java/org/apache/pinot/query/parser/CalciteRexExpressionParser.java: ## @@ -60,10 +60,10 @@ private CalciteRexExpressionParser() {

[PR] Add framework level support for segment operations level throttling for upsert and dedup [pinot]

2025-06-02 Thread via GitHub
somandal opened a new pull request, #15973: URL: https://github.com/apache/pinot/pull/15973 Updating the upsert / dedup primary keys on segment add or replace can be an expensive resource intensive operation. This PR adds framework level support for throttling this operation via the same me

Re: [PR] Add new ImplicitRealtimeTablePartitionSelector strategy for instance assignment [pinot]

2025-06-02 Thread via GitHub
yashmayya commented on code in PR #15930: URL: https://github.com/apache/pinot/pull/15930#discussion_r2122564948 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/ImplicitRealtimeTablePartitionSelector.java: ## @@ -0,0 +1,79 @@ +/** + *

(pinot) branch master updated: Fix PinotZKChanger HelixManager instance names (#15961)

2025-06-02 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 487daf07a9 Fix PinotZKChanger HelixManager ins

Re: [PR] Fix PinotZKChanger HelixManager instance names [pinot]

2025-06-02 Thread via GitHub
yashmayya merged PR #15961: URL: https://github.com/apache/pinot/pull/15961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

Re: [PR] [timeseries] Introducing integration tests for time series engine [pinot]

2025-06-02 Thread via GitHub
ankitsultana commented on code in PR #15960: URL: https://github.com/apache/pinot/pull/15960#discussion_r2122471794 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/TimeSeriesIntegrationTest.java: ## @@ -0,0 +1,306 @@ +/** + * Licensed to the Apache So

Re: [I] [multistage] Mailbox Content Observer Fails Silently when onNext Skipped [pinot]

2025-06-02 Thread via GitHub
ankitsultana commented on issue #15721: URL: https://github.com/apache/pinot/issues/15721#issuecomment-2932922929 There was no error reported to the user (except timeout). Frustratingly, for some reason we weren't seeing any logs in servers either and had to enable gRPC debug logs to root-c

Re: [PR] Spi gha test [pinot]

2025-06-02 Thread via GitHub
codecov-commenter commented on PR #15972: URL: https://github.com/apache/pinot/pull/15972#issuecomment-2932973011 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15972?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Move the SPI check to GHA and deprecate baseline jar [pinot]

2025-06-02 Thread via GitHub
codecov-commenter commented on PR #15971: URL: https://github.com/apache/pinot/pull/15971#issuecomment-2932911744 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15971?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Improving unit tests for MultiStageReplicaGroupSelector [pinot]

2025-06-02 Thread via GitHub
codecov-commenter commented on PR #15970: URL: https://github.com/apache/pinot/pull/15970#issuecomment-2932917254 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15970?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add new ImplicitRealtimeTablePartitionSelector strategy for instance assignment [pinot]

2025-06-02 Thread via GitHub
somandal commented on code in PR #15930: URL: https://github.com/apache/pinot/pull/15930#discussion_r2122351921 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/ImplicitRealtimeTablePartitionSelector.java: ## @@ -0,0 +1,79 @@ +/** + *

Re: [PR] Modify OFFLINE and REALTIME completed segments to calculate default partitionId based on same logic as consuming segments rather than 0 [pinot]

2025-06-02 Thread via GitHub
somandal commented on code in PR #15817: URL: https://github.com/apache/pinot/pull/15817#discussion_r2122281627 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1757,67 +1757,26 @@ private static class PartitionIdFet

[PR] Spi gha test [pinot]

2025-06-02 Thread via GitHub
leujean02 opened a new pull request, #15972: URL: https://github.com/apache/pinot/pull/15972 test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: co

Re: [PR] Spi gha test [pinot]

2025-06-02 Thread via GitHub
leujean02 closed pull request #15972: Spi gha test URL: https://github.com/apache/pinot/pull/15972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

(pinot) branch master updated: [multistage] Cleanup Plan Fragmenter Logic + Mailbox Receive Sort Fixes (#15943)

2025-06-02 Thread chrispeck
This is an automated email from the ASF dual-hosted git repository. chrispeck pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new ea9407819d [multistage] Cleanup Plan Fragmente

Re: [PR] Pinot Server : Refresh message for Table Schema [pinot]

2025-06-02 Thread via GitHub
codecov-commenter commented on PR #15956: URL: https://github.com/apache/pinot/pull/15956#issuecomment-2932902166 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15956?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Modify OFFLINE and REALTIME completed segments to calculate default partitionId based on same logic as consuming segments rather than 0 [pinot]

2025-06-02 Thread via GitHub
somandal commented on PR #15817: URL: https://github.com/apache/pinot/pull/15817#issuecomment-2932898997 @Jackie-Jiang updated testing results: REALTIME tables which don't use StrictRealtimeSegmentAssignment (using HybridQuickStart and with strictReplicaGroup instance selector enab

Re: [PR] [timeseries] Introducing integration tests for time series engine [pinot]

2025-06-02 Thread via GitHub
shauryachats commented on code in PR #15960: URL: https://github.com/apache/pinot/pull/15960#discussion_r2122219024 ## pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/ClusterTest.java: ## @@ -549,6 +551,31 @@ public JsonNode postQuery(@Language("sql"

Re: [PR] Move the SPI check to GHA and deprecate baseline jar [pinot]

2025-06-02 Thread via GitHub
leujean02 closed pull request #15971: Move the SPI check to GHA and deprecate baseline jar URL: https://github.com/apache/pinot/pull/15971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [I] [multistage] Mailbox Content Observer Fails Silently when onNext Skipped [pinot]

2025-06-02 Thread via GitHub
jadami10 commented on issue #15721: URL: https://github.com/apache/pinot/issues/15721#issuecomment-2932850302 > In our case the issue was occurring when the data transferred was exceeding the Mailbox max limit were you seeing that error as well, or you eventually root caused it to th

Re: [PR] Pinot Server : Refresh message for Table Schema [pinot]

2025-06-02 Thread via GitHub
praveenc7 commented on code in PR #15956: URL: https://github.com/apache/pinot/pull/15956#discussion_r215625 ## pinot-common/src/main/java/org/apache/pinot/common/messages/TableSchemaRefreshMessage.java: ## @@ -0,0 +1,54 @@ +/** + * Licensed to the Apache Software Foundation

[PR] Move the SPI check to GHA and deprecate baseline jar [pinot]

2025-06-02 Thread via GitHub
leujean02 opened a new pull request, #15971: URL: https://github.com/apache/pinot/pull/15971 [PINOT-20995](https://linkedin.atlassian.net/browse/PINOT-20995) Previously, we used Maven japicmp plugin and a checked-in baseline JAR to enforce SPI compatibility. This should fail builds wh

[PR] Improving unit tests for MultiStageReplicaGroupSelector [pinot]

2025-06-02 Thread via GitHub
shauryachats opened a new pull request, #15970: URL: https://github.com/apache/pinot/pull/15970 The previous unit tests for MultiStageReplicaGroupSelector were embedded within the InstanceSelectorTest class, resulting in significant code duplication between the two test suites. This

Re: [PR] Modify OFFLINE and REALTIME completed segments to calculate default partitionId based on same logic as consuming segments rather than 0 [pinot]

2025-06-02 Thread via GitHub
somandal commented on code in PR #15817: URL: https://github.com/apache/pinot/pull/15817#discussion_r2122281627 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1757,67 +1757,26 @@ private static class PartitionIdFet

Re: [PR] Add sanity checks to ensure write permissions for instance data and s… [pinot]

2025-06-02 Thread via GitHub
Jackie-Jiang merged PR #15876: URL: https://github.com/apache/pinot/pull/15876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: Add sanity checks to ensure write permissions for data dir (#15876)

2025-06-02 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new d40655cf05 Add sanity checks to ensure write perm

Re: [PR] Pinot Server : Refresh message for Table Schema [pinot]

2025-06-02 Thread via GitHub
Jackie-Jiang commented on code in PR #15956: URL: https://github.com/apache/pinot/pull/15956#discussion_r2122213266 ## pinot-common/src/main/java/org/apache/pinot/common/messages/TableSchemaRefreshMessage.java: ## @@ -0,0 +1,54 @@ +/** + * Licensed to the Apache Software Foundat

Re: [PR] Continue Segment Reset post instance errors [pinot]

2025-06-02 Thread via GitHub
Jackie-Jiang commented on code in PR #15903: URL: https://github.com/apache/pinot/pull/15903#discussion_r2122236799 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -2958,15 +2958,31 @@ public void resetSegment(String

Re: [PR] [multistage] Cleanup Plan Fragmenter Logic + Mailbox Receive Sort Fixes [pinot]

2025-06-02 Thread via GitHub
itschrispeck merged PR #15943: URL: https://github.com/apache/pinot/pull/15943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Handles server's rate limit config change without restart [pinot]

2025-06-02 Thread via GitHub
Jackie-Jiang commented on code in PR #15914: URL: https://github.com/apache/pinot/pull/15914#discussion_r215456 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeConsumptionRateManager.java: ## @@ -87,15 +87,25 @@ public ConsumptionRateLimiter

Re: [PR] Modify OFFLINE and REALTIME completed segments to calculate default partitionId based on same logic as consuming segments rather than 0 [pinot]

2025-06-02 Thread via GitHub
somandal commented on code in PR #15817: URL: https://github.com/apache/pinot/pull/15817#discussion_r218140 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -1757,67 +1767,26 @@ private static class PartitionIdFet

Re: [PR] Modify OFFLINE and REALTIME completed segments to calculate default partitionId based on same logic as consuming segments rather than 0 [pinot]

2025-06-02 Thread via GitHub
Jackie-Jiang commented on code in PR #15817: URL: https://github.com/apache/pinot/pull/15817#discussion_r2122196601 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -542,9 +542,19 @@ private RebalanceResult doRebalanc

Re: [PR] Modify OFFLINE and REALTIME completed segments to calculate default partitionId based on same logic as consuming segments rather than 0 [pinot]

2025-06-02 Thread via GitHub
Jackie-Jiang commented on code in PR #15817: URL: https://github.com/apache/pinot/pull/15817#discussion_r2122191645 ## pinot-common/src/main/java/org/apache/pinot/common/utils/SegmentUtils.java: ## @@ -33,38 +34,42 @@ public class SegmentUtils { private SegmentUtils() { }

Re: [PR] Modify OFFLINE and REALTIME completed segments to calculate default partitionId based on same logic as consuming segments rather than 0 [pinot]

2025-06-02 Thread via GitHub
Jackie-Jiang commented on code in PR #15817: URL: https://github.com/apache/pinot/pull/15817#discussion_r2122176340 ## pinot-common/src/main/java/org/apache/pinot/common/utils/SegmentUtils.java: ## @@ -76,25 +81,61 @@ public static Integer getPartitionIdFromRealtimeSegmentName(

Re: [PR] [Minor] Fix merge conflict introduced in #15203 [pinot]

2025-06-02 Thread via GitHub
Jackie-Jiang merged PR #15969: URL: https://github.com/apache/pinot/pull/15969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (6b475b7d4b -> 799adb9ebf)

2025-06-02 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 6b475b7d4b Fix GROUP BY-Only Processing with accurateGroupByWithoutOrderBy (#15966) add 799adb9ebf Fix merge conf

Re: [PR] [Minor] Fix merge conflict introduced in #15203 [pinot]

2025-06-02 Thread via GitHub
codecov-commenter commented on PR #15969: URL: https://github.com/apache/pinot/pull/15969#issuecomment-2932480376 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15969?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [I] [multistage] Mailbox Content Observer Fails Silently when onNext Skipped [pinot]

2025-06-02 Thread via GitHub
ankitsultana commented on issue #15721: URL: https://github.com/apache/pinot/issues/15721#issuecomment-2931327252 In our case the issue was occurring when the data transferred was exceeding the Mailbox max limit. We had mitigated it by increasing our mailbox size limit to a higher threshold

[PR] [MinorFix merge conflict introduced in #15203 [pinot]

2025-06-02 Thread via GitHub
Jackie-Jiang opened a new pull request, #15969: URL: https://github.com/apache/pinot/pull/15969 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Reduce reflection overhead of ByteBufferUtil::newDirectByteBuffer [pinot]

2025-06-02 Thread via GitHub
dinoocch commented on PR #15878: URL: https://github.com/apache/pinot/pull/15878#issuecomment-2932360353 This is the patch I had used to validate performance -- [benchmark.patch](https://github.com/user-attachments/files/20558502/benchmark.patch) -- This is an automated message

[PR] Invalidate from cache the stats of opchains that finish successfully. [pinot]

2025-06-02 Thread via GitHub
gortiz opened a new pull request, #15967: URL: https://github.com/apache/pinot/pull/15967 We have detected that some large queries may end up consuming too much memory for too long in the stats cache used to return stats on timeout. A way to solve that is to remove the stats as soon a

Re: [PR] Add new ImplicitRealtimeTablePartitionSelector strategy for instance assignment [pinot]

2025-06-02 Thread via GitHub
Jackie-Jiang commented on code in PR #15930: URL: https://github.com/apache/pinot/pull/15930#discussion_r2121940763 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/ImplicitRealtimeTablePartitionSelector.java: ## @@ -0,0 +1,79 @@ +/**

Re: [PR] Reduce reflection overhead of ByteBufferUtil::newDirectByteBuffer [pinot]

2025-06-02 Thread via GitHub
dinoocch commented on PR #15878: URL: https://github.com/apache/pinot/pull/15878#issuecomment-2932298227 > I'm not sure if I correctly understood your case. pinot.offheap.prioritize.bytebuffer defaults to true. Are you changing it to false? Or were you using false and now you are trying to

[PR] Single text index [pinot]

2025-06-02 Thread via GitHub
xiangfu0 opened a new pull request, #15968: URL: https://github.com/apache/pinot/pull/15968 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Add `maxBytesSize` config to limit mutable json index heap usage [pinot]

2025-06-02 Thread via GitHub
chenboat merged PR #15685: URL: https://github.com/apache/pinot/pull/15685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Fix GROUP BY-Only Processing with accurateGroupByWithoutOrderBy [pinot]

2025-06-02 Thread via GitHub
Jackie-Jiang merged PR #15966: URL: https://github.com/apache/pinot/pull/15966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: Fix GROUP BY-Only Processing with accurateGroupByWithoutOrderBy (#15966)

2025-06-02 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 6b475b7d4b Fix GROUP BY-Only Processing with acc

Re: [PR] Bump spark2.version from 2.4.8 to 3.5.6 [pinot]

2025-06-02 Thread via GitHub
dependabot[bot] commented on PR #15963: URL: https://github.com/apache/pinot/pull/15963#issuecomment-2932082383 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by

Re: [PR] Bump org.glassfish.jersey:jersey-bom from 2.46 to 3.1.10 [pinot]

2025-06-02 Thread via GitHub
dependabot[bot] commented on PR #15962: URL: https://github.com/apache/pinot/pull/15962#issuecomment-2932079436 OK, I won't notify you about version 3.x.x again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Bump spark2.version from 2.4.8 to 3.5.6 [pinot]

2025-06-02 Thread via GitHub
Jackie-Jiang closed pull request #15963: Bump spark2.version from 2.4.8 to 3.5.6 URL: https://github.com/apache/pinot/pull/15963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Bump org.glassfish.jersey:jersey-bom from 2.46 to 3.1.10 [pinot]

2025-06-02 Thread via GitHub
dependabot[bot] closed pull request #15962: Bump org.glassfish.jersey:jersey-bom from 2.46 to 3.1.10 URL: https://github.com/apache/pinot/pull/15962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

(pinot) branch dependabot/maven/org.glassfish.jersey-jersey-bom-3.1.10 deleted (was 50ac11fdac)

2025-06-02 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.glassfish.jersey-jersey-bom-3.1.10 in repository https://gitbox.apache.org/repos/asf/pinot.git was 50ac11fdac Bump org.glassfish.jersey:jersey-bom from 2.46 to 3.1.

Re: [PR] [timeseries] Introducing integration tests for time series engine [pinot]

2025-06-02 Thread via GitHub
ankitsultana commented on code in PR #15960: URL: https://github.com/apache/pinot/pull/15960#discussion_r2121953481 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/TimeSeriesIntegrationTest.java: ## @@ -0,0 +1,306 @@ +/** + * Licensed to the Apache So

Re: [PR] Always use segment partition id as stream partition id for single stream [pinot]

2025-06-02 Thread via GitHub
Jackie-Jiang commented on code in PR #15957: URL: https://github.com/apache/pinot/pull/15957#discussion_r2121966562 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -1620,9 +1620,20 @@ public RealtimeSegmentDataManage

Re: [PR] Always use segment partition id as stream partition id for single stream [pinot]

2025-06-02 Thread via GitHub
Jackie-Jiang commented on code in PR #15957: URL: https://github.com/apache/pinot/pull/15957#discussion_r2121965680 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -276,20 +276,47 @@ public List getPar

(pinot) branch dependabot/maven/spark2.version-3.5.6 deleted (was 12585c85f7)

2025-06-02 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/spark2.version-3.5.6 in repository https://gitbox.apache.org/repos/asf/pinot.git was 12585c85f7 Bump spark2.version from 2.4.8 to 3.5.6 The revisions that were on this

Re: [PR] Bump org.glassfish.jersey:jersey-bom from 2.46 to 3.1.10 [pinot]

2025-06-02 Thread via GitHub
Jackie-Jiang commented on PR #15962: URL: https://github.com/apache/pinot/pull/15962#issuecomment-2932079294 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Invalidate from cache the stats of opchains that finish successfully. [pinot]

2025-06-02 Thread via GitHub
ankitsultana commented on PR #15967: URL: https://github.com/apache/pinot/pull/15967#issuecomment-2931649778 @gortiz : how long running were the queries that caused this? (what was their configured timeout) -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] [Priority Replica Group Routing] Support orderedPreferredReplicas query option for customizable routing strategy [pinot]

2025-06-02 Thread via GitHub
chenboat merged PR #15203: URL: https://github.com/apache/pinot/pull/15203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Bump com.puppycrawl.tools:checkstyle from 10.24.0 to 10.25.0 [pinot]

2025-06-02 Thread via GitHub
yashmayya merged PR #15965: URL: https://github.com/apache/pinot/pull/15965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

(pinot) branch master updated (bc8d78660b -> db2f78c853)

2025-06-02 Thread tingchen
This is an automated email from the ASF dual-hosted git repository. tingchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from bc8d78660b Bump software.amazon.awssdk:bom from 2.31.53 to 2.31.54 (#15964) add db2f78c853 [Priority Replica Gr

(pinot) branch master updated (db2f78c853 -> ff5a750af9)

2025-06-02 Thread tingchen
This is an automated email from the ASF dual-hosted git repository. tingchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from db2f78c853 [Priority Replica Group Routing] Support orderedPreferredReplicas query option for customizable routing s

Re: [I] [multistage] Mailbox Content Observer Fails Silently when onNext Skipped [pinot]

2025-06-02 Thread via GitHub
gortiz commented on issue #15721: URL: https://github.com/apache/pinot/issues/15721#issuecomment-2931344380 > In our case the issue was occurring when the data transferred was exceeding the Mailbox max limit. We had mitigated it by increasing our mailbox size limit to a higher threshold.

Re: [PR] Modify OFFLINE and REALTIME completed segments to calculate default partitionId based on same logic as consuming segments rather than 0 [pinot]

2025-06-02 Thread via GitHub
somandal commented on code in PR #15817: URL: https://github.com/apache/pinot/pull/15817#discussion_r2121806445 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -542,9 +542,19 @@ private RebalanceResult doRebalance(Ta

Re: [PR] Invalidate from cache the stats of opchains that finish successfully. [pinot]

2025-06-02 Thread via GitHub
codecov-commenter commented on PR #15967: URL: https://github.com/apache/pinot/pull/15967#issuecomment-2931740345 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15967?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] MSE error management improvements [pinot]

2025-06-02 Thread via GitHub
gortiz commented on code in PR #15919: URL: https://github.com/apache/pinot/pull/15919#discussion_r2121033175 ## pinot-common/src/main/java/org/apache/pinot/common/datablock/MetadataBlock.java: ## @@ -48,16 +49,17 @@ public static MetadataBlock newEos() { return new Metadat

Re: [PR] Add new ImplicitRealtimeTablePartitionSelector strategy for instance assignment [pinot]

2025-06-02 Thread via GitHub
somandal commented on code in PR #15930: URL: https://github.com/apache/pinot/pull/15930#discussion_r2121794505 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/ImplicitRealtimeTablePartitionSelector.java: ## @@ -0,0 +1,79 @@ +/** + *

Re: [PR] Add new ImplicitRealtimeTablePartitionSelector strategy for instance assignment [pinot]

2025-06-02 Thread via GitHub
somandal commented on code in PR #15930: URL: https://github.com/apache/pinot/pull/15930#discussion_r2121790729 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/ImplicitRealtimeTablePartitionSelector.java: ## @@ -0,0 +1,79 @@ +/** + *

Re: [PR] Add new ImplicitRealtimeTablePartitionSelector strategy for instance assignment [pinot]

2025-06-02 Thread via GitHub
somandal commented on code in PR #15930: URL: https://github.com/apache/pinot/pull/15930#discussion_r2121769760 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java: ## @@ -913,6 +914,25 @@ static void validatePartitionedReplicaGroupIn

Re: [I] Support Gorilla encoding (Delta of Delta, XOR) Compression Codec [pinot]

2025-06-02 Thread via GitHub
deemoliu commented on issue #15913: URL: https://github.com/apache/pinot/issues/15913#issuecomment-2931705248 WIP https://github.com/apache/pinot/pull/15258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Add new ImplicitRealtimeTablePartitionSelector strategy for instance assignment [pinot]

2025-06-02 Thread via GitHub
yashmayya commented on code in PR #15930: URL: https://github.com/apache/pinot/pull/15930#discussion_r2121729101 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/ImplicitRealtimeTablePartitionSelector.java: ## @@ -0,0 +1,79 @@ +/** + *

(pinot) branch master updated (1027b97a97 -> bc8d78660b)

2025-06-02 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 1027b97a97 Bump com.puppycrawl.tools:checkstyle from 10.24.0 to 10.25.0 (#15965) add bc8d78660b Bump software.

Re: [PR] Add new ImplicitRealtimeTablePartitionSelector strategy for instance assignment [pinot]

2025-06-02 Thread via GitHub
yashmayya commented on code in PR #15930: URL: https://github.com/apache/pinot/pull/15930#discussion_r2121729101 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/ImplicitRealtimeTablePartitionSelector.java: ## @@ -0,0 +1,79 @@ +/** + *

Re: [PR] Add new ImplicitRealtimeTablePartitionSelector strategy for instance assignment [pinot]

2025-06-02 Thread via GitHub
yashmayya commented on code in PR #15930: URL: https://github.com/apache/pinot/pull/15930#discussion_r2121709430 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/ImplicitRealtimeTablePartitionSelector.java: ## @@ -0,0 +1,79 @@ +/** + *

Re: [PR] (minor) Follow up fix for : https://github.com/apache/pinot/pull/15844 [pinot]

2025-06-02 Thread via GitHub
codecov-commenter commented on PR #15966: URL: https://github.com/apache/pinot/pull/15966#issuecomment-2931607823 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15966?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Schema and table config deletion to validate with logical table ref table names [pinot]

2025-06-02 Thread via GitHub
Copilot commented on code in PR #15900: URL: https://github.com/apache/pinot/pull/15900#discussion_r2121652672 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -466,6 +470,23 @@ private boolean verifyTableType(Stri

Re: [PR] Add new ImplicitRealtimeTablePartitionSelector strategy for instance assignment [pinot]

2025-06-02 Thread via GitHub
somandal commented on code in PR #15930: URL: https://github.com/apache/pinot/pull/15930#discussion_r2121614980 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java: ## @@ -913,6 +914,25 @@ static void validatePartitionedReplicaGroupIn

[PR] (minor) Follow up fix for : https://github.com/apache/pinot/pull/15844 [pinot]

2025-06-02 Thread via GitHub
anandheritage opened a new pull request, #15966: URL: https://github.com/apache/pinot/pull/15966 When a segment’s map had already reached _resultSize, and a row arrived whose key was exactly equal to map.lastKey(), the condition key.compareTo(map.lastKey()) < 0 would evaluate to false, caus

Re: [PR] Schema and table config deletion to validate with logical table ref table names [pinot]

2025-06-02 Thread via GitHub
abhishekbafna commented on code in PR #15900: URL: https://github.com/apache/pinot/pull/15900#discussion_r2121576970 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -422,6 +423,19 @@ public SuccessResponse deleteT

Re: [PR] Bump software.amazon.awssdk:bom from 2.31.53 to 2.31.54 [pinot]

2025-06-02 Thread via GitHub
yashmayya merged PR #15964: URL: https://github.com/apache/pinot/pull/15964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

(pinot) branch master updated (ff68c1f9a7 -> 1027b97a97)

2025-06-02 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from ff68c1f9a7 Bump org.glassfish.jersey:jersey-bom from 2.45 to 2.46 (#15947) add 1027b97a97 Bump com.puppycrawl.

Re: [PR] [Query Resource Isolation] WorkloadBudgetManager and Host enforcement [pinot]

2025-06-02 Thread via GitHub
vrajat commented on code in PR #15798: URL: https://github.com/apache/pinot/pull/15798#discussion_r2121359503 ## pinot-spi/src/main/java/org/apache/pinot/spi/trace/Tracing.java: ## @@ -203,18 +204,20 @@ public void sampleUsageMSE() { } @Override -public void upda

Re: [PR] Refactor authorization code to reduce duplication and inconsistency [pinot]

2025-06-02 Thread via GitHub
NihalJain commented on PR #15861: URL: https://github.com/apache/pinot/pull/15861#issuecomment-2930978998 > The refactor definitely reduces duplicate code by > > * Moving part of the common code to `BasicAuthUtils.java`. > > * Moving other parts to respective base classes.

Re: [I] [multistage] Mailbox Content Observer Fails Silently when onNext Skipped [pinot]

2025-06-02 Thread via GitHub
jadami10 commented on issue #15721: URL: https://github.com/apache/pinot/issues/15721#issuecomment-2930987749 @ankitsultana, have you been able to reproduce this yourself? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [I] Deprecate Native Text Index [pinot]

2025-06-02 Thread via GitHub
hpvd commented on issue #15855: URL: https://github.com/apache/pinot/issues/15855#issuecomment-2930574492 just one thoughts: maybe it would be a good move to couple the deprecation of this native text index at the full future proof integration of lucene. Currently, with only having the

Re: [PR] MSE error management improvements [pinot]

2025-06-02 Thread via GitHub
gortiz commented on code in PR #15919: URL: https://github.com/apache/pinot/pull/15919#discussion_r2121035156 ## pinot-spi/src/main/java/org/apache/pinot/spi/query/QueryThreadContext.java: ## @@ -415,6 +429,18 @@ public static void setQueryEngine(String queryEngine) { get()

Re: [PR] MSE error management improvements [pinot]

2025-06-02 Thread via GitHub
gortiz commented on code in PR #15919: URL: https://github.com/apache/pinot/pull/15919#discussion_r2121033671 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/ErrorMseBlock.java: ## @@ -24,43 +24,75 @@ import java.util.Collections; import java.util.En

[PR] Bump com.puppycrawl.tools:checkstyle from 10.24.0 to 10.25.0 [pinot]

2025-06-02 Thread via GitHub
dependabot[bot] opened a new pull request, #15965: URL: https://github.com/apache/pinot/pull/15965 Bumps [com.puppycrawl.tools:checkstyle](https://github.com/checkstyle/checkstyle) from 10.24.0 to 10.25.0. Release notes Sourced from https://github.com/checkstyle/checkstyle/release

[PR] Bump software.amazon.awssdk:bom from 2.31.53 to 2.31.54 [pinot]

2025-06-02 Thread via GitHub
dependabot[bot] opened a new pull request, #15964: URL: https://github.com/apache/pinot/pull/15964 Bumps software.amazon.awssdk:bom from 2.31.53 to 2.31.54. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- |

[PR] Bump spark2.version from 2.4.8 to 3.5.6 [pinot]

2025-06-02 Thread via GitHub
dependabot[bot] opened a new pull request, #15963: URL: https://github.com/apache/pinot/pull/15963 Bumps `spark2.version` from 2.4.8 to 3.5.6. Updates `org.apache.spark:spark-core_2.12` from 2.4.8 to 3.5.6 Updates `org.apache.spark:spark-sql_2.12` from 2.4.8 to 3.5.6 Depe

[PR] Bump org.glassfish.jersey:jersey-bom from 2.46 to 3.1.10 [pinot]

2025-06-02 Thread via GitHub
dependabot[bot] opened a new pull request, #15962: URL: https://github.com/apache/pinot/pull/15962 Bumps org.glassfish.jersey:jersey-bom from 2.46 to 3.1.10. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.g

  1   2   >