ankitsultana commented on code in PR #15959:
URL: https://github.com/apache/pinot/pull/15959#discussion_r2122602808


##########
pinot-query-planner/src/main/java/org/apache/pinot/query/parser/CalciteRexExpressionParser.java:
##########
@@ -60,10 +60,10 @@ private CalciteRexExpressionParser() {
   // Relational conversion Utils
   // --------------------------------------------------------------------------
 
-  public static List<Expression> convertRexNodes(List<RexExpression> rexNodes, 
PinotQuery pinotQuery) {
+  public static List<Expression> convertRexNodes(List<RexExpression> rexNodes, 
List<Expression> selectList) {

Review Comment:
   simplifying this code. It was taking in a wider object than required. Only 
access to the selectList was required



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to