suddendust commented on code in PR #15857:
URL: https://github.com/apache/pinot/pull/15857#discussion_r2103917615
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##
@@ -893,6 +897,24 @@ private CompileResult compileR
NihalJain commented on code in PR #15876:
URL: https://github.com/apache/pinot/pull/15876#discussion_r2103873308
##
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java:
##
@@ -186,6 +186,22 @@ private void initInstanceDataDir(File insta
NihalJain commented on PR #15876:
URL: https://github.com/apache/pinot/pull/15876#issuecomment-2903373979
> Thanks for the contribution!
Thank you @Jackie-Jiang for the quick review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
tarun11Mavani commented on issue #15846:
URL: https://github.com/apache/pinot/issues/15846#issuecomment-2903300185
> What is the difference between the proposed solution vs the existing
behavior?
>
> Can we use the creation time set by the controller when the CONSUMING
segment is cre
deepthi912 commented on code in PR #15829:
URL: https://github.com/apache/pinot/pull/15829#discussion_r2103623253
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##
@@ -3860,7 +3862,9 @@ private String updateSegmentTargetT
raghavyadav01 opened a new pull request, #15879:
URL: https://github.com/apache/pinot/pull/15879
update the Baseline jars for japicmp plugin to fix the build failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
deepthi912 commented on code in PR #15829:
URL: https://github.com/apache/pinot/pull/15829#discussion_r2103623253
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##
@@ -3860,7 +3862,9 @@ private String updateSegmentTargetT
deepthi912 commented on code in PR #15829:
URL: https://github.com/apache/pinot/pull/15829#discussion_r2103623253
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##
@@ -3860,7 +3862,9 @@ private String updateSegmentTargetT
deepthi912 commented on code in PR #15829:
URL: https://github.com/apache/pinot/pull/15829#discussion_r2103623253
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##
@@ -3860,7 +3862,9 @@ private String updateSegmentTargetT
deepthi912 commented on code in PR #15829:
URL: https://github.com/apache/pinot/pull/15829#discussion_r2103623253
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##
@@ -3860,7 +3862,9 @@ private String updateSegmentTargetT
Jackie-Jiang commented on code in PR #15844:
URL: https://github.com/apache/pinot/pull/15844#discussion_r2103609302
##
pinot-core/src/main/java/org/apache/pinot/core/data/table/Key.java:
##
@@ -63,4 +63,14 @@ public int hashCode() {
public String toString() {
return Arra
Jackie-Jiang commented on code in PR #15844:
URL: https://github.com/apache/pinot/pull/15844#discussion_r2103603013
##
pinot-core/src/main/java/org/apache/pinot/core/data/table/DeterministicConcurrentIndexedTable.java:
##
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Software
Jackie-Jiang merged PR #15869:
URL: https://github.com/apache/pinot/pull/15869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on code in PR #15870:
URL: https://github.com/apache/pinot/pull/15870#discussion_r2103599233
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##
@@ -559,8 +559,9 @@ public ServerReloadControllerJ
codecov-commenter commented on PR #15878:
URL: https://github.com/apache/pinot/pull/15878#issuecomment-2902931720
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15878?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 41f90f9ef8 Add APIs to IndexSegment as a preparat
Jackie-Jiang commented on code in PR #15869:
URL: https://github.com/apache/pinot/pull/15869#discussion_r2103594241
##
pinot-core/src/test/java/org/apache/pinot/core/plan/maker/QueryOverrideWithHintsTest.java:
##
@@ -37,82 +33,26 @@
import org.apache.pinot.core.query.request.co
Jackie-Jiang commented on code in PR #15869:
URL: https://github.com/apache/pinot/pull/15869#discussion_r2103593149
##
pinot-core/src/main/java/org/apache/pinot/core/query/executor/SingleTableExecutionInfo.java:
##
@@ -151,18 +152,18 @@ private SingleTableExecutionInfo(TableData
Jackie-Jiang commented on issue #15855:
URL: https://github.com/apache/pinot/issues/15855#issuecomment-2902917977
In the [Native Text
Index](https://docs.pinot.apache.org/basics/indexing/native-text-index) doc, it
has been marked experimental and should not be used in production since relea
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 0ee7a52f48 Changes to Enable Pluggable forward In
Jackie-Jiang merged PR #15526:
URL: https://github.com/apache/pinot/pull/15526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on code in PR #15876:
URL: https://github.com/apache/pinot/pull/15876#discussion_r2103571745
##
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java:
##
@@ -186,6 +186,22 @@ private void initInstanceDataDir(File in
dinoocch opened a new pull request, #15878:
URL: https://github.com/apache/pinot/pull/15878
We found a fairly substantial performance regression on one usecase when
migrating to set `pinot.offheap.prioritize.bytebuffer -> true`.
https://github.com/user-attachments/assets/cc928e5b-f300
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 20b557db44 Modify primitive lookup tables to acce
Jackie-Jiang merged PR #15848:
URL: https://github.com/apache/pinot/pull/15848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
vvivekiyer commented on code in PR #15109:
URL: https://github.com/apache/pinot/pull/15109#discussion_r2103334634
##
pinot-spi/src/main/java/org/apache/pinot/spi/config/workload/QueryWorkloadConfig.java:
##
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache Software Foundation (AS
Jackie-Jiang commented on PR #15799:
URL: https://github.com/apache/pinot/pull/15799#issuecomment-2902593363
> > Can we restrict the japicmp check to only run in the linter test?
Currently it is very strict, and prevent tests from running. Apache Pinot is
not mature enough to claim no SPI c
Jackie-Jiang commented on code in PR #15526:
URL: https://github.com/apache/pinot/pull/15526#discussion_r2103407592
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/json/ImmutableJsonIndexReader.java:
##
@@ -120,15 +120,22 @@ public Immut
codecov-commenter commented on PR #15876:
URL: https://github.com/apache/pinot/pull/15876#issuecomment-2902513853
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15876?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
raghavyadav01 commented on code in PR #15526:
URL: https://github.com/apache/pinot/pull/15526#discussion_r2103359873
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/map/ImmutableMapDataSource.java:
##
@@ -41,15 +41,12 @@ public class ImmutableMa
NihalJain commented on code in PR #15876:
URL: https://github.com/apache/pinot/pull/15876#discussion_r2103352680
##
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java:
##
@@ -186,6 +186,22 @@ private void initInstanceDataDir(File insta
UOETianleZhang commented on PR #15799:
URL: https://github.com/apache/pinot/pull/15799#issuecomment-2902443997
> Can we restrict the japicmp check to only run in the linter test?
Currently it is very strict, and prevent tests from running. Apache Pinot is
not mature enough to claim no SPI c
ankitsultana commented on PR #15445:
URL: https://github.com/apache/pinot/pull/15445#issuecomment-2902456350
Ack. thanks for flagging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Jackie-Jiang merged PR #15873:
URL: https://github.com/apache/pinot/pull/15873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/com.puppycrawl.tools-checkstyle-10.24.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 66c4415892 Bump com.puppycrawl.tools:checkstyle from 10.23.1 to 10.2
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new cba1f2251f Bump org.jline:jline from 3.30.2 to 3.
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from cba1f2251f Bump org.jline:jline from 3.30.2 to 3.30.3 (#15873)
add 9cdda60e91 Bump software.amazon.awssdk:bom from
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch dependabot/maven/org.jline-jline-3.30.3
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 57b1de5276 Bump org.jline:jline from 3.30.2 to 3.30.3
The revisions that were on this
Jackie-Jiang merged PR #15872:
URL: https://github.com/apache/pinot/pull/15872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.31.48
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 108be7b651 Bump software.amazon.awssdk:bom from 2.31.46 to 2.31.48
The r
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new f7cc5e53e3 Bump com.puppycrawl.tools:checkstyle f
dependabot[bot] commented on PR #15875:
URL: https://github.com/apache/pinot/pull/15875#issuecomment-2902415093
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a dependency by
Jackie-Jiang closed pull request #15875: Bump kafka2.version from 2.8.2 to 3.9.1
URL: https://github.com/apache/pinot/pull/15875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Jackie-Jiang merged PR #15874:
URL: https://github.com/apache/pinot/pull/15874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/kafka2.version-3.9.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
was d49c794b37 Bump kafka2.version from 2.8.2 to 3.9.1
The revisions that were on this
NihalJain opened a new issue, #15877:
URL: https://github.com/apache/pinot/issues/15877
Users who are non admin are not allowed/or able to to login to UI, ideally
users should at least have access to query console page!
--
This is an automated message from the Apache Git Service.
To respo
NihalJain commented on code in PR #15876:
URL: https://github.com/apache/pinot/pull/15876#discussion_r2103303661
##
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java:
##
@@ -186,6 +184,21 @@ private void initInstanceDataDir(File insta
NihalJain commented on code in PR #15876:
URL: https://github.com/apache/pinot/pull/15876#discussion_r2103299309
##
pinot-server/src/test/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManagerTest.java:
##
@@ -0,0 +1,119 @@
+/**
+ * Licensed to the Apache Software F
NihalJain commented on PR #15876:
URL: https://github.com/apache/pinot/pull/15876#issuecomment-2902290104
Built Pinot locally and tested the patch by running the failing scenario as
follows:
1. Create `dataDir` and `segmentDir` directories with incorrect permissions
```
mkdi
NihalJain opened a new pull request, #15876:
URL: https://github.com/apache/pinot/pull/15876
…egment tar directories (#15860)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
Jackie-Jiang commented on PR #15799:
URL: https://github.com/apache/pinot/pull/15799#issuecomment-2902263187
Can we restrict the japicmp check to only run in the linter test? Currently
it is very strict, and prevent tests from running. Apache Pinot is not mature
enough to claim no SPI chang
UOETianleZhang commented on PR #15799:
URL: https://github.com/apache/pinot/pull/15799#issuecomment-2902185372
> > I do agree with the general intention, beyond the config package
discussed here I personally don't see many other exception cases.
> > My concern is that for actively develop
NihalJain commented on issue #15860:
URL: https://github.com/apache/pinot/issues/15860#issuecomment-2902171612
So I was trying to reproduce this issue.
- Created a data directory with 700 permission
- Created data/index with 400 permission
- Created data/segmentTar with 400 permi
l3002 commented on issue #15771:
URL: https://github.com/apache/pinot/issues/15771#issuecomment-2902130991
hi @tarun11Mavani, Thanks. I'm only getting started with the project and
would need some time to get familiar with the codebase. Do let me know if you
have any suggestions on how I sho
siddharthteotia merged PR #15868:
URL: https://github.com/apache/pinot/pull/15868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pi
This is an automated email from the ASF dual-hosted git repository.
siddteotia pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from b061c555a4 Direct mse query server (#15445)
add f0c9638a0e Migrating broker.api.RequesterIdentity and
server.
raghavyadav01 commented on code in PR #15526:
URL: https://github.com/apache/pinot/pull/15526#discussion_r2103035827
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/MapFieldTypeTest.java:
##
@@ -38,14 +40,15 @@
import org.testng.annotations.Te
vrajat commented on code in PR #15839:
URL: https://github.com/apache/pinot/pull/15839#discussion_r2102908986
##
pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java:
##
@@ -175,6 +176,20 @@ public void processClusterChange(H
vrajat commented on code in PR #15862:
URL: https://github.com/apache/pinot/pull/15862#discussion_r2102876342
##
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BrokerResourceOnlineOfflineStateModelFactory.java:
##
@@ -97,14 +97,19 @@ public void onBecomeOnlineFr
anandheritage commented on PR #15844:
URL: https://github.com/apache/pinot/pull/15844#issuecomment-2901716376
> It'll be good if you can share some perf number comparing this new
`IndexedTable` with the existing one
Benchmark Mode C
shounakmk219 commented on code in PR #15839:
URL: https://github.com/apache/pinot/pull/15839#discussion_r2102833410
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##
@@ -406,7 +406,7 @@ protected BrokerResponse doHa
anandheritage commented on code in PR #15844:
URL: https://github.com/apache/pinot/pull/15844#discussion_r2102845051
##
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java:
##
@@ -275,6 +275,17 @@ public ExplainMode getExplain() {
return _
hpvd commented on issue #15819:
URL: https://github.com/apache/pinot/issues/15819#issuecomment-2901310337
POC: https://github.com/apache/pinot/pull/15857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
gortiz commented on code in PR #15848:
URL: https://github.com/apache/pinot/pull/15848#discussion_r2102462802
##
pinot-query-runtime/src/test/resources/queries/NullHandling.json:
##
@@ -64,6 +64,26 @@
"description": "LEFT JOIN and GROUP BY with AGGREGATE AND SORT",
gortiz commented on code in PR #15848:
URL: https://github.com/apache/pinot/pull/15848#discussion_r2102424583
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/join/PrimitiveLookupTable.java:
##
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Softwar
This is an automated email from the ASF dual-hosted git repository.
gortiz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new b061c555a4 Direct mse query server (#15445)
b061c
gortiz commented on PR #15445:
URL: https://github.com/apache/pinot/pull/15445#issuecomment-2900986743
cc @ankitsultana I've made some changes in the way TSE requests are
received. AFAIK there should be no actual behavior changes, but please take a
look in case you find something odd.
--
gortiz merged PR #15445:
URL: https://github.com/apache/pinot/pull/15445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
dependabot[bot] commented on PR #15866:
URL: https://github.com/apache/pinot/pull/15866#issuecomment-2900914115
Superseded by #15872.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] opened a new pull request, #15874:
URL: https://github.com/apache/pinot/pull/15874
Bumps
[com.puppycrawl.tools:checkstyle](https://github.com/checkstyle/checkstyle)
from 10.23.1 to 10.24.0.
Release notes
Sourced from https://github.com/checkstyle/checkstyle/release
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.31.47
in repository https://gitbox.apache.org/repos/asf/pinot.git
was f266df6d08 Bump software.amazon.awssdk:bom from 2.31.46 to 2.31.47
T
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/org.jline-jline-3.30.3
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 57b1de5276 Bump org.jline:jline from 3.30.2 to 3.30.3
No new revisions were added
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.31.48
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 108be7b651 Bump software.amazon.awssdk:bom from 2.31.46 to 2.31.48
N
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/kafka2.version-3.9.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
at d49c794b37 Bump kafka2.version from 2.8.2 to 3.9.1
No new revisions were added by t
dependabot[bot] opened a new pull request, #15875:
URL: https://github.com/apache/pinot/pull/15875
Bumps `kafka2.version` from 2.8.2 to 3.9.1.
Updates `org.apache.kafka:kafka-clients` from 2.8.2 to 3.9.1
Updates `org.apache.kafka:kafka_2.12` from 2.8.2 to 3.9.1
Dependabot
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.puppycrawl.tools-checkstyle-10.24.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 66c4415892 Bump com.puppycrawl.tools:checkstyle from 10.23.1 to
dependabot[bot] closed pull request #15866: Bump software.amazon.awssdk:bom
from 2.31.46 to 2.31.47
URL: https://github.com/apache/pinot/pull/15866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
dependabot[bot] opened a new pull request, #15873:
URL: https://github.com/apache/pinot/pull/15873
Bumps [org.jline:jline](https://github.com/jline/jline3) from 3.30.2 to
3.30.3.
Release notes
Sourced from https://github.com/jline/jline3/releases";>org.jline:jline's
releases.
dependabot[bot] opened a new pull request, #15872:
URL: https://github.com/apache/pinot/pull/15872
Bumps software.amazon.awssdk:bom from 2.31.46 to 2.31.48.
Most Recent Ignore Conditions Applied to This Pull Request
| Dependency Name | Ignore Conditions |
| --- | --- |
gortiz commented on code in PR #15445:
URL: https://github.com/apache/pinot/pull/15445#discussion_r2101908193
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/server/QueryServer.java:
##
@@ -81,7 +79,8 @@ public class QueryServer extends
PinotQueryWorkerGrpc.
gortiz commented on code in PR #15445:
URL: https://github.com/apache/pinot/pull/15445#discussion_r2101907466
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/server/QueryServer.java:
##
@@ -142,14 +152,20 @@ public void shutdown() {
_server.shutdown(
gortiz commented on code in PR #15869:
URL: https://github.com/apache/pinot/pull/15869#discussion_r2101979544
##
pinot-core/src/test/java/org/apache/pinot/core/plan/maker/QueryOverrideWithHintsTest.java:
##
@@ -37,82 +33,26 @@
import org.apache.pinot.core.query.request.context.
gortiz commented on code in PR #15869:
URL: https://github.com/apache/pinot/pull/15869#discussion_r2101973635
##
pinot-core/src/main/java/org/apache/pinot/core/query/executor/SingleTableExecutionInfo.java:
##
@@ -151,18 +152,18 @@ private SingleTableExecutionInfo(TableDataManage
vrajat commented on code in PR #15857:
URL: https://github.com/apache/pinot/pull/15857#discussion_r2101956136
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##
@@ -893,6 +897,24 @@ private CompileResult compileReque
gortiz commented on code in PR #15445:
URL: https://github.com/apache/pinot/pull/15445#discussion_r2101903913
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##
@@ -906,10 +906,32 @@ public static class Server {
public static final int DEFAULT_MS
hpvd commented on issue #15855:
URL: https://github.com/apache/pinot/issues/15855#issuecomment-2900305920
Cleaning up is always a good idea :-)
Just some thoughts on deprecating Native Text Index
1. I’m not sure if/how we can be sure about "there is no production" use
case at the m
anandheritage commented on code in PR #15844:
URL: https://github.com/apache/pinot/pull/15844#discussion_r2101917553
##
pinot-core/src/main/java/org/apache/pinot/core/data/table/DeterministicConcurrentIndexedTable.java:
##
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Softwar
anandheritage commented on code in PR #15844:
URL: https://github.com/apache/pinot/pull/15844#discussion_r2101912781
##
pinot-core/src/main/java/org/apache/pinot/core/data/table/DeterministicConcurrentIndexedTable.java:
##
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Softwar
anandheritage commented on code in PR #15844:
URL: https://github.com/apache/pinot/pull/15844#discussion_r2101825392
##
pinot-core/src/main/java/org/apache/pinot/core/data/table/DeterministicConcurrentIndexedTable.java:
##
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Softwar
anandheritage commented on code in PR #15844:
URL: https://github.com/apache/pinot/pull/15844#discussion_r2101810223
##
pinot-core/src/main/java/org/apache/pinot/core/data/table/DeterministicConcurrentIndexedTable.java:
##
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Softwar
90 matches
Mail list logo
