dinoocch opened a new pull request, #15878: URL: https://github.com/apache/pinot/pull/15878
We found a fairly substantial performance regression on one usecase when migrating to set `pinot.offheap.prioritize.bytebuffer -> true`. <img width="855" alt="Screenshot 2025-05-22 at 3 40 15 PM" src="https://github.com/user-attachments/assets/cc928e5b-f300-4998-97b2-ed5fd0829516"; /> Reverting the config to false fixes the latency with no other changes. Instance using ByteBuffers: <img width="1427" alt="Screenshot 2025-05-22 at 3 37 15 PM" src="https://github.com/user-attachments/assets/53100001-85ec-4211-b912-b9290d92b77a"; /> Instance with UnsafePinotDataBuffer: <img width="1427" alt="Screenshot 2025-05-22 at 3 13 17 PM" src="https://github.com/user-attachments/assets/e41581fd-ded2-45bf-826f-c714777a2ab8"; /> Still trying to fully understand the root cause -- it's very odd we have only seen this in a single case so far, but definitely we see some substantial time spent on `setAccessible(true)` calls which should only need to be called once statically to make the constructor available. labels: `performance` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
